Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050863POS2POSpublic2022-11-11 14:092022-11-16 07:05
Reporterjonae 
Assigned Tojonae 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050863: Business date needs to be inherited in the till when the store is in open status.
DescriptionIf the store is open and the user log in the POS, the business date has to be inherited. Depending on the case the business date will be automatically set or the system will raise a confirmation dialog to take a decession.
Steps To Reproduce- With the store closed.
- Open the store in the backend.
- Login in POS
- The system will raise the confirmation dialog attached.
- If the user press close and open a new date, the system has to close the store an redirects to the calendar to set a new date.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0050230 closed aferraz Retail Modules Implement open/close store process in ReactPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-11 14:09jonaeNew Issue
2022-11-11 14:09jonaeAssigned To => jonae
2022-11-11 14:09jonaeTriggers an Emergency Pack => No
2022-11-11 14:11hgbotNote Added: 0143480
2022-11-14 14:43hgbotNote Added: 0143571
2022-11-15 13:04jonaeRelationship addeddepends on 0050230
2022-11-16 07:04hgbotResolutionopen => fixed
2022-11-16 07:04hgbotStatusnew => closed
2022-11-16 07:04hgbotNote Added: 0143643
2022-11-16 07:04hgbotNote Added: 0143644
2022-11-16 07:04hgbotNote Added: 0143645
2022-11-16 07:04hgbotNote Added: 0143646
2022-11-16 07:04hgbotNote Added: 0143647
2022-11-16 07:04hgbotNote Added: 0143648
2022-11-16 07:04hgbotNote Added: 0143649
2022-11-16 07:04hgbotNote Added: 0143650
2022-11-16 07:04hgbotNote Added: 0143651
2022-11-16 07:04hgbotNote Added: 0143652
2022-11-16 07:04hgbotNote Added: 0143653
2022-11-16 07:04hgbotNote Added: 0143654
2022-11-16 07:04hgbotNote Added: 0143655
2022-11-16 07:04hgbotNote Added: 0143656
2022-11-16 07:04hgbotNote Added: 0143657
2022-11-16 07:04hgbotNote Added: 0143658
2022-11-16 07:04hgbotNote Added: 0143659
2022-11-16 07:04hgbotNote Added: 0143660
2022-11-16 07:04hgbotNote Added: 0143661
2022-11-16 07:04hgbotNote Added: 0143662
2022-11-16 07:05hgbotFixed in Version => 23Q1
2022-11-16 07:05hgbotNote Added: 0143663
2022-11-16 07:05hgbotNote Added: 0143664
2022-11-16 07:05hgbotNote Added: 0143665
2022-11-16 07:05hgbotNote Added: 0143666
2022-11-16 07:05hgbotNote Added: 0143667

Notes
(0143480)
hgbot   
2022-11-11 14:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/54 [^]
(0143571)
hgbot   
2022-11-14 14:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1362 [^]
(0143643)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: bae6430ccb2f2f12ff43438e6be45b21c9870177
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/bae6430ccb2f2f12ff43438e6be45b21c9870177 [^]

Fixes ISSUE-50863: Removing overwrite initial configuration. The validate closed till needs to be set as a prehook of the initial count in order to add the step of the calendar if needed.

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/validateClosedTillsNotClosedStore.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/SetBusinessDateInServer.js
M web-jspack/org.openbravo.retail.sessions/src/ob-init.js
R web-jspack/org.openbravo.retail.sessions/src/authentication/__test__/overwriteInitialCountConfiguration.test.jsx
R web-jspack/org.openbravo.retail.sessions/src/authentication/overwriteInitialCountConfiguration.js
---
(0143644)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 009a13feea0d3f255f70a5cc342dfb8cf12dbd0c
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/009a13feea0d3f255f70a5cc342dfb8cf12dbd0c [^]

Fixes ISSUE-50863: The status of the till in the back needs to be loaded in the log in

---
M src/org/openbravo/retail/sessions/login/StoreStatusProvider.java
---
(0143645)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 9548449634e9c0f672d1ceb321fb88ceed96c570
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/9548449634e9c0f672d1ceb321fb88ceed96c570 [^]

Fixes ISSUE-50863: Changing the way the closed validation is done. It is not needed to validate if the terminal is online or offline.

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/SetBusinessDateInServer.js
---
(0143654)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: be123a41efc9e06b247c7ccfc00c2a8d27f3d8a8
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/be123a41efc9e06b247c7ccfc00c2a8d27f3d8a8 [^]

Fixes ISSUE-50863: Fixing set business date in server test because the terminal was not properly set

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/__test__/SetBusinessDateInServer.test.js
---
(0143662)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: ffa7c571aa24b91196b89313f6cdc093dc0c4751
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:03:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/ffa7c571aa24b91196b89313f6cdc093dc0c4751 [^]

Fixes ISSUE-50863: Changing the validation of the date to support the new behaviour when showing the calendar to set the business date.

---
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.scss
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/validateClosedTillsNotClosedStore.test.jsx
M src/org/openbravo/retail/sessions/login/StoreStatusProvider.java
M web-jspack/org.openbravo.retail.sessions/src/model/global/actions/AddBusinessDateToTicket.js
M web-jspack/org.openbravo.retail.sessions/src/model/global/actions/__test__/AddBusinessDateToTicket.test.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/SetBusinessDateInServer.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/__test__/SetBusinessDateInServer.test.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateWhenSelling.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/ValidateWhenSelling.test.js
M web-jspack/org.openbravo.retail.sessions/src/ob-init.js
R web-jspack/org.openbravo.retail.sessions/src/authentication/__test__/overwriteInitialCountConfiguration.test.jsx
R web-jspack/org.openbravo.retail.sessions/src/authentication/overwriteInitialCountConfiguration.js
---
(0143661)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: b89ddb8fbf256b6d0352368dc4103910de77a935
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/b89ddb8fbf256b6d0352368dc4103910de77a935 [^]

Fixes ISSUE-50863: Fixing tests

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/ValidateWhenSelling.test.js
---
(0143660)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 108c51b00a4235d7c0a3b816368881cc2df0930f
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/108c51b00a4235d7c0a3b816368881cc2df0930f [^]

Fixes ISSUE-50863: Fixing date formats. Fixing validate after selling because the dates where not properly compared

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateWhenSelling.js
---
(0143659)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 5c353e364eb9539bcc515e6de3612bba896d181f
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/5c353e364eb9539bcc515e6de3612bba896d181f [^]

Fixes ISSUE-50863: Improving the code

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
---
(0143658)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 3da30f272812fc50fbb0f689b33745a5c53c732f
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/3da30f272812fc50fbb0f689b33745a5c53c732f [^]

Fixes ISSUE-50863: Changing the way the adding step is calculated. Removing not needed variables and checks

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
---
(0143657)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 7628135b52d78e52a91a7660c970123f58b4fdef
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/7628135b52d78e52a91a7660c970123f58b4fdef [^]

Fixes ISSUE-50863: Using the the function imported to set the business date

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
---
(0143656)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: d6845848def55ec1fc90802233a40130fbbb9ed2
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/d6845848def55ec1fc90802233a40130fbbb9ed2 [^]

Fixes ISSUE-50863: Adding space between imports and the rest of the code

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
---
(0143655)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: b067415893151e5750d534c2a0f19376b4461416
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/b067415893151e5750d534c2a0f19376b4461416 [^]

Fixes ISSUE-50863: Moving validation code to user-actions folder

---
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.scss
A web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/validateClosedTillsNotClosedStore.test.jsx
M web-jspack/org.openbravo.retail.sessions/src/ob-init.js
---
(0143653)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 9d58ae084b4f6fc02c375044d567f223a386db06
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/9d58ae084b4f6fc02c375044d567f223a386db06 [^]

Fixes ISSUE-50863: Adding missing test into set business date in server action

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/__test__/SetBusinessDateInServer.test.js
---
(0143652)
hgbot   
2022-11-16 07:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/54 [^]
(0143651)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: ddacc0a9c436d1809b2f4f6549b62c3807eaad88
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/ddacc0a9c436d1809b2f4f6549b62c3807eaad88 [^]

Fixes ISSUE-50863: Saving organization in a final variable

---
M src/org/openbravo/retail/sessions/login/StoreStatusProvider.java
---
(0143650)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 119a3bb07afbab8e4c161fb3a063bee105f637dd
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/119a3bb07afbab8e4c161fb3a063bee105f637dd [^]

Fixes ISSUE-50863: Adding a new function to add or remove steps in order to reuse code

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/validateClosedTillsNotClosedStore.js
---
(0143649)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: e274fd4b2166871f78e924cf38048b3bea08a0a0
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/e274fd4b2166871f78e924cf38048b3bea08a0a0 [^]

Fixes ISSUE-50863: Adding format to the date when it is based on pos last business date terminal property

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/validateClosedTillsNotClosedStore.js
M web-jspack/org.openbravo.retail.sessions/src/model/global/actions/AddBusinessDateToTicket.js
---
(0143648)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 8388fb63b9a35c1f705c83f309c92cf33759b6a2
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/8388fb63b9a35c1f705c83f309c92cf33759b6a2 [^]

Fixes ISSUE-50863: Adding the setting of the business date when the current date is selected

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/validateClosedTillsNotClosedStore.js
---
(0143647)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: dd556b3e5894c97be0d89e0dcefa90d7f69dff63
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/dd556b3e5894c97be0d89e0dcefa90d7f69dff63 [^]

Fixes ISSUE-50863: Fixing issues when allowing to reopen on the same day

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/validateClosedTillsNotClosedStore.js
---
(0143646)
hgbot   
2022-11-16 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 2620fc653a16c77681c8e291457aaf5edbe02a18
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:02:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/2620fc653a16c77681c8e291457aaf5edbe02a18 [^]

Fixes ISSUE-50863: Adapting the tests to the new changes

---
M web-jspack/org.openbravo.retail.sessions/src/authentication/__test__/validateClosedTillsNotClosedStore.test.jsx
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/__test__/SetBusinessDateInServer.test.js
---
(0143663)
hgbot   
2022-11-16 07:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3f6d78d37ee3175c4a67fd66c1c1b519ec3e9aa2
Author: jonalegria <jon.alegria@openbravo.com>
Date: 15-11-2022 15:51:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3f6d78d37ee3175c4a67fd66c1c1b519ec3e9aa2 [^]

Fixes ISSUE-50863: Fixing cypress tests

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/initial.spec.js
---
(0143664)
hgbot   
2022-11-16 07:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 231bbcef5c4bc313c873cac8014a4fcf5c8e5f2c
Author: jonalegria <jon.alegria@openbravo.com>
Date: 15-11-2022 21:36:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/231bbcef5c4bc313c873cac8014a4fcf5c8e5f2c [^]

Fixes ISSUE-50863: Adding timeout to the cashup

---
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/countMoney.js
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/cashUp.spec.js
---
(0143665)
hgbot   
2022-11-16 07:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 116b792429d4ffbd9b9adcac33d6b7fe7e235534
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 06:02:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/116b792429d4ffbd9b9adcac33d6b7fe7e235534 [^]

Fixes ISSUE-50863: Removing commented code

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/cashUp.spec.js
---
(0143666)
hgbot   
2022-11-16 07:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1362 [^]
(0143667)
hgbot   
2022-11-16 07:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3a9bd2fb962ab651c9e97981df780b02f9d6b363
Author: jonalegria <jon.alegria@openbravo.com>
Date: 16-11-2022 07:05:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3a9bd2fb962ab651c9e97981df780b02f9d6b363 [^]

Fixes ISSUE-50863: Fixing cypress tests

---
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/countMoney.js
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/cashUp.spec.js
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/initial.spec.js
---