Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050850POS2POSpublic2022-11-11 01:152022-12-02 08:57
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned Tocaristu
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050850: RM-3720: Pager: Javascript error when choosing single pager for order in flow, 2) finish button does not allow finish pager flow
DescriptionSeveral issues occur in the pager flow:

when clicking single-pager-order button in the pager flow a js error is thrown (see screenshot and stack below)

when entering a valid pager code in the last step, the finish button is enabled but it does not allow finishing. You have to do the validate and continue. Either disable finish or allow finish to read/handle the keypad value
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-11 01:15mtaalNew Issue
2022-11-11 01:15mtaalAssigned To => mtaal
2022-11-11 01:15mtaalOBNetwork customer => No
2022-11-11 01:15mtaalTriggers an Emergency Pack => No
2022-11-11 01:18hgbotMerge Request Status => open
2022-11-11 01:18hgbotNote Added: 0143442
2022-11-29 09:19guilleaerStatusnew => scheduled
2022-12-01 10:37hgbotNote Added: 0144295
2022-12-01 11:03hgbotMerge Request Statusopen => approved
2022-12-01 11:04hgbotNote Added: 0144296
2022-12-01 11:04hgbotNote Added: 0144297
2022-12-01 11:44guilleaerStatusscheduled => resolved
2022-12-01 11:44guilleaerResolutionopen => fixed
2022-12-01 11:44guilleaerReview Assigned To => caristu
2022-12-01 11:44guilleaerStatusresolved => closed
2022-12-01 11:59guilleaerStatusclosed => new
2022-12-01 11:59guilleaerResolutionfixed => open
2022-12-01 11:59guilleaerStatusnew => scheduled
2022-12-02 08:57hgbotResolutionopen => fixed
2022-12-02 08:57hgbotStatusscheduled => closed
2022-12-02 08:57hgbotFixed in Version => 23Q1
2022-12-02 08:57hgbotNote Added: 0144329
2022-12-02 08:57hgbotNote Added: 0144330

Notes
(0143442)
hgbot   
2022-11-11 01:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1356 [^]
(0144295)
hgbot   
2022-12-01 10:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/938 [^]
(0144296)
hgbot   
2022-12-01 11:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 5074d3ea2f9ce79df75f24f66a09292ba746f1de
Author: Martin Taal <martin.taal@openbravo.com>
Date: 01-12-2022 10:04:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/5074d3ea2f9ce79df75f24f66a09292ba746f1de [^]

Related to ISSUE-50850: multi-step-process finish button - pass current step data in the payload, correct typo

---
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessFinishButton/MultiStepProcessFinishButton.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessNextButton/MultiStepProcessNextButton.jsx
---
(0144297)
hgbot   
2022-12-01 11:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/938 [^]
(0144329)
hgbot   
2022-12-02 08:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9ea73ecf9af2c95fe1a8ebc3353999b243203097
Author: Martin Taal <martin.taal@openbravo.com>
Date: 02-12-2022 07:57:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9ea73ecf9af2c95fe1a8ebc3353999b243203097 [^]

Fixed ISSUE-50850: Pager: prevent empty value to be used, preven js error

---
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/BaseScanPagerKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/ScanPagerProductKeypad.jsx
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/PagerConfiguration.js
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ProductConfiguration.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDCMConfigurationToLines.js
---
(0144330)
hgbot   
2022-12-02 08:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1356 [^]