Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005085Openbravo ERPA. Platformpublic2008-09-17 17:582008-11-25 22:54
Reporterrafaroda 
Assigned ToHennadzi 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 7.10
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0005085: Bad usage of advisePopUp
Description'advisePopUp' method can be used in two ways:

1) advisePopUp(response, Utility.messageBD(this, "strTitle", vars.getLanguage()), Utility.messageBD(this, "strText", vars.getLanguage()))

2) advisePopUp(response, strMessageType, Utility.messageBD(this, "strTitle", vars.getLanguage()), Utility.messageBD(this, "strText", vars.getLanguage()))

In some files there is no translation of 'strTitle' so the title is always displayed in English.
Steps To Reproduce1) Inside /info/AttributeSetInstance.java (2 times):
1.1) advisePopUp(response, "Info", Utility.messageBD(this, "PAttributeNoSelection", vars.getLanguage())); should be advisePopUp(response, "INFO" Utility.messageBD(this, "Info", vars.getLanguage()), Utility.messageBD(this, "PAttributeNoSelection", vars.getLanguage()));

2) Inside /utility/WindowTree.java:
2.1) advisePopUp(response, "Error", Utility.messageBD(this, "AccessTableNoView", vars.getLanguage())) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Error", vars.getLanguage()), Utility.messageBD(this, "AccessTableNoView", vars.getLanguage()))

3) Inside /ad_process/Register.java (4 times):
3.1) advisePopUp(response, "ERROR", "Registration", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Registration", vars.getLanguage()), message)

4) Inside /ad_process/TestHeartbeat.java:
4.1) (2 times) advisePopUp(response, "ERROR", "Heartbeat", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Heartbeat", vars.getLanguage()), message)
4.2) (4 times) advisePopUp(response, "ERROR", "Heartbeat Configuration", message) should be advisePopUp(response, "ERROR", Utility.messageBD(this, "Heartbeat Configuration", vars.getLanguage()), message)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0005092 closed Hennadzi Bad usage of advisePopUp 
related to feature request 0005083 acknowledged iciordia Merge advisePopUp and bdErrorGeneralPopUp methods 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-09-17 17:58rafarodaNew Issue
2008-09-17 17:58rafarodaAssigned To => cromero
2008-09-17 17:58rafarodasf_bug_id0 => 2116412
2008-09-17 17:58rafarodaRegression testing => No
2008-09-17 17:58rafarodaRelationship addedrelated to 0005083
2008-09-17 18:24rafarodaAssigned Tocromero => Hennadzi
2008-09-17 18:24rafarodaProposed Solution updated
2008-09-17 18:24rafarodaStatusnew => scheduled
2008-09-17 18:24rafarodafix_in_branch => trunk
2008-09-18 14:46svnbotCheckin
2008-09-18 14:46svnbotNote Added: 0009082
2008-09-18 14:46svnbotStatusscheduled => resolved
2008-09-18 14:46svnbotResolutionopen => fixed
2008-09-18 14:46svnbotsvn_revision => 7475
2008-11-25 22:54psarobeStatusresolved => closed

Notes
(0009082)
svnbot   
2008-09-18 14:46   
Repository: openbravo
Revision: 7475
Author: hennadzi
Date: 2008-09-18 14:46:06 +0200 (Thu, 18 Sep 2008)

Fixed bug 0005085: Bad usage of advisePopUp

---
U trunk/src/org/openbravo/erpCommon/ad_process/Register.java
U trunk/src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
U trunk/src/org/openbravo/erpCommon/info/AttributeSetInstance.java
U trunk/src/org/openbravo/erpCommon/utility/WindowTree.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=7475&sc=1 [^]