Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050843POS2POSpublic2022-11-10 16:342022-11-14 12:32
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050843: Possible to pay twice by clicking fast enough on OK button on payment
DescriptionIt is possible to pay twice the current ticket, and if the payment method is configured to also complete the ticket, this will result in two tickets being sent to backend, which results in Error while importing for duplicated ticket.

Check the screenshot to understand where the double click may happen.
Steps To Reproduce1. Login WebPOS with some payment method with payment provider, I've tested it with Credit Card - Mastercard payment provider.
2. Add a product to the ticket and go to Payments
3. Try to add credit card payment, then click 2 times in OK, check that it has been executed twice.
Proposed SolutionDon't allow double clicking on this button.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005084422Q4.1 closed cberner Possible to pay twice by clicking fast enough on OK button on payment 
depends on backport 005084522Q3.3 closed cberner Possible to pay twice by clicking fast enough on OK button on payment 
Attached Filesgif cartes bancaires payment.gif (485,056) 2022-11-10 16:34
https://issues.openbravo.com/file_download.php?file_id=17799&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-11-10 16:34cbernerNew Issue
2022-11-10 16:34cbernerAssigned To => cberner
2022-11-10 16:34cbernerFile Added: cartes bancaires payment.gif
2022-11-10 16:34cbernerTriggers an Emergency Pack => No
2022-11-10 16:37hgbotNote Added: 0143418
2022-11-10 16:44guilleaerStatusnew => scheduled
2022-11-14 12:32hgbotResolutionopen => fixed
2022-11-14 12:32hgbotStatusscheduled => closed
2022-11-14 12:32hgbotFixed in Version => 23Q1
2022-11-14 12:32hgbotNote Added: 0143529
2022-11-14 12:32hgbotNote Added: 0143532

Notes
(0143418)
hgbot   
2022-11-10 16:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1355 [^]
(0143529)
hgbot   
2022-11-14 12:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5bcf9ccb1bd9ae54f1ff7d07072500de670e3a74
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 14-11-2022 11:58:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5bcf9ccb1bd9ae54f1ff7d07072500de670e3a74 [^]

Fixes ISSUE-50843: Possible to pay twice by clicking fast enough on OK button on payment

Dialog on payments for confirmation for process provider allowed
clicking on the OK or Cancel button twice, because there was no check
that disabled it. Now it is only allowed to be clicked if the dialog has
not been closed, so it is impossible to click it twice and process twice
the resolve or close dialog functions.

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/ConfirmProcessProvider.jsx
---
(0143532)
hgbot   
2022-11-14 12:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1355 [^]