Openbravo Issue Tracking System - Retail Modules
View Issue Details
0050840Retail ModulesCopy Retail Storepublic2022-11-10 14:052022-12-06 09:27
XABIER_AGUADO 
marvintm 
highmajoralways
closedfixed 
5
 
 
marvintm
No
0050840: Copy Retail Store sets Document Sequences´Next Assigned Number to 1Million even if the original store is 10M
Copy Retail Store sets Document Sequences´ Next Assigned Number to 1Million even if the original store is 10M
On Backoffice check the Document Sequences for a Store
Change , for example, its RFC Order value to 10M
Do a CRS using that store as parent
Check the RFC Order Document Sequence for the new Store
Its 1M instead of 10M
should be 10M
FASH
png wwe.png (53,493) 2022-11-10 14:05
https://issues.openbravo.com/file_download.php?file_id=17797&type=bug
png
Issue History
2022-11-10 14:05XABIER_AGUADONew Issue
2022-11-10 14:05XABIER_AGUADOAssigned To => Retail
2022-11-10 14:05XABIER_AGUADOFile Added: wwe.png
2022-11-10 14:05XABIER_AGUADOTriggers an Emergency Pack => No
2022-11-10 14:05XABIER_AGUADOTag Attached: FASH
2022-11-11 06:02radhakrishnanAssigned ToRetail => radhakrishnan
2022-11-11 06:02radhakrishnanStatusnew => scheduled
2022-11-21 07:29marvintmReview Assigned To => marvintm
2022-11-21 07:29marvintmNote Added: 0143844
2022-11-21 07:29marvintmStatusscheduled => closed
2022-11-21 07:29marvintmResolutionopen => no change required
2022-11-30 13:43XABIER_AGUADONote Added: 0144252
2022-11-30 13:43XABIER_AGUADOStatusclosed => new
2022-12-05 10:50XABIER_AGUADOAssigned Toradhakrishnan => marvintm
2022-12-06 06:36hgbotNote Added: 0144443
2022-12-06 09:26hgbotResolutionno change required => fixed
2022-12-06 09:26hgbotStatusnew => closed
2022-12-06 09:26hgbotFixed in Version => PR23Q1
2022-12-06 09:26hgbotNote Added: 0144452
2022-12-06 09:26hgbotNote Added: 0144453
2022-12-06 09:27marvintmNote Added: 0144454

Notes
(0143844)
marvintm   
2022-11-21 07:29   
I'm rejecting this issue as "no change required" because I don't think we have to change the copy store process. However, maybe some additional discussion is needed, and maybe we need to report another issue in the BackOffice depending on the outcome of this discussion.

I believe the copy store module itself is working correctly in this case:

- When cloning an existing sequence, it would not make sense to consider the "Next assigned number" property, as the new sequence is supposed to start from the beginning, not from the point in which the existing sequence currently is.

- The question then, is what should be the beginning point, for each sequence. For this, it seems the sequence mechanism currently has a property called "Starting no", that is used in sequences that are restarted every year. The copy store is not only copying this property, but it is also using it to initialize newly cloned sequences. In general, I think this makes sense, as creating a new sequence is basically equivalent to reseting the current sequence, and as both sequences are supposed to be used for the same concept (but in different stores), it looks like it makes sense to initialize them like this.

- The tricky thing is how to configure this "starting no" column, as it is currently hidden in the backoffice. By default, it always receives the value 1000000. This is why when copy store copies a sequence, it always starts in 1M.

I think internally we should discuss if the "starting no" column should be visible always, as it would then allow users to configure this value, that I believe makes sense to be used by copy store for this.
(0144252)
XABIER_AGUADO   
2022-11-30 13:43   
Hi Marvint,

I have reviewed this with my team and we agree that making "starting no" column visible and configurabe would be the best fix for this issue.
(0144443)
hgbot   
2022-12-06 06:36   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/781 [^]
(0144452)
hgbot   
2022-12-06 09:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: bb9f203d0d6edba551b10516bdd927535822cf8d
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 05-12-2022 16:46:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/bb9f203d0d6edba551b10516bdd927535822cf8d [^]

Fixed ISSUE-50840: Starting no should be displayed based on auto numbering

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0144453)
hgbot   
2022-12-06 09:26   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/781 [^]
(0144454)
marvintm   
2022-12-06 09:27   
We have changed the display logic of this field. It is important to mention that you will still need to mark the "Auto Numbering" flag to be able to configure it.