0050839: Inconsistent state when canceling the action using an action preparation

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0050839

Retail Modules

Web POS

public

2022-11-10 13:40

2022-11-10 13:43

Reporter

aferraz

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0050839: Inconsistent state when canceling the action using an action preparation

Description

Action preparations allow to cancel the action throwing a OB.App.Class.ActionCanceled.

If the action is canceled, then following action preparations and the state action are not executed.

In case any business logic is executed before the action preparation cancels the action (using a user action in ReactPOS or backbone code in EnyoPOS), it can create an inconsistent state.

This can happen in addPayment or deletePayment state actions when using a payment provider. See 0050260.
But could happen with any state action where we have an integration run before the state action (payment integration, fiscal integration, etc.).

Steps To Reproduce

- Create a ticket
- Set stopAddingPayments property to true in ticket state.
- Add a payment using any payment provider like Adyen.
- Check the payment provider has been run but the add payment action has been canceled by AddPaymentUtils.checkStopAddingPayments() function.

Proposed Solution

Additional Information