Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050838Openbravo LocalizationsLocalization Italypublic2022-11-10 13:392022-11-16 16:16
Reporterucarrion 
Assigned Tojetxarri 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customer
Regression introduced in release
Summary0050838: Incorrect <CodiceDestinatario> for foreign customers
DescriptionThe codice destinatario set in the XML is '0000000' always that the involved customer has not an specific codice destinatario related. Currently, even if the customer is a foreigner, the value inserted in the tag is the one mentioned above while the spec says that it should be 'XXXXXXX' for foreigners (see point 1.1.4).
Steps To Reproduce-Login an Italian terminal.
-Do a sales invoice for a foreigner customer.
-Pay in cash and complete.
-Go to the backoffice and run the 'Export Italy Invoices to a XML file' background process.
Go to the Sales Order window and see the attachment generated for the record of the just generated invoice.
-Open the XML file and check the <CodiceDestinatario> tag.
Proposed SolutionIf the country of the customer is NOT Italy, the Codice Destinatario tag in the XML file will be always 'XXXXXXX'.
Additional Information
TagsNOR, NORAUTO
Relationships
has duplicate defect 0052766 closed frank_gonzalez XML Invoice Italy : Codice Destinatario at XXXXXXX for Italian customers instead of 0000000 
Attached Filesxls Table view B2B Ordinary invoice (5).xls (180,736) 2022-11-10 13:43
https://issues.openbravo.com/file_download.php?file_id=17794&type=bug
xml IT06026940012_0lfvs.xml (2,822) 2022-11-15 16:55
https://issues.openbravo.com/file_download.php?file_id=17833&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-11-10 13:39ucarrionNew Issue
2022-11-10 13:39ucarrionAssigned To => psanjuan
2022-11-10 13:39ucarrionTag Attached: NOR
2022-11-10 13:39ucarrionTag Attached: NORAUTO
2022-11-10 13:43ucarrionFile Added: Table view B2B Ordinary invoice (5).xls
2022-11-10 14:29aferrazAssigned Topsanjuan => jetxarri
2022-11-10 15:16hgbotNote Added: 0143413
2022-11-10 15:22hgbotResolutionopen => fixed
2022-11-10 15:22hgbotStatusnew => closed
2022-11-10 15:22hgbotNote Added: 0143414
2022-11-10 15:22hgbotNote Added: 0143415
2022-11-11 09:31hgbotNote Added: 0143463
2022-11-15 16:55ucarrionNote Added: 0143626
2022-11-15 16:55ucarrionStatusclosed => new
2022-11-15 16:55ucarrionResolutionfixed => open
2022-11-15 16:55ucarrionFile Added: IT06026940012_0lfvs.xml
2022-11-16 10:15hgbotNote Added: 0143680
2022-11-16 16:16hgbotResolutionopen => fixed
2022-11-16 16:16hgbotStatusnew => closed
2022-11-16 16:16hgbotNote Added: 0143720
2022-11-16 16:16hgbotNote Added: 0143721
2023-06-20 15:51frank_gonzalezRelationship addedhas duplicate 0052766

Notes
(0143413)
hgbot   
2022-11-10 15:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/23 [^]
(0143414)
hgbot   
2022-11-10 15:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice [^]
Changeset: ca2bb0379de0a21069afdee96ad504030848ef04
Author: Javier Etxarri <javier.etxarri@openbravo.com>
Date: 10-11-2022 15:15:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/commit/ca2bb0379de0a21069afdee96ad504030848ef04 [^]

Fixes ISSUE-50838: Incorrect <CodiceDestinatario> for foreign customers

---
M src/org/openbravo/localization/italy/einvoice/xmlengine/document/ItalyDatiTrasmissione.java
---
(0143415)
hgbot   
2022-11-10 15:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/23 [^]
(0143463)
hgbot   
2022-11-11 09:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice [^]
Changeset: ab5ef5d35a73f9efb73a31122d5c5176e3c75d00
Author: Javier Etxarri <javier.etxarri@openbravo.com>
Date: 11-11-2022 09:31:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/commit/ab5ef5d35a73f9efb73a31122d5c5176e3c75d00 [^]

Related ISSUE-50838: fix tests problems in ci

---
M src-test/org/openbravo/localization/italy/einvoice/TestItalyXMLCreationFromJson.java
---
(0143626)
ucarrion   
2022-11-15 16:55   
KO. The <CodiceDestinatario> is now 'XXXXXXX' even if the customer is Italian. For Italian customers with no given/known CodiceDestinatario we must inform '0000000'. 'XXXXXXX' will be for foreign customer only.

See KO example attached.
(0143680)
hgbot   
2022-11-16 10:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/28 [^]
(0143720)
hgbot   
2022-11-16 16:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice [^]
Changeset: 9977fb1859520f6ac759b937c5a0798d8431c445
Author: Javier <javieretxarri@ekinbe.com>
Date: 16-11-2022 15:16:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/commit/9977fb1859520f6ac759b937c5a0798d8431c445 [^]

Fixes ISSUE-50838: Incorrect <CodiceDestinatario> customers, if empty and italian put 00000000, else XXXXXXX

---
M src-test/org/openbravo/localization/italy/einvoice/TestItalyXMLCreationFromJson.java
M src/org/openbravo/localization/italy/einvoice/xmlengine/document/ItalyDatiTrasmissione.java
---
(0143721)
hgbot   
2022-11-16 16:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/28 [^]