Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050836POS2Corepublic2022-11-10 13:212022-11-14 16:51
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050836: On occasions service worker doesn't properly use the updated files
DescriptionIt seems on occasions, there is a reload of the application when a new version of the builds is present and the files being used after the refresh are the same as the old version, another refresh is required for this to be fixed afterwards.

The main problem seems to be that the reload of the application could generate a race condition with the activation of the new service worker, we should refresh only afterwards.
Steps To Reproduce1. Apply this diff serviceWorker.diff attached, it adds a setTimeout on the processing of the skipWaiting message of the service worker
2. Run ant build in core2
3. Start Tomcat server, and use the production build: localhost:8080/openbravo/web/pos
4. Modify the service-worker.js file in WebContent/web/pos/static to generate a new update, you can modify one of the .chunk.js files to see which one is the web page currently using

After modification, refresh the webpage, check that we're still using the older version, instead of the new one. You can check this by looking in dev-tools at the Sources tab, check the files that you modified and updated the version.
Proposed SolutionRefresh the application on service worker activation, after the messages has been properly created.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005084622Q4.1 closed cberner On occasions service worker doesn't properly use the updated files 
depends on backport 005084722Q3.3 closed cberner On occasions service worker doesn't properly use the updated files 
Attached Filesdiff serviceWorker.diff (554) 2022-11-10 13:21
https://issues.openbravo.com/file_download.php?file_id=17792&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-11-10 13:21cbernerNew Issue
2022-11-10 13:21cbernerAssigned To => cberner
2022-11-10 13:21cbernerFile Added: serviceWorker.diff
2022-11-10 13:21cbernerTriggers an Emergency Pack => No
2022-11-10 13:24hgbotNote Added: 0143387
2022-11-10 16:45guilleaerStatusnew => scheduled
2022-11-14 16:51hgbotResolutionopen => fixed
2022-11-14 16:51hgbotStatusscheduled => closed
2022-11-14 16:51hgbotNote Added: 0143587
2022-11-14 16:51hgbotFixed in Version => 23Q1
2022-11-14 16:51hgbotNote Added: 0143589

Notes
(0143387)
hgbot   
2022-11-10 13:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/906 [^]
(0143587)
hgbot   
2022-11-14 16:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/906 [^]
(0143589)
hgbot   
2022-11-14 16:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 78a3eb5bb63cf1d3e54f1933f060ce3de660a9fc
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 14-11-2022 16:00:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/78a3eb5bb63cf1d3e54f1933f060ce3de660a9fc [^]

Fixes ISSUE-50836: On occasions service worker doesn't properly use the updated files

There is a race-condition when changes are detected in the service
worker, and a reload is required. The reload was happening just after
sending a Skip Waiting message to the service-worker thread, which
sometimes does not allow the service worker to finish its process of
fetching + activation, as such it will keep old version .js files until
another refresh happens.

To avoid this, we refresh the application after we sent the message, but
once the service worker is not waiting anymore, and is in an "activated"
state.

---
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
---