0005083: Merge advisePopUp and bdErrorGeneralPopUp methods

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0005083

Openbravo ERP

A. Platform

public

2008-09-17 16:56

2009-05-22 19:34

Reporter

gorkaion

Assigned To

iciordia

Priority

low

Severity

trivial

Reproducibility

N/A

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0005083: Merge advisePopUp and bdErrorGeneralPopUp methods

Description

In 'org.openbravo.base.secureApp.HttpSecureAppServlet' class there are these 2 methods (lines 396 and 421) that could be merged into one.

They are used to open a popup window with just a message box. At this moment the main difference is that 'bdErrorGeneralPopUp' always uses the ERROR type messageBox whatever message is displayed, while in 'advisePopUp' you can set the type.

There is also another trivial difference in the html template where the bdErrorGeneralPopUp uses a window logo icon of error and the other method uses the info icon.

The other differences can be defined as bugs.

I think that the bdErrorGeneralPopUp is not necessary and we should use only the advisePopUp method. That way we can also remove the correspondent templates and only maintain one.

Steps To Reproduce

Proposed Solution

Additional Information