Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050736Retail ModulesWeb POSpublic2022-11-04 13:512022-11-04 14:56
Reporteregoitz 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket51923
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050736: An unknown error on the orderloader, does not create the import entry due to a known issue
DescriptionWhen executeing the orderloader to promote aimport entry to order, there is an unkown error.
That forces the execution of the POSDataSynchronizationErrorHandler to generate the EWI, but there is an error generating the obpos_errors_line that make the process to fail, so EWI is not created and the data import entry is keep in error.

Later putting back to initial the process fails.
Steps To Reproducenot steps. Need to check the code.
STack trace:

java.lang.NullPointerException
    at org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler.handleError(POSDataSynchronizationErrorHandler.java:131)
    at org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler$Proxy$_$$_WeldClientProxy.handleError(Unknown Source)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.handleError(DataSynchronizationProcess.java:389)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:253)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:156)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:88)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
Proposed SolutionMake the process more robuts.

If the original orderline does not exists, not fail, but generate the ewi.

Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-04 13:51egoitzNew Issue
2022-11-04 13:51egoitzAssigned To => Retail
2022-11-04 13:51egoitzOBNetwork customer => Gold
2022-11-04 13:51egoitzSupport ticket => 51923
2022-11-04 13:51egoitzTriggers an Emergency Pack => No
2022-11-04 14:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-11-04 14:08ranjith_qualiantech_comStatusnew => scheduled
2022-11-04 14:52hgbotMerge Request Status => open
2022-11-04 14:52hgbotNote Added: 0143116
2022-11-04 14:56hgbotMerge Request Statusopen => approved
2022-11-04 14:56hgbotResolutionopen => fixed
2022-11-04 14:56hgbotStatusscheduled => closed
2022-11-04 14:56hgbotFixed in Version => RR23Q1
2022-11-04 14:56hgbotNote Added: 0143117
2022-11-04 14:56hgbotNote Added: 0143118

Notes
(0143116)
hgbot   
2022-11-04 14:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/970 [^]
(0143117)
hgbot   
2022-11-04 14:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ce18b6d2fb9bade90cb54ba0621c34730842200e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-11-2022 13:56:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ce18b6d2fb9bade90cb54ba0621c34730842200e [^]

Fixed ISSUE-50736: OrderLine should be validated before adding to ErrorLine list

---
M src/org/openbravo/retail/posterminal/POSDataSynchronizationErrorHandler.java
---
(0143118)
hgbot   
2022-11-04 14:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/970 [^]