Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050732Openbravo ERP07. Sales managementpublic2022-11-04 11:442022-11-18 09:33
Reporteravicente 
Assigned Tojlopez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050732: [OPECOM] Price exceptions overlapped created from Commercial Operation using Store Sets.
DescriptionTwo price exceptions overlapped (with the same organization, starting date and ending date are created) can be created from the Commercial Operation window using Store Sets. See image ERROR 2.
Steps To Reproduce1. Login in https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/ [^]

2. Create a new 'Store Set 1' with the info in the image 'Store Set 1'.

3. Create a new 'Store Set 2' with the info in the image 'Store Set 2'.

4. Create a 'Commercial Operation' with the info in the image 'Commercial Operation'.

5. Click on 'Add Store', select 'Filter Type'='Sets of Stores', select 'Store Set 1' and 'Store Set 2' and click on 'Done'.

ERROR 1: Two lines with the same organization, starting date and ending date are created.

6. In the tab 'Product Price', change the price for a product.

7. Click on 'Validate'.

8. Navigate to 'Price List || Price List Version || Product Price || Product Price with Exception' for the product for which the price was changed in step 6.

ERROR 2: Two price exceptions with the same organization, starting date and ending date are created.
Proposed Solution- To add a new column called 'Store Set' in the in window/tab ‘Commercial Operation || Included Stores’.
- When the user add stores to the OPECOM through the selection of Store Set, the new column 'Store Set' will be informed with the Store Set which the store belongs to.
-If the user adds 2 store sets containing the same store, a warning is displayed to them saying “this store belongs to several sets of stores, it will be added only once in the list” and then add only one line in the Included Stores tab, related to the first store set selected + add the remaining stores of the second store set.
Additional Information
TagsFASH
Relationships
Attached Filespng Commercial Operation.png (122,095) 2022-11-04 11:45
https://issues.openbravo.com/file_download.php?file_id=17749&type=bug
png

png Store Set 1.png (105,973) 2022-11-04 11:45
https://issues.openbravo.com/file_download.php?file_id=17750&type=bug
png

png Store Set 2.png (101,727) 2022-11-04 11:46
https://issues.openbravo.com/file_download.php?file_id=17751&type=bug
png

png Error 1.png (135,968) 2022-11-04 11:46
https://issues.openbravo.com/file_download.php?file_id=17752&type=bug
png

png Error 2.png (121,399) 2022-11-04 11:46
https://issues.openbravo.com/file_download.php?file_id=17753&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-11-04 11:44avicenteNew Issue
2022-11-04 11:44avicenteAssigned To => Triage Omni OMS
2022-11-04 11:44avicenteModules => Core
2022-11-04 11:44avicenteTriggers an Emergency Pack => No
2022-11-04 11:45avicenteTag Attached: FASH
2022-11-04 11:45avicenteFile Added: Commercial Operation.png
2022-11-04 11:45avicenteFile Added: Store Set 1.png
2022-11-04 11:46avicenteFile Added: Store Set 2.png
2022-11-04 11:46avicenteFile Added: Error 1.png
2022-11-04 11:46avicenteFile Added: Error 2.png
2022-11-04 11:54aferrazAssigned ToTriage Omni OMS => jlopez
2022-11-04 11:56avicenteProposed Solution updated
2022-11-10 13:01rafarodaProposed Solution updated
2022-11-10 18:30avicenteProposed Solution updated
2022-11-17 19:00hgbotNote Added: 0143803
2022-11-18 09:33hgbotResolutionopen => fixed
2022-11-18 09:33hgbotStatusnew => closed
2022-11-18 09:33hgbotNote Added: 0143815
2022-11-18 09:33hgbotNote Added: 0143816

Notes
(0143803)
hgbot   
2022-11-17 19:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/27 [^]
(0143815)
hgbot   
2022-11-18 09:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 80f3866f103fbe656a931e1185408c253d8a37cb
Author: Javier López <javier.lopez@precognis.com>
Date: 18-11-2022 08:33:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/80f3866f103fbe656a931e1185408c253d8a37cb [^]

Fixes ISSUE-50732: Price exceptions overlapped created from Commercial Operation using Store Sets

Added a flush after saving the new commercial operation store.
Thus, the event handler can validate the new commercial operation store with the ones added in the same and previous processes.

---
M src/org/openbravo/commercialoperations/process/AddStoresForDateRangeProcess.java
---
(0143816)
hgbot   
2022-11-18 09:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/27 [^]