Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050727POS2POSpublic2022-11-03 23:412022-11-07 16:37
ReporterAugustoMauch 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050727: Memory leak in Carousel.jsx - DOM event listeners are not being removed
DescriptionThe Carousel.jsx component has a memory leak because it is registering DOM events on a useEffect hook but is never unregistering them.

The useEffect hook should return a function that will be invoked when unmounting the component and that will unregister the DOM events
Steps To ReproduceSee the code here [1], it is adding two event listeners but never removing them. It should removee them like it is done here [2]

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/Carousel/Carousel.jsx#L66 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/DrawerMenu/DrawerMenuGroup.jsx#L250 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005076222Q4.1 closed Retail Memory leak in Carousel.jsx - DOM event listeners are not being removed 
depends on backport 005076322Q3.3 closed Retail Memory leak in Carousel.jsx - DOM event listeners are not being removed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-03 23:41AugustoMauchNew Issue
2022-11-03 23:41AugustoMauchAssigned To => Retail
2022-11-03 23:41AugustoMauchTriggers an Emergency Pack => No
2022-11-03 23:41AugustoMauchStatusnew => scheduled
2022-11-03 23:44hgbotNote Added: 0142891
2022-11-07 16:00guilleaerStatusscheduled => acknowledged
2022-11-07 16:00guilleaerStatusacknowledged => scheduled
2022-11-07 16:34hgbotResolutionopen => fixed
2022-11-07 16:34hgbotStatusscheduled => resolved
2022-11-07 16:34hgbotNote Added: 0143170
2022-11-07 16:34hgbotFixed in Version => 23Q1
2022-11-07 16:34hgbotNote Added: 0143171
2022-11-07 16:37jarmendarizReview Assigned To => jarmendariz
2022-11-07 16:37jarmendarizStatusresolved => closed

Notes
(0142891)
hgbot   
2022-11-03 23:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/891 [^]
(0143170)
hgbot   
2022-11-07 16:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/891 [^]
(0143171)
hgbot   
2022-11-07 16:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a2f02c8266bcb6d277f50a5b1ac12339da13fb89
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 07-11-2022 15:33:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a2f02c8266bcb6d277f50a5b1ac12339da13fb89 [^]

Fixes ISSUE-50727: Avoids memory leak in Carousel.jsx by unregistering event listeners

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js
M web-jspack/org.openbravo.core2/src/components/Carousel/Carousel.jsx
---