Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050717POS2POSpublic2022-11-03 11:072022-12-20 19:36
Reporterebecerra 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2022-05-03
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/107670d7892404383be280afe7075fbf4d36412a [^]
Triggers an Emergency PackNo
Summary0050717: Product description show only 2 lines
DescriptionIn POS, when browsing, products in the product description only display a maximum of 2 lines of text even though there is room for 3 or more lines.

This function also should be taken into account by menu wizard product buttons


See attached images

Current: I-50717.png
Expected: Flun-3285.png
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0047675 closed elara Keymap-Buttons-Label height is not well managed 
Attached Filespng I-50717.png (86,211) 2022-11-03 11:11
https://issues.openbravo.com/file_download.php?file_id=17746&type=bug
png

png Flun-3285.png (149,620) 2022-11-03 11:11
https://issues.openbravo.com/file_download.php?file_id=17747&type=bug
png

png image-20221110-175151.png (150,952) 2022-11-17 12:26
https://issues.openbravo.com/file_download.php?file_id=17841&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-11-03 11:07ebecerraNew Issue
2022-11-03 11:07ebecerraAssigned To => Retail
2022-11-03 11:07ebecerraTriggers an Emergency Pack => No
2022-11-03 11:07ebecerraAssigned ToRetail => ebecerra
2022-11-03 11:08ebecerraStatusnew => scheduled
2022-11-03 11:11ebecerraFile Added: I-50717.png
2022-11-03 11:11ebecerraFile Added: Flun-3285.png
2022-11-03 11:13ebecerraDescription Updatedbug_revision_view_page.php?rev_id=25041#r25041
2022-11-03 11:34hgbotNote Added: 0142863
2022-11-10 08:15hgbotNote Added: 0143334
2022-11-10 20:34dbazNote Added: 0143438
2022-11-17 12:17guilleaerNote Deleted: 0143334
2022-11-17 12:17guilleaerNote Deleted: 0142863
2022-11-17 12:18guilleaerAssigned Toebecerra => Retail
2022-11-17 12:19guilleaerStatusscheduled => acknowledged
2022-11-17 12:24mmohammadNote Added: 0143779
2022-11-17 12:26mmohammadFile Added: image-20221110-175151.png
2022-11-17 12:29guilleaerRegression level => Production - QA Approved
2022-11-17 12:29guilleaerRegression date => 2022-05-03
2022-11-17 12:29guilleaerRegression introduced in release => pi
2022-11-17 12:29guilleaerRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/107670d7892404383be280afe7075fbf4d36412a [^]
2022-11-17 12:30guilleaerDescription Updatedbug_revision_view_page.php?rev_id=25129#r25129
2022-12-05 11:43ranjith_qualiantech_comRelationship addedcaused by 0047675
2022-12-05 11:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-12-05 11:43ranjith_qualiantech_comStatusacknowledged => scheduled
2022-12-06 14:04hgbotNote Added: 0144462
2022-12-12 13:29hgbotResolutionopen => fixed
2022-12-12 13:29hgbotStatusscheduled => closed
2022-12-12 13:29hgbotNote Added: 0144523
2022-12-12 13:29hgbotFixed in Version => 23Q1
2022-12-12 13:29hgbotNote Added: 0144524
2022-12-12 17:07hgbotNote Added: 0144549
2022-12-12 17:08marvintmNote Added: 0144550
2022-12-12 17:08marvintmStatusclosed => new
2022-12-12 17:08marvintmResolutionfixed => open
2022-12-12 17:08marvintmFixed in Version23Q1 =>
2022-12-13 07:43ranjith_qualiantech_comStatusnew => scheduled
2022-12-13 08:53hgbotNote Added: 0144565
2022-12-20 19:36hgbotResolutionopen => fixed
2022-12-20 19:36hgbotStatusscheduled => closed
2022-12-20 19:36hgbotNote Added: 0144849
2022-12-20 19:36hgbotFixed in Version => 23Q1
2022-12-20 19:36hgbotNote Added: 0144850

Notes
(0143438)
dbaz   
2022-11-10 20:34   
This is a regression, since it was reported and fixed more than one year ago: https://issues.openbravo.com/view.php?id=47675 [^]
(0143779)
mmohammad   
2022-11-17 12:24   
Be careful, we must have the same 3 lines on the menu's button (for now we have only 2 lines)
(0144462)
hgbot   
2022-12-06 14:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1406 [^]
(0144523)
hgbot   
2022-12-12 13:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1406 [^]
(0144524)
hgbot   
2022-12-12 13:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 61c3b117214450f75231084273fd0fdf66736b0a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 12-12-2022 12:29:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/61c3b117214450f75231084273fd0fdf66736b0a [^]

Fixed ISSUE-50717: Removed NoImage size in Product Button Content
* Maximum Lines of name in Product Button will be 3 if image is not present

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContent.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/calculateProductButtonLineClamp.js
---
(0144549)
hgbot   
2022-12-12 17:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 90db2f8745696fd4b700d8f3de87424245e7a829
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 12-12-2022 17:07:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/90db2f8745696fd4b700d8f3de87424245e7a829 [^]

Related to ISSUE-50717. Reverted changes because they were affecting the integration

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContent.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/calculateProductButtonLineClamp.js
---
(0144550)
marvintm   
2022-12-12 17:08   
Reopened because the fix was causing problems in integration
(0144565)
hgbot   
2022-12-13 08:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1415 [^]
(0144849)
hgbot   
2022-12-20 19:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1415 [^]
(0144850)
hgbot   
2022-12-20 19:36   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8cf7f307d34ba9cf2c8d1bd4749048eb75abed50
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-12-2022 18:36:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8cf7f307d34ba9cf2c8d1bd4749048eb75abed50 [^]

Fixed ISSUE-50717: Rows visible for product name are based on available height/width

---
A web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonStyle.js
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContent.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/__test__/ProductButtonContent.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductPopover/__test__/ProductPopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/__test__/ProductButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/ServiceConfigurationStep.scss
---