Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050652POS2POSpublic2022-10-27 01:382022-10-27 14:05
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version22Q3.2Fixed in Version22Q3.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050652: Keymap editor should not load product images when creating the keymap configuration
DescriptionThe product images are not displayed in window that allows to edit the keymap layout. But we have noticed that currently when creating the keymap configuration and storing the info about the products in the assortment, the images are being loaded and they taking a lot of space in memory.

This problem of wasting space with products images is made bigger by a memory leak that will be fixed on a separate issue: each time the resolution of the keymap to be edited is changed, a new configuration is built but the previous one remains in memory.
Steps To Reproduce- Use a big keymap that contains product images (i.e. restaurant keymap in agapes-fs-u18-test.cloud.openbravo.com)
- Open the keymap editor, select a keymap with many images, go to the edit layout step.
- Take a memory heap
- Change the resolution of the keymap being edited several times
- Take another memory heap. Notice that the size of the heap has increased a lot
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0050650 closed AugustoMauch Keymap editor should not load product images when creating the keymap configuration 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-27 01:38AugustoMauchTypedefect => backport
2022-10-27 01:38AugustoMauchTarget Version => 22Q3.2
2022-10-27 12:55hgbotNote Added: 0142642
2022-10-27 14:05hgbotResolutionopen => fixed
2022-10-27 14:05hgbotStatusscheduled => closed
2022-10-27 14:05hgbotFixed in Version => 22Q3.2
2022-10-27 14:05hgbotNote Added: 0142665
2022-10-27 14:05hgbotNote Added: 0142666

Notes
(0142642)
hgbot   
2022-10-27 12:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1319 [^]
(0142665)
hgbot   
2022-10-27 14:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e71e4549cfd13453686243db28a7707feee64c05
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-10-2022 12:04:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e71e4549cfd13453686243db28a7707feee64c05 [^]

Fixes ISSUE-50652: Do not store product img info in keymap editor context

The keymap editor does not make use of the product images, but product images were being saved in several properties of the
context (keymapProduct array, product assortment array). We can save a lot of memory just by removing the product images before
storing the information in the context of the component

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapEditorLayout.jsx
---
(0142666)
hgbot   
2022-10-27 14:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1319 [^]