Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0050635 | Retail Modules | Web POS | public | 2022-10-25 17:04 | 2023-01-03 08:07 |
|
| Reporter | gorka_gil | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR23Q1 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0050635: Fix junit tests of discounts buy x gift y |
| Description | Many tests of buy x gift y discount are failing in ci.
Needed to fix them and also check why they are not executing in try-retail
Note the errors with tomcat started or stopped could be different. |
| Steps To Reproduce | Errors:
https://builds.openbravo.com/job/mod-simple/60514/#showFailuresLink [^]
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0050558 | | closed | caristu | org.openbravo.discounts.propertycondition tests are not executed in CI |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-10-25 17:04 | gorka_gil | New Issue | |
| 2022-10-25 17:04 | gorka_gil | Assigned To | => Retail |
| 2022-10-25 17:04 | gorka_gil | Triggers an Emergency Pack | => No |
| 2022-10-25 17:05 | hgbot | Note Added: 0142568 | |
| 2022-11-03 13:07 | caristu | Relationship added | related to 0050558 |
| 2022-11-10 07:12 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2022-11-10 12:07 | ranjith_qualiantech_com | Status | new => scheduled |
| 2022-11-14 05:29 | hgbot | Note Added: 0143493 | |
| 2022-11-14 05:29 | hgbot | Note Added: 0143494 | |
| 2022-11-14 05:29 | hgbot | Note Added: 0143495 | |
| 2022-11-21 07:46 | hgbot | Resolution | open => fixed |
| 2022-11-21 07:46 | hgbot | Status | scheduled => closed |
| 2022-11-21 07:46 | hgbot | Note Added: 0143849 | |
| 2022-11-21 07:46 | hgbot | Fixed in Version | => RR23Q1 |
| 2022-11-21 07:46 | hgbot | Note Added: 0143850 | |
| 2022-11-21 07:46 | hgbot | Note Added: 0143851 | |
| 2022-11-21 07:46 | hgbot | Note Added: 0143852 | |
| 2022-11-21 07:46 | hgbot | Note Added: 0143853 | |
| 2022-11-21 07:46 | hgbot | Note Added: 0143854 | |
| 2022-11-21 13:44 | hgbot | Note Added: 0143912 | |
| 2022-12-06 07:47 | hgbot | Note Added: 0144447 | |
| 2023-01-03 07:54 | hgbot | Note Added: 0145129 | |
| 2023-01-03 08:07 | hgbot | Note Added: 0145130 | |
| 2023-01-03 08:07 | hgbot | Note Added: 0145131 | |
|
Notes |
|
|
(0142568)
|
|
hgbot
|
|
2022-10-25 17:05
|
|
|
|
|
(0143493)
|
|
hgbot
|
|
2022-11-14 05:29
|
|
|
|
|
(0143494)
|
|
hgbot
|
|
2022-11-14 05:29
|
|
|
|
|
(0143495)
|
|
hgbot
|
|
2022-11-14 05:29
|
|
|
|
|
(0143849)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
|
|
|
(0143850)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: d45075c38d5cd529a27b6ad9ae464cef652f14cb
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 13-11-2022 14:11:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/d45075c38d5cd529a27b6ad9ae464cef652f14cb [^]
Fixed ISSUE-50635: Fixed BuyXGifyY tests
* GiftQty should be considered when calculating BuyXGifyY tests
* Added "STANDARD" to the discount Sub type in reference list
* Discount name should be maximum of 60charaters
*
* DiscountDataHooks should return the respective DiscountType Datahook
and Any Type DataHook
* Added new param "DiscountRule" to DiscountRuleBOBHook's createExtraSettings method
* ScaledByTotal flag should be updated for ByTotalAmountScaled and
ByTotalPercentageScaled tests
---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/retail/discounts/test/base/model/DiscountRule.java
M src-test/org/openbravo/retail/discounts/test/base/model/DiscountRuleBOBHook.java
M src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmountScaled.java
M src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentageScaled.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAllXGiftAnyYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAllYTest.java
M src/org/openbravo/retail/discounts/DiscountDataHookSelector.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---
|
|
|
|
(0143851)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: 835c67069789028c0c42ef0fedfbe30893632fc7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 14-11-2022 09:57:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/835c67069789028c0c42ef0fedfbe30893632fc7 [^]
Related to ISSUE-50635: Update discount property tests
* DicountCRMFilters should be added to database when discount tests
are executed
* NumberComparatorTypeTest should use Number Property "xZIP"
instead of String property "xPhone2"
* DiscountPropertyCRMFilters should be grouped by "offerId" property
instead of default group property "priceAdjustment"
---
A src-test/org/openbravo/discounts/propertycondition/model/DiscountPropertyCRMBOBHook.java
M src-test/org/openbravo/discounts/propertycondition/DiscountPropertyConditionComparatorsTest.java
M src-test/org/openbravo/discounts/propertycondition/comparators/DateComparatorTypeTest.java
M src-test/org/openbravo/discounts/propertycondition/comparators/ListComparatorTypeTest.java
M src-test/org/openbravo/discounts/propertycondition/comparators/NumberComparatorTypeTest.java
M src-test/org/openbravo/discounts/propertycondition/utils/CRMUtils.java
M src/org/openbravo/discounts/propertycondition/DiscountPropertyCRMDataHook.java
M web/org.openbravo.discounts.propertycondition/js/propertyConditionDiscount.js
---
|
|
|
|
(0143852)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
|
|
|
(0143853)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
|
|
|
(0143854)
|
|
hgbot
|
|
2022-11-21 07:46
|
|
|
|
|
(0143912)
|
|
hgbot
|
|
2022-11-21 13:44
|
|
|
|
|
(0144447)
|
|
hgbot
|
|
2022-12-06 07:47
|
|
|
|
|
(0145129)
|
|
hgbot
|
|
2023-01-03 07:54
|
|
|
|
|
(0145130)
|
|
hgbot
|
|
2023-01-03 08:07
|
|
|
|
|
(0145131)
|
|
hgbot
|
|
2023-01-03 08:07
|
|
|