Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050620POS2POSpublic2022-10-24 16:462023-02-27 16:37
Reporterphilippe_mui 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050620: Approvals/reasons for manual discounts
DescriptionWhen a cashier applies a manual discount, it should be configurable whether approval and/or reason should be requested.
Steps To Reproduce-
Proposed SolutionThe need of requesting approval/reason will be configured at role level using a new user action for manual discounts. A cashier will be prompted to enter approval/reason if their role is so configured and the Approval Required flag for that given discount is set.
Additional Information
TagsFASH
Relationships
depends on feature request 0050791 closed caristu POS2 User Action Reasons 
related to defect 0051736 closed alostale Retail Modules The flag "Approval required" should be disponible for "discretionary" and "optional" promotions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-24 16:46philippe_muiNew Issue
2022-10-24 16:46philippe_muiAssigned To => Retail
2022-10-24 16:46philippe_muiOBNetwork customer => Gold
2022-10-24 16:46philippe_muiTriggers an Emergency Pack => No
2022-10-24 16:46philippe_muiTag Attached: FASH
2023-02-03 08:45alostaleTypedefect => feature request
2023-02-03 08:45alostaleSummaryNot possible to have manual discount approval in POS2 => Approvals/reasons for manual discounts
2023-02-03 08:45alostaleDescription Updatedbug_revision_view_page.php?rev_id=25494#r25494
2023-02-03 08:45alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25496#r25496
2023-02-03 08:45alostaleProposed Solution updated
2023-02-15 17:24caristuRelationship addeddepends on 0050791
2023-02-17 09:27hgbotMerge Request Status => open
2023-02-17 09:27hgbotNote Added: 0146685
2023-02-27 16:36hgbotMerge Request Statusopen => approved
2023-02-27 16:37hgbotResolutionopen => fixed
2023-02-27 16:37hgbotStatusnew => closed
2023-02-27 16:37hgbotFixed in Version => 23Q2
2023-02-27 16:37hgbotNote Added: 0147058
2023-02-27 16:37hgbotNote Added: 0147059
2023-03-01 12:57alostaleRelationship addedrelated to 0051736

Notes
(0146685)
hgbot   
2023-02-17 09:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1532 [^]
(0147058)
hgbot   
2023-02-27 16:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 99384b141c3573c7ea7593d2f6e69473b3b3e27f
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 27-02-2023 16:35:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/99384b141c3573c7ea7593d2f6e69473b3b3e27f [^]

fixes FR-50620: Approvals/reasons for manual discounts

---
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/__test__/SetLineDiscountsUserAction.test.js
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js
---
(0147059)
hgbot   
2023-02-27 16:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1532 [^]