Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050563POS2POSpublic2022-10-18 09:442022-10-19 18:14
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050563: Services multiselection step doesn't switch to loading when selecting one of the other orderlines
DescriptionWhen in a services configuration step, it is possible to select other orderlines, this updates the services on the filtered keymap to these that are allowed in multiselection and are in common between selected order lines.

When selecting another line, the refresh of the data is done in the background, but the filtered keymap is not set to loading, so it is possible to add elements before it applying the new filter/selected orderline.

A video is attached showing the problem.
Steps To Reproduce1. Login WebPOS and add GPS Handheld 2 times
2. Click on Related services button for GPS Handheld, then select the other order line.

See that the refresh of the data happens without any loading between the two of them, in this case is fast because of low amount of data, but it becomes slower and problematic when data is much bigger.
Proposed SolutionSet the filtered keymap to loading while doing a new search(after applying new filters for example).
Additional Information
TagsNo tags attached.
Relationships
Attached Files? serviceApplyFilteringNoLoading.mp4 (3,248,063) 2022-10-18 09:44
https://issues.openbravo.com/file_download.php?file_id=17668&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-10-18 09:44cbernerNew Issue
2022-10-18 09:44cbernerAssigned To => cberner
2022-10-18 09:44cbernerFile Added: serviceApplyFilteringNoLoading.mp4
2022-10-18 09:44cbernerOBNetwork customer => No
2022-10-18 09:44cbernerTriggers an Emergency Pack => No
2022-10-18 09:47hgbotMerge Request Status => open
2022-10-18 09:47hgbotNote Added: 0142208
2022-10-19 18:09hgbotMerge Request Statusopen => approved
2022-10-19 18:14hgbotResolutionopen => fixed
2022-10-19 18:14hgbotStatusnew => closed
2022-10-19 18:14hgbotFixed in Version => 23Q1
2022-10-19 18:14hgbotNote Added: 0142320
2022-10-19 18:14hgbotNote Added: 0142321

Notes
(0142208)
hgbot   
2022-10-18 09:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1285 [^]
(0142320)
hgbot   
2022-10-19 18:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e221a80079c3465e7f93fdc179d04f7cff23f46d
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-10-2022 18:08:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e221a80079c3465e7f93fdc179d04f7cff23f46d [^]

Fixes ISSUE-50563: Services multiselection step doesn't switch to loading on filter applied

When selecting another service while in multiselection service
configuration step, it should show the filtered keymap as loading,
instead of displaying the old results while doing the search in the
background.

---
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/FilteredProductsKeymap/FilteredProductsKeymap.jsx
---
(0142321)
hgbot   
2022-10-19 18:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1285 [^]