Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050562Retail ModulesWeb POSpublic2022-10-17 14:262022-10-25 07:25
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050562: Not possible to do a deferred sell of a service product with "create ticket" if not allowed Anonymous sell
DescriptionIf a service product is not marked as "Allow Anonymous Sell", it is not possible to add it to the ticket if the current business partner is the anonymous one.

This is problematic when dealing with a deferred sell. When doing so, we open an older ticket, and try to sell a service for one of the products of this older ticket. An option that is selectable is "Create new ticket", if that is selected then the process fails because newly created ticket has the anonymous customer selected.
Steps To Reproduce1. Open backoffice, login and go to Product window
2. Search for Installation Pack product, and unmark the checkbox "Allow Anonymous Sell"
3. Go to WebPOS and login, refresh data if necessary
4. Add a GPS Handheld to the ticket and complete the ticket.
5. Go to Orders, and select open the previously sold ticket.
6. Click on the Related Services icon and try to add an Installation Pack to the GPS Handheld.
7. Select "Create new ticket", see that it fails with an error.

Screenshot provided shows the error.
Proposed SolutionAllow adding the product on a new ticket but do not allow paying until a non anonymous customer is selected.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng anonDefferedSale.png (565,614) 2022-10-17 14:26
https://issues.openbravo.com/file_download.php?file_id=17666&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-10-17 14:26cbernerNew Issue
2022-10-17 14:26cbernerAssigned To => cberner
2022-10-17 14:26cbernerFile Added: anonDefferedSale.png
2022-10-17 14:26cbernerOBNetwork customer => No
2022-10-17 14:26cbernerTriggers an Emergency Pack => No
2022-10-18 18:03hgbotMerge Request Status => open
2022-10-18 18:03hgbotNote Added: 0142247
2022-10-18 18:04hgbotNote Added: 0142248
2022-10-24 18:08hgbotMerge Request Statusopen => approved
2022-10-25 07:25hgbotResolutionopen => fixed
2022-10-25 07:25hgbotStatusnew => closed
2022-10-25 07:25hgbotNote Added: 0142520
2022-10-25 07:25hgbotFixed in Version => RR23Q1
2022-10-25 07:25hgbotNote Added: 0142521
2022-10-25 07:25hgbotNote Added: 0142522
2022-10-25 07:25hgbotNote Added: 0142523
2022-10-25 07:25hgbotNote Added: 0142524

Notes
(0142247)
hgbot   
2022-10-18 18:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/962 [^]
(0142248)
hgbot   
2022-10-18 18:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1291 [^]
(0142520)
hgbot   
2022-10-25 07:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/962 [^]
(0142521)
hgbot   
2022-10-25 07:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 349ab4a3f1b7107b79d761124fe1bd28c1b822ef
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 25-10-2022 05:25:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/349ab4a3f1b7107b79d761124fe1bd28c1b822ef [^]

Fixes ISSUE-50562: Not possible to do a deferred sell of a service product if not allowed Anonymous sell

---
M web-test/model/business-object/ticket/actions/AddProduct-actionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddProduct.js
---
(0142522)
hgbot   
2022-10-25 07:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1dcf81d079e998844b941848a81bc5c711400f44
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 25-10-2022 05:25:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1dcf81d079e998844b941848a81bc5c711400f44 [^]

Related to ISSUE-50562: Code-review changes

Changes done:
- Add check on payment/checkout click to fail if the sale is not
permitted because of some line not allowed to be seld to anon customer

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0142523)
hgbot   
2022-10-25 07:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 10d201dcc02e28e464269fc24116254a59ee08b4
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 25-10-2022 05:25:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/10d201dcc02e28e464269fc24116254a59ee08b4 [^]

Related to ISSUE-50562: Not possible to do a deferred sell of a service product if not allowed Anonymous sell

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddServiceProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CompleteTicket.js
---
(0142524)
hgbot   
2022-10-25 07:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1291 [^]