Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050555POS2POSpublic2022-10-17 12:172022-10-19 09:23
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050555: RM-3313: Display of discounts on returns should be positive
DescriptionIn pos2 in the UI we show discounts on returns as negative values (see attached). This has to be changed to positive.

Also for some cases a duplicate minus sign is shown.
Steps To ReproduceDo a sale with a discount and then return it
Proposed SolutionShow positive like in the template and in the classic ui (see attached)
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2022-10-07 11-45-09.png (183,554) 2022-10-17 12:17
https://issues.openbravo.com/file_download.php?file_id=17661&type=bug
png

png Screenshot from 2022-10-07 11-40-18.png (52,566) 2022-10-17 12:17
https://issues.openbravo.com/file_download.php?file_id=17662&type=bug
png

png Screenshot from 2022-10-07 11-40-13.png (79,815) 2022-10-17 12:17
https://issues.openbravo.com/file_download.php?file_id=17663&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-10-17 12:17mtaalNew Issue
2022-10-17 12:17mtaalAssigned To => mtaal
2022-10-17 12:17mtaalFile Added: Screenshot from 2022-10-07 11-45-09.png
2022-10-17 12:17mtaalOBNetwork customer => No
2022-10-17 12:17mtaalTriggers an Emergency Pack => No
2022-10-17 12:17mtaalFile Added: Screenshot from 2022-10-07 11-40-18.png
2022-10-17 12:17mtaalFile Added: Screenshot from 2022-10-07 11-40-13.png
2022-10-17 12:29mtaalSummaryDisplay of discounts on returns should be positive => RM-3313: Display of discounts on returns should be positive
2022-10-17 12:29mtaalDescription Updatedbug_revision_view_page.php?rev_id=24907#r24907
2022-10-17 12:36hgbotMerge Request Status => open
2022-10-17 12:36hgbotNote Added: 0142144
2022-10-18 08:50guilleaerStatusnew => scheduled
2022-10-19 09:19hgbotMerge Request Statusopen => approved
2022-10-19 09:23hgbotResolutionopen => fixed
2022-10-19 09:23hgbotStatusscheduled => closed
2022-10-19 09:23hgbotFixed in Version => 23Q1
2022-10-19 09:23hgbotNote Added: 0142262
2022-10-19 09:23hgbotNote Added: 0142263

Notes
(0142144)
hgbot   
2022-10-17 12:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1281 [^]
(0142262)
hgbot   
2022-10-19 09:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d1a0a453927323d6c43cd262b3da819787692503
Author: Martin Taal <martin.taal@openbravo.com>
Date: 19-10-2022 07:23:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1a0a453927323d6c43cd262b3da819787692503 [^]

Fixes ISSUE-50555: show return lines with positive discount, prevent double negative sign

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
---
(0142263)
hgbot   
2022-10-19 09:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1281 [^]