Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050512Retail ModulesDiscounts and Promotionspublic2022-10-07 12:392022-11-21 08:00
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR22Q3.3Fixed in VersionRR22Q3.3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket50260
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050512: WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry
DescriptionWEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry
Steps To ReproduceIn the backoffice:
   Set the WEB POS Open Discounts From Keyboard to N (create a new one with the same configuration as the one with the Y value but with the Selected option checked)

In the POS:
   Add a product to the ticket
   Write 50 on the keyboard
   Click on the Receipt discounts menu entry and check the price of the product has changed (a 50% discount has been applied)
Proposed SolutionThe preference should not affect the menu entry but only the Discounts button
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0050451 closed ranjith_qualiantech_com WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-13 10:14guilleaerTypedefect => backport
2022-10-13 10:14guilleaerTarget Version => RR22Q3.2
2022-10-21 10:57hgbotNote Added: 0142390
2022-10-21 10:57hgbotNote Added: 0142391
2022-11-03 11:01marvintmTarget VersionRR22Q3.2 => RR22Q3.3
2022-11-21 08:00hgbotMerge Request Statusopen => approved
2022-11-21 08:00hgbotNote Added: 0143876
2022-11-21 08:00hgbotNote Added: 0143877
2022-11-21 08:00hgbotNote Added: 0143878
2022-11-21 08:00hgbotResolutionopen => fixed
2022-11-21 08:00hgbotStatusscheduled => closed
2022-11-21 08:00hgbotFixed in Version => RR22Q3.3
2022-11-21 08:00hgbotNote Added: 0143879

Notes
(0142390)
hgbot   
2022-10-21 10:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/426 [^]
(0142391)
hgbot   
2022-10-21 10:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/965 [^]
(0143876)
hgbot   
2022-11-21 08:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/426 [^]
(0143877)
hgbot   
2022-11-21 08:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 8cace9d530e8169f6c230b0e3a8567be5e9deebc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 21-11-2022 07:00:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/8cace9d530e8169f6c230b0e3a8567be5e9deebc [^]

Related to ISSUE-50512: Enyo Component added as param in ActionButton execute event

---
M web/org.openbravo.mobile.core/source/actions/actionbutton.js
M web/org.openbravo.mobile.core/source/actions/actionbuttonswitch.js
M web/org.openbravo.mobile.core/source/actions/actionmenu.js
M web/org.openbravo.mobile.core/source/actions/actionmodaldialogbutton.js
M web/org.openbravo.mobile.core/source/actions/actionsregistry.js
---
(0143878)
hgbot   
2022-11-21 08:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/965 [^]
(0143879)
hgbot   
2022-11-21 08:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 714a52df97015c9e058ae20f30ed47a800e5acae
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 21-11-2022 07:00:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/714a52df97015c9e058ae20f30ed47a800e5acae [^]

Fixed ISSUE-50512: Discount should be applied if triggered from Discount button
* If Pref. "WEB POS Open Discounts From Keyboard" is disabled, then
  Discount should be applied if triggered from keyboard Discount ActionButton.
  It should not be applied when Menu "Receipt Discounts" is clicked

---
M web/org.openbravo.retail.posterminal/js/actions/discount.js
---