Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050501Retail ModulesWeb POSpublic2022-10-11 18:092022-11-15 17:02
Reportercharlotte_vasseur 
Assigned Toyogaskarnik 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050501: [OPECOM] End date could be <= start date and should be >= sysdate (today)
DescriptionThe end date should be higher or equal to start date + the end date should be higher or equal to sysdate
Steps To ReproduceGo to 'Commercial operations' window
Create an OPECOM with starting date = ending date
=> An error appears but we should be able to put end date >= start date (see OPECOM end date = start date.png)

Create an OPECOM with starting date and ending date in the past
=> No error is displayed but end date should be higher or equal to sysdate (today) (see OPECOM end date past.png)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050499 closed Retail Retail Modules [OPECOM] Modify the start and end date is not possible in draft status 
related to defect 0051029 closed jlopez Modules 0051027: [OPCOM] End date can be in the past when starting date in the past 
Attached Filespng OPECOM end date = start date.png (171,085) 2022-10-11 18:09
https://issues.openbravo.com/file_download.php?file_id=17625&type=bug
png

png OPECOM end date past.png (150,652) 2022-10-11 18:10
https://issues.openbravo.com/file_download.php?file_id=17626&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-10-11 18:09charlotte_vasseurNew Issue
2022-10-11 18:09charlotte_vasseurAssigned To => Retail
2022-10-11 18:09charlotte_vasseurFile Added: OPECOM end date = start date.png
2022-10-11 18:09charlotte_vasseurTriggers an Emergency Pack => No
2022-10-11 18:10charlotte_vasseurFile Added: OPECOM end date past.png
2022-10-20 16:05rafarodaRelationship addedrelated to 0050499
2022-10-26 16:09adrianromeroAssigned ToRetail => yogaskarnik
2022-10-26 16:09adrianromeroStatusnew => scheduled
2022-10-26 18:01hgbotNote Added: 0142610
2022-11-03 10:52hgbotResolutionopen => fixed
2022-11-03 10:52hgbotStatusscheduled => closed
2022-11-03 10:52hgbotNote Added: 0142859
2022-11-03 10:52hgbotNote Added: 0142860
2022-11-03 10:52hgbotNote Added: 0142861
2022-11-03 10:52hgbotNote Added: 0142862
2022-11-09 16:57hgbotNote Added: 0143319
2022-11-10 10:02hgbotNote Added: 0143363
2022-11-10 10:02hgbotNote Added: 0143364
2022-11-15 09:42hgbotNote Added: 0143606
2022-11-15 17:02hgbotNote Added: 0143627
2022-11-15 17:02hgbotNote Added: 0143628
2022-11-29 11:14rafarodaRelationship addedrelated to 0051029

Notes
(0142610)
hgbot   
2022-10-26 18:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/20 [^]
(0142859)
hgbot   
2022-11-03 10:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 46def40953e6a50828d89d7d11f317e68fc03448
Author: Yogas Karnik <yogas.karnik@openbravo.com>
Date: 02-11-2022 11:14:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/46def40953e6a50828d89d7d11f317e68fc03448 [^]

FIXES ISSUE-0050501: End date should be higher than the Start date

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0142860)
hgbot   
2022-11-03 10:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 1e74d85c9d0fe75b3b572d5d922911b48609fbdf
Author: Yogas Karnik <yogas.karnik@openbravo.com>
Date: 02-11-2022 11:14:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/1e74d85c9d0fe75b3b572d5d922911b48609fbdf [^]

Related to ISSUE-0050501 Removed not required default value

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0142861)
hgbot   
2022-11-03 10:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 855fa6efed15b02718f4d1b1ec3d8fa3b1c272a6
Author: Yogas Karnik <yogas.karnik@openbravo.com>
Date: 02-11-2022 16:39:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/855fa6efed15b02718f4d1b1ec3d8fa3b1c272a6 [^]

Revert "Related to ISSUE-0050501 Removed not required default value"

This reverts commit 1e74d85c9d0fe75b3b572d5d922911b48609fbdf.

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0142862)
hgbot   
2022-11-03 10:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/20 [^]
(0143319)
hgbot   
2022-11-09 16:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/25 [^]
(0143363)
hgbot   
2022-11-10 10:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: bc760e31bd17c5a4306821ad70e951aea0a4663f
Author: Yogas Karnik <yogas.karnik@openbravo.com>
Date: 09-11-2022 16:56:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/bc760e31bd17c5a4306821ad70e951aea0a4663f [^]

Related to ISSUE-0050501 Removed db constraint and fixed hanffdler to validate dates

---
M src-db/database/model/tables/OBCOMOP_COM_OPERATION.xml
M src/org/openbravo/commercialoperations/events/CommercialOperationEventHandler.java
---
(0143364)
hgbot   
2022-11-10 10:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/25 [^]
(0143606)
hgbot   
2022-11-15 09:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/26 [^]
(0143627)
hgbot   
2022-11-15 17:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 1e6e982582d09908aa0d3ee4b607b2bb4de20175
Author: Yogas Karnik <yogas.karnik@openbravo.com>
Date: 15-11-2022 09:41:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/1e6e982582d09908aa0d3ee4b607b2bb4de20175 [^]

Related to ISSUE-0050501 Added update event to validate the dates when record updated

---
M src/org/openbravo/commercialoperations/events/CommercialOperationEventHandler.java
---
(0143628)
hgbot   
2022-11-15 17:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/26 [^]