Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050473Retail ModulesDiscounts and Promotionspublic2022-10-10 16:312022-10-18 12:44
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050473: User friendly selection of values for the Discount CRM Properties with a combo reference
DescriptionWhen defining a Discount CRM Property with a combo reference, it would be nice to have a user friendly interface to be able to select the value to match. Currently it is required to enter the technical search key as a string.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049021 closed yogaskarnik Retail Modules Add support for discount filters that depend on CRM properties 
related to defect 0050558 closed caristu Retail Modules org.openbravo.discounts.propertycondition tests are not executed in CI 
related to defect 0050519 closed ignacio_deandres Openbravo ERP Wrong help and description texts of Text fields in CRM Connector Configuration window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-10 16:31caristuNew Issue
2022-10-10 16:31caristuAssigned To => caristu
2022-10-10 16:31caristuTriggers an Emergency Pack => No
2022-10-10 16:31caristuIssue generated from0049021
2022-10-10 16:31caristuRelationship addedrelated to 0049021
2022-10-10 16:35hgbotNote Added: 0141928
2022-10-10 17:55hgbotNote Added: 0141930
2022-10-13 16:21caristuRelationship addedrelated to 0050519
2022-10-13 16:22caristuRelationship deletedrelated to 0050519
2022-10-13 16:42caristuRelationship addedrelated to 0050519
2022-10-17 17:09caristuRelationship addedrelated to 0050558
2022-10-18 08:25hgbotNote Added: 0142202
2022-10-18 08:25hgbotNote Added: 0142203
2022-10-18 08:31hgbotResolutionopen => fixed
2022-10-18 08:31hgbotStatusnew => closed
2022-10-18 08:31hgbotNote Added: 0142204
2022-10-18 08:31hgbotNote Added: 0142205
2022-10-18 12:44hgbotNote Added: 0142228

Notes
(0141928)
hgbot   
2022-10-10 16:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/12 [^]
(0141930)
hgbot   
2022-10-10 17:55   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/733 [^]
(0142202)
hgbot   
2022-10-18 08:25   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4a678b81d6f6d8c1ac771ac4dea0ecbe34685e3b
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 18-10-2022 08:24:33
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4a678b81d6f6d8c1ac771ac4dea0ecbe34685e3b [^]

related to ISSUE-50473: core changes

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0142203)
hgbot   
2022-10-18 08:25   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/733 [^]
(0142204)
hgbot   
2022-10-18 08:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: 80431a100bea2ef4da7d7afacc32ccbbc774b2f6
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 18-10-2022 08:27:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/80431a100bea2ef4da7d7afacc32ccbbc774b2f6 [^]

fixes ISSUE-50473: User friendly selection of CRM combo values

  User friendly selection of values of a CRM combo property when
defining a discount filter.

---
A src-db/database/sourcedata/AD_AUXILIARINPUT.xml
A src-test/org/openbravo/discounts/propertycondition/StandaloneTestSuite.java
A src-test/org/openbravo/discounts/propertycondition/dal/DiscountPropertyCrmFilterEventHandlerTest.java
A src-test/org/openbravo/discounts/propertycondition/master/DiscountPropertyCRMFilterTest.java
A src-test/org/openbravo/discounts/propertycondition/utils/CRMUtils.java
A src/org/openbravo/discounts/propertycondition/dal/DiscountPropertyCrmFilterEventHandler.java
M src-db/database/model/tables/OBPRDIS_OFFER_CRM_FILTER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/discounts/propertycondition/DiscountsPropertyConditionTestSuite.java
M src/org/openbravo/discounts/propertycondition/master/DiscountPropertyCRMFilter.java
---
(0142205)
hgbot   
2022-10-18 08:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/12 [^]
(0142228)
hgbot   
2022-10-18 12:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: fd5538a7b7660392b93b44462ef2128d10b2a905
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 18-10-2022 12:29:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/fd5538a7b7660392b93b44462ef2128d10b2a905 [^]

related to ISSUE-50473: avoid test failures in special cases

  1) Explicitly set the test discount rules as active when creating
them. This is to make the discounts visible even in the case where there
is a customization that makes the default value of the active property
to be false.
  2) The discount rule creation may fire the execution of the
SetDocumentNoHandler event handler under some special circumstances.
This class makes use of the RequestContext, so we are mocking it by
default in the discount tests to avoid failing when it is used

---
M src-test/org/openbravo/discounts/propertycondition/dal/DiscountPropertyCrmFilterEventHandlerTest.java
M src-test/org/openbravo/discounts/propertycondition/master/DiscountPropertyCRMFilterTest.java
M src-test/org/openbravo/discounts/propertycondition/utils/CRMUtils.java
---