Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050451Retail ModulesDiscounts and Promotionspublic2022-10-07 12:392022-10-17 08:54
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket50260
Regression level
Regression date
Regression introduced in releaseRR22Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/48e23b7e4e4de8e62134e7f531e9d0e826b4c5e6 [^]
Triggers an Emergency PackNo
Summary0050451: WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry
DescriptionWEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry
Steps To ReproduceIn the backoffice:
   Set the WEB POS Open Discounts From Keyboard to N (create a new one with the same configuration as the one with the Y value but with the Selected option checked)

In the POS:
   Add a product to the ticket
   Write 50 on the keyboard
   Click on the Receipt discounts menu entry and check the price of the product has changed (a 50% discount has been applied)
Proposed SolutionThe preference should not affect the menu entry but only the Discounts button
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047978 closed rqueralta Does not allow discounts from keyboard configuring touch point ui 
depends on backport 0050511RR22Q4.1 closed ranjith_qualiantech_com WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry 
depends on backport 0050512RR22Q3.3 closed ranjith_qualiantech_com WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-07 12:39ngarciaNew Issue
2022-10-07 12:39ngarciaAssigned To => Retail
2022-10-07 12:39ngarciaOBNetwork customer => OBPS
2022-10-07 12:39ngarciaSupport ticket => 50260
2022-10-07 12:39ngarciaTriggers an Emergency Pack => No
2022-10-07 12:40ngarciaOBNetwork customerOBPS => Gold
2022-10-10 10:03ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-10-10 11:36ranjith_qualiantech_comRelationship addedrelated to 0047978
2022-10-11 08:25ranjith_qualiantech_comStatusnew => scheduled
2022-10-12 08:38hgbotMerge Request Status => open
2022-10-12 08:38hgbotNote Added: 0141985
2022-10-12 08:38hgbotNote Added: 0141986
2022-10-13 10:14guilleaerStatusscheduled => acknowledged
2022-10-13 10:14guilleaerStatusacknowledged => scheduled
2022-10-13 11:03guilleaerRegression introduced in release => RR22Q1
2022-10-13 11:03guilleaerRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/48e23b7e4e4de8e62134e7f531e9d0e826b4c5e6 [^]
2022-10-16 23:01hgbotMerge Request Statusopen => approved
2022-10-17 08:53hgbotNote Added: 0142129
2022-10-17 08:53hgbotNote Added: 0142130
2022-10-17 08:54hgbotResolutionopen => fixed
2022-10-17 08:54hgbotStatusscheduled => closed
2022-10-17 08:54hgbotFixed in Version => RR23Q1
2022-10-17 08:54hgbotNote Added: 0142131
2022-10-17 08:54hgbotNote Added: 0142132

Notes
(0141985)
hgbot   
2022-10-12 08:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/422 [^]
(0141986)
hgbot   
2022-10-12 08:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/954 [^]
(0142129)
hgbot   
2022-10-17 08:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: e7cf7de23b95e1d569c4c5eccf61315bb95a058f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 16-10-2022 21:01:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/e7cf7de23b95e1d569c4c5eccf61315bb95a058f [^]

Related to ISSUE-50451: Enyo Component added as param in ActionButton execute event

---
M web/org.openbravo.mobile.core/source/actions/actionbutton.js
M web/org.openbravo.mobile.core/source/actions/actionbuttonswitch.js
M web/org.openbravo.mobile.core/source/actions/actionmenu.js
M web/org.openbravo.mobile.core/source/actions/actionmodaldialogbutton.js
M web/org.openbravo.mobile.core/source/actions/actionsregistry.js
---
(0142130)
hgbot   
2022-10-17 08:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/422 [^]
(0142131)
hgbot   
2022-10-17 08:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 95ffa67d664e2bd67add13d9a2beba2c2aca9f14
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 17-10-2022 06:53:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/95ffa67d664e2bd67add13d9a2beba2c2aca9f14 [^]

Fixed ISSUE-50451: Discount should be applied if triggered from Discount button
* If Pref. "WEB POS Open Discounts From Keyboard" is disabled, then
  Discount should be applied if triggered from keyboard Discount ActionButton.
  It should not be applied when Menu "Receipt Discounts" is clicked

---
M web/org.openbravo.retail.posterminal/js/actions/discount.js
---
(0142132)
hgbot   
2022-10-17 08:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/954 [^]