Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050441Retail ModulesDiscounts and Promotionspublic2022-10-07 00:092022-10-09 12:35
Reporterjlopez 
Assigned Tojlopez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050441: Start/End Date in Discounts: missing requirements
DescriptionFor both ‘Organization’ and ‘Store Set’ subtabs in Discounts and Promotions some requirements are missing:

1.- Default value should be the ones defined on header. For the moment the fields are left empty.
2.- Start and end dates in subtab should be included into header start and end dates. For the moment, no error is displayed.
3.- Start date should be mandatory if end date is defined. For the moment, no error is displayed for empty start date if end date is defined.

https://openbravo.atlassian.net/browse/RM-3176 [^]
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051904 closed ranjith_qualiantech_com Dates are left empty when searching via “Add Organization button” in Discount&Promo 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-07 00:09jlopezNew Issue
2022-10-07 00:09jlopezAssigned To => jlopez
2022-10-07 00:09jlopezTriggers an Emergency Pack => No
2022-10-07 00:10jlopezDescription Updatedbug_revision_view_page.php?rev_id=24842#r24842
2022-10-07 00:41hgbotNote Added: 0141810
2022-10-07 02:47hgbotNote Added: 0141811
2022-10-07 12:27hgbotNote Added: 0141852
2022-10-09 12:33hgbotResolutionopen => fixed
2022-10-09 12:33hgbotStatusnew => closed
2022-10-09 12:33hgbotFixed in Version => PR23Q1
2022-10-09 12:33hgbotNote Added: 0141860
2022-10-09 12:33hgbotNote Added: 0141861
2022-10-09 12:34hgbotFixed in VersionPR23Q1 => 23Q1
2022-10-09 12:34hgbotNote Added: 0141862
2022-10-09 12:34hgbotNote Added: 0141863
2022-10-09 12:34hgbotNote Added: 0141864
2022-10-09 12:35hgbotNote Added: 0141865
2023-04-11 10:22ranjith_qualiantech_comRelationship addedrelated to 0051904

Notes
(0141810)
hgbot   
2022-10-07 00:41   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/728 [^]
(0141811)
hgbot   
2022-10-07 02:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1260 [^]
(0141852)
hgbot   
2022-10-07 12:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/17 [^]
(0141860)
hgbot   
2022-10-09 12:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 04f8bb3016d8fc691d942adea74a580a296f34da
Author: Javier López <javier.lopez@precognis.com>
Date: 09-10-2022 10:33:39
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/04f8bb3016d8fc691d942adea74a580a296f34da [^]

Fixes ISSUE-50441: Missing requirements for start/end date in discounts, organization subtab

---
A src/org/openbravo/event/PricingAdjustmentOrganizationEventHandler.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0141861)
hgbot   
2022-10-09 12:33   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/728 [^]
(0141862)
hgbot   
2022-10-09 12:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6f9ceece76bd9f3a137760f8d174526f1785f408
Author: Javier López <javier.lopez@precognis.com>
Date: 09-10-2022 10:34:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6f9ceece76bd9f3a137760f8d174526f1785f408 [^]

Fixes ISSUE-50441: Missing requirements for start/end date in discounts, store set subtab

---
A src/org/openbravo/pos2/event/OBPOS2StoreSetPriceAdjustmentEventHandler.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0141863)
hgbot   
2022-10-09 12:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1260 [^]
(0141864)
hgbot   
2022-10-09 12:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: a79f5339cdd5f066ba2a6fcadd244af24faa9901
Author: Javier López <javier.lopez@precognis.com>
Date: 09-10-2022 10:34:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/a79f5339cdd5f066ba2a6fcadd244af24faa9901 [^]

Related to ISSUE-50441: Change date messages for core messages

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/commercialoperations/events/CommercialOperationStoreEventHandler.java
---
(0141865)
hgbot   
2022-10-09 12:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/17 [^]