Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050412POS2POSpublic2022-10-04 19:232022-10-20 14:26
Reportergorka_gil 
Assigned ToAaron_Alvarez 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050412: Optional free products discounts with the flag gift reminder notification, should also be shown in featured discounts
DescriptionRight now only are show if the application method of the discount is automatic, it should be also shown when is optional
Steps To ReproduceCreate a new discount of free product:
- Free Products per Total Amount
- starting date: something before today
- total receipt: 100
- application method: optional
- gift reminder notification

Go to pos
- refresh masterdata
- add an avalanche(or something that is more than 100€)
- click on pay

ERROR: the discount is not show as available
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049961 closed jorge-garcia Jira 886 - Gift on a minimum amount of ticket 
causes defect 0050893 closed Aaron_Alvarez Optional discounts with giftNotification gives error when navigating to order discounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-04 19:23gorka_gilNew Issue
2022-10-04 19:23gorka_gilAssigned To => gorka_gil
2022-10-04 19:23gorka_gilOBNetwork customer => No
2022-10-04 19:23gorka_gilTriggers an Emergency Pack => No
2022-10-04 19:23gorka_gilRelationship addedrelated to 0049961
2022-10-04 19:23gorka_gilAssigned Togorka_gil => Aaron_Alvarez
2022-10-04 19:27gorka_gilSummaryFree products should be also shonw in optional discounts => Optional free products discounts with the flag gift reminder notification, should also be shown in optional discounts
2022-10-04 19:28gorka_gilSummaryOptional free products discounts with the flag gift reminder notification, should also be shown in optional discounts => Optional free products discounts with the flag gift reminder notification, should also be shown in featured discounts
2022-10-17 17:26hgbotMerge Request Status => open
2022-10-17 17:26hgbotNote Added: 0142179
2022-10-17 17:35hgbotNote Added: 0142182
2022-10-20 11:51hgbotNote Added: 0142335
2022-10-20 11:51hgbotMerge Request Statusopen => merged
2022-10-20 11:51hgbotNote Added: 0142336
2022-10-20 11:51hgbotMerge Request Statusmerged => approved
2022-10-20 11:51hgbotResolutionopen => fixed
2022-10-20 11:51hgbotStatusnew => closed
2022-10-20 11:51hgbotFixed in Version => 23Q1
2022-10-20 11:51hgbotNote Added: 0142337
2022-10-20 11:51hgbotNote Added: 0142338
2022-10-20 14:26hgbotNote Added: 0142355
2022-11-14 17:58Aaron_AlvarezRelationship addedcauses 0050893

Notes
(0142179)
hgbot   
2022-10-17 17:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1283 [^]
(0142182)
hgbot   
2022-10-17 17:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/70 [^]
(0142335)
hgbot   
2022-10-20 11:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 917f093cb3bed7fa54ffad20850dd61e530c623b
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 20-10-2022 09:50:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/917f093cb3bed7fa54ffad20850dd61e530c623b [^]

Related to ISSUE-50412: Gift Reminder in optional discounts

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js
---
(0142336)
hgbot   
2022-10-20 11:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/70 [^]
(0142337)
hgbot   
2022-10-20 11:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0725047418f157fd29ff16927243f25185c2a393
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 20-10-2022 09:51:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0725047418f157fd29ff16927243f25185c2a393 [^]

Fixed ISSUE-50412: Gift Reminder in optional discounts

---
M src-db/database/sourcedata/AD_FIELD.xml
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInfoCell/OrderDiscountInfoCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/__test__/giftReminderNotificationRuleImpls.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/getGiftReminderNotificationList.js
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/giftReminderNotificationRuleImpls.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetFeaturedDiscountsIntoTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetFeaturedDiscountsIntoTicketActionPreparation.js
---
(0142338)
hgbot   
2022-10-20 11:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1283 [^]
(0142355)
hgbot   
2022-10-20 14:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e02b6e0a904170bc9e79c9e6daae0c13b79078b0
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 20-10-2022 14:25:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e02b6e0a904170bc9e79c9e6daae0c13b79078b0 [^]

Related to ISSUE-50412: Adapt tests of jest to work with the new changes

---
M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js
---