Openbravo Issue Tracking System - Retail Modules | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0050404 | Retail Modules | Web POS | public | 2022-10-04 15:42 | 2022-10-07 08:22 |
| Reporter | jorgewederago | ||||
| Assigned To | ranjith_qualiantech_com | ||||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | RR23Q1 | |||
| Merge Request Status | approved | ||||
| Review Assigned To | |||||
| OBNetwork customer | No | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0050404: External Business Partner constructor is not handling number type properly | ||||
| Description | When creating an External Business Partner using its constructor if one of the values passed to it is a 0 it gets converted to null | ||||
| Steps To Reproduce | Backend 1.-Ensure that there is a CRM Connector active 2.-Go to CRM Connector and look for a property that is configured as number eg:xZIP 3.-Get the name of the property WebPOS/ReactPOS 1.-Load the terminal 2.-Open the console and create a new object using a JSON that contains the property name from before and assign to it a value of 0 Eg: new OB.App.Class.ExternalBusinessPartner({'xZIP':0}) 3.- Check that the object has been created but the value of property is null NOTE: The value is inside the mixedBP Array. 4.- Do the same but instead of setting 0 use another number Eg: new OB.App.Class.ExternalBusinessPartner({'xZIP':3}) 5.- Check that the object has been create and the value of the property is the proper one | ||||
| Proposed Solution | 0 should also be considered as a valid value if we are creating the object from a JSON that contains it as a value for a number type field. This should be done in the following method: mixPlainBusinessPartnerWithProperties The idea is to also validate Number type to ensure 0 is not considered as something that can be nullable | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2022-10-04 15:42 | jorgewederago | New Issue | |||
| 2022-10-04 15:42 | jorgewederago | Assigned To | => Retail | ||
| 2022-10-04 15:42 | jorgewederago | OBNetwork customer | => No | ||
| 2022-10-04 15:42 | jorgewederago | Triggers an Emergency Pack | => No | ||
| 2022-10-04 15:49 | jorgewederago | Proposed Solution updated | |||
| 2022-10-05 07:28 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com | ||
| 2022-10-05 07:28 | ranjith_qualiantech_com | Status | new => scheduled | ||
| 2022-10-05 07:51 | jorgewederago | Proposed Solution updated | |||
| 2022-10-06 07:10 | hgbot | Merge Request Status | => open | ||
| 2022-10-06 07:10 | hgbot | Note Added: 0141708 | |||
| 2022-10-06 12:17 | hgbot | Merge Request Status | open => approved | ||
| 2022-10-06 12:17 | hgbot | Resolution | open => fixed | ||
| 2022-10-06 12:17 | hgbot | Status | scheduled => closed | ||
| 2022-10-06 12:17 | hgbot | Note Added: 0141723 | |||
| 2022-10-06 12:17 | hgbot | Fixed in Version | => RR23Q1 | ||
| 2022-10-06 12:17 | hgbot | Note Added: 0141724 | |||
| 2022-10-07 07:26 | hgbot | Note Added: 0141816 | |||
| 2022-10-07 08:22 | hgbot | Note Added: 0141821 | |||
| 2022-10-07 08:22 | hgbot | Note Added: 0141822 | |||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||