Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050260POS2POSpublic2022-09-15 16:532023-09-29 09:11
Reporterdorian_robillard 
Assigned Tojlopez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned Toaferraz
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050260: Limit payment method when refund with Adyen
DescriptionWhen in channel touchpoint type is defined : Allowed PMs for Refund = Only these defined, the behaviour if you try tu refund in POS with a payment method not in the tab PM for refund is that a pop up appear when clickin in done to say that this payment method can't be used.
However when we use a payment method with a pyment provider (Adyen for example), the call to the provider is done before checking if the payment method is authorized.

https://openbravo.atlassian.net/browse/RM-3597 [^]
Steps To ReproducePre requisite
Configure a payment method 1 with Adyen provider
Configure a payment method 2 with the field Allowed PMs for Refund = Only these defined+ Doesn't add in the tab the payment method with Adyen provider

1) in the POS, create a sale and pay with paymenty method 2
2) Do a verified return and refund with payment method 1
3) The provider ADYEN is called to do the refund
4) When paid an error message appear to say that this payment method is not autorized
Proposed SolutionThe pop up message should be displayed when clicking in the payment method 1 and no call to the service provider should be done
Additional Information
TagsFASH
Relationships
related to feature request 0049909 closed igor_trebol Retail Modules Credit Card Refunds 
related to defect 0053355 closed igor_trebol POS2 Refund in Credit card when paying in Cash / Credit Note / Gift card 
depends on defect 0050331 closed njimenez Retail Modules Payments limit management 
related to design defect 0050839 new Retail Retail Modules Inconsistent state when canceling the action using an action preparation 
Attached Filespng PM for refund.png (93,879) 2022-09-15 16:53
https://issues.openbravo.com/file_download.php?file_id=17520&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-09-15 16:53dorian_robillardNew Issue
2022-09-15 16:53dorian_robillardAssigned To => Retail
2022-09-15 16:53dorian_robillardFile Added: PM for refund.png
2022-09-15 16:53dorian_robillardTriggers an Emergency Pack => No
2022-09-15 16:53dorian_robillardTag Attached: FASH
2022-09-19 14:59rafarodaOBNetwork customer => Gold
2022-10-28 12:48aferrazRelationship addedrelated to 0049909
2022-11-02 12:54aferrazAssigned ToRetail => jlopez
2022-11-02 12:54aferrazDescription Updatedbug_revision_view_page.php?rev_id=25032#r25032
2022-11-10 11:01aferrazRelationship addeddepends on 0050331
2022-11-10 13:40aferrazRelationship addedrelated to 0050839
2022-11-22 09:57hgbotMerge Request Status => open
2022-11-22 09:57hgbotNote Added: 0143992
2022-11-22 19:27hgbotNote Added: 0144027
2022-12-03 15:25hgbotMerge Request Statusopen => approved
2022-12-03 15:26hgbotNote Added: 0144388
2022-12-03 15:26hgbotResolutionopen => fixed
2022-12-03 15:26hgbotStatusnew => closed
2022-12-03 15:26hgbotFixed in Version => RR23Q1
2022-12-03 15:26hgbotNote Added: 0144389
2022-12-03 15:27hgbotFixed in VersionRR23Q1 => 23Q1
2022-12-03 15:27hgbotNote Added: 0144390
2022-12-03 15:27hgbotNote Added: 0144391
2022-12-05 17:20hgbotNote Added: 0144426
2022-12-05 17:20hgbotFixed in Version23Q1 => RR23Q1
2022-12-05 17:20hgbotNote Added: 0144427
2022-12-12 10:15aferrazStatusclosed => new
2022-12-12 10:15aferrazResolutionfixed => open
2022-12-12 10:15aferrazFixed in VersionRR23Q1 =>
2022-12-12 14:51igor_trebolReview Assigned To => aferraz
2022-12-12 14:51igor_trebolNote Added: 0144533
2022-12-12 14:51igor_trebolStatusnew => closed
2023-09-29 09:11rafarodaRelationship addedrelated to 0053355

Notes
(0143992)
hgbot   
2022-11-22 09:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/995 [^]
(0144027)
hgbot   
2022-11-22 19:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1385 [^]
(0144388)
hgbot   
2022-12-03 15:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/995 [^]
(0144389)
hgbot   
2022-12-03 15:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7c911f3a8ca0b55d982b9e395d3c8665a0484674
Author: Javier López <javier.lopez@precognis.com>
Date: 03-12-2022 14:26:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7c911f3a8ca0b55d982b9e395d3c8665a0484674 [^]

Fixes ISSUE-50260: Validate the payment methods for returns before the payment process

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/js/components/paymentvalidation.js
---
(0144390)
hgbot   
2022-12-03 15:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3badd6f397e1438ee131e2f49fc7177e2fc6c46f
Author: Javier López <javier.lopez@precognis.com>
Date: 03-12-2022 14:27:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3badd6f397e1438ee131e2f49fc7177e2fc6c46f [^]

Fixes ISSUE-50260: Validate the payment methods for returns before the payment process

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/payments/PrePaymentValidation.js
---
(0144391)
hgbot   
2022-12-03 15:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1385 [^]
(0144426)
hgbot   
2022-12-05 17:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 03eee67aed662646ff9148554578c70d9ba9dcc1
Author: Javier López <javier.lopez@precognis.com>
Date: 05-12-2022 16:57:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/03eee67aed662646ff9148554578c70d9ba9dcc1 [^]

Revert "Fixes ISSUE-50260: Validate the payment methods for returns before the payment process"

This reverts commit 3badd6f397e1438ee131e2f49fc7177e2fc6c46f.

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/payments/PrePaymentValidation.js
---
(0144427)
hgbot   
2022-12-05 17:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 27898bea1090635fd36d9002c5cc76660f1bc0c6
Author: Javier López <javier.lopez@precognis.com>
Date: 05-12-2022 17:05:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/27898bea1090635fd36d9002c5cc76660f1bc0c6 [^]

Revert "Fixes ISSUE-50260: Validate the payment methods for returns before the payment process"

This reverts commit 7c911f3a8ca0b55d982b9e395d3c8665a0484674.

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/js/components/paymentvalidation.js
---
(0144533)
igor_trebol   
2022-12-12 14:51   
For the refund limit validations the credit card number is needed, and is only obtained after calling the payment provider, so the validations need to always be done afterwards.