Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050222POS2POSpublic2022-09-12 12:012022-09-20 10:38
Reporterasier_perez 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050222: Recent change in Key Map Editor causes an error if there are no existing categories
DescriptionWhen clicking the button to create a new category in Key Map Editor, if there is not any existing category, an error occurs. Since currently there are existing categories in Key Map Editor, the error cannot be reproduced manually, but it can be reproduced through Cypress end-to-end tests for POS2. The error message that shows in the tests is attached in this issue.

The cause of the error is related to this commit: https://gitlab.com/openbravo/devel/pmods/org.openbravo.pos2/-/commit/681c8566293983f747dfe49476916467977c97a9 [^]
Steps To ReproduceIt will require some time to execute the Cypress tests to get the error.

1. Go to Jenkins: https://builds.openbravo.com/job/mod-retail-pos2-modules-cypress/ [^]
2. Click on 'Rebuild Last'
3. Type this in the CONFIG_FILE_NAME field: retail/pos2-modules.json
4. Click on 'Rebuild' and wait until the job finishes (usually it takes between 30 to 60 minutes)
5. Click on the job once it finishes
6. Click on 'Build Artifacts'
7. Click on download all files in zip
8. Unzip the file and search the video inside it

Alternatively,if you have a Cypress context in your localhost, you could better open Cypress and run keyMapEditor.spec.js test.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0050130 closed ruben_jimenez RM-1098: Keymap editor - Default category 
Attached Filespng error.png (394,378) 2022-09-12 12:01
https://issues.openbravo.com/file_download.php?file_id=17503&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-09-12 12:01asier_perezNew Issue
2022-09-12 12:01asier_perezAssigned To => ruben_jimenez
2022-09-12 12:01asier_perezFile Added: error.png
2022-09-12 12:01asier_perezTriggers an Emergency Pack => No
2022-09-12 12:08asier_perezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24759#r24759
2022-09-12 13:21ruben_jimenezRelationship addedcaused by 0050130
2022-09-12 13:23hgbotNote Added: 0141023
2022-09-12 13:40ruben_jimenezNote Added: 0141025
2022-09-20 10:38hgbotResolutionopen => fixed
2022-09-20 10:38hgbotStatusnew => closed
2022-09-20 10:38hgbotNote Added: 0141253
2022-09-20 10:38hgbotFixed in Version => 22Q4
2022-09-20 10:38hgbotNote Added: 0141254

Notes
(0141023)
hgbot   
2022-09-12 13:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1197 [^]
(0141025)
ruben_jimenez   
2022-09-12 13:40   
Testing google doc: https://docs.google.com/spreadsheets/d/1i3OEIAHd03LJJ1518GQE4gUcZUAPuYFFcO7DY91_4zM/edit?usp=sharing [^]
(0141253)
hgbot   
2022-09-20 10:38   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1197 [^]
(0141254)
hgbot   
2022-09-20 10:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bb5c623a77288d195a40d21641ab6fd9ba36de09
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 20-09-2022 08:38:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bb5c623a77288d195a40d21641ab6fd9ba36de09 [^]

FIXED ISSUE-50222: Added condition to check if there are categories in keymap section

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.jsx
---