Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050202Retail ModulesGift cards and gift voucherspublic2022-09-08 13:302022-09-13 10:46
Reporterjonae 
Assigned Tojonae 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q4 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050202: The possibility to share sequence between gift card and credit note needs to be removed.
DescriptionThe possibility to share sequence between gift card and credit note needs to be removed. Now, a sequence for gift cards needs to be implemented.
Steps To ReproduceIn this FR https://issues.openbravo.com/view.php?id=49982 [^] this possibility was added. Now needs to be removed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049982 closed jonae Add the possibility to use the same sequence number in credit notes and gift cards. Add a digit control algorithm 
has duplicate defect 0050212 closed jonae Columns have been duplicated in the merge of the functionality of gift card sequence. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-09-08 13:30jonaeNew Issue
2022-09-08 13:30jonaeAssigned To => jonae
2022-09-08 13:30jonaeOBNetwork customer => No
2022-09-08 13:30jonaeTriggers an Emergency Pack => No
2022-09-08 13:31jonaeRelationship addedrelated to 0049982
2022-09-09 13:26hgbotResolutionopen => fixed
2022-09-09 13:26hgbotStatusnew => resolved
2022-09-09 13:26hgbotNote Added: 0140934
2022-09-09 13:27marvintmReview Assigned To => marvintm
2022-09-09 13:27marvintmStatusresolved => closed
2022-09-09 13:27marvintmFixed in Version => RR22Q4
2022-09-09 14:55hgbotNote Added: 0140962
2022-09-12 11:07hgbotMerge Request Status => open
2022-09-12 11:07hgbotNote Added: 0141009
2022-09-12 11:20hgbotMerge Request Statusopen => approved
2022-09-12 11:29hgbotNote Added: 0141010
2022-09-12 11:29hgbotNote Added: 0141011
2022-09-13 08:06jonaeRelationship addedhas duplicate 0050212
2022-09-13 10:45hgbotNote Added: 0141040
2022-09-13 10:46hgbotNote Added: 0141041

Notes
(0140934)
hgbot   
2022-09-09 13:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 1fe5ace186b00b23a7a96092a876cf1d5f6b66d2
Author: jonalegria <jon.alegria@openbravo.com>
Date: 09-09-2022 13:25:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/1fe5ace186b00b23a7a96092a876cf1d5f6b66d2 [^]

Fixes ISSUE-50202: Adding gift card prefix and sequence. Adding the possibility to define digit control algorithm and length to credit note generation.

---
A src/org/openbravo/retail/giftcards/ad_callouts/ResetGiftCardSequenceNumber.java
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/PGCProductProperties.java
M src/org/openbravo/retail/giftcards/term/CreditNoteSequence.java
M src/org/openbravo/retail/giftcards/term/GiftCardSequence.java
M src/org/openbravo/retail/giftcards/term/TerminalProperties.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
M web-jspack/org.openbravo.retail.giftcards/src/configurations/giftCard-configuration/GiftCardConfiguration.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
M web/org.openbravo.retail.giftcards/js/model/product-properties.js
---
(0140962)
hgbot   
2022-09-09 14:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 896acd3ff38661f117c18dab8bc2d2a619d0d3e4
Author: jonalegria <jon.alegria@openbravo.com>
Date: 09-09-2022 14:55:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/896acd3ff38661f117c18dab8bc2d2a619d0d3e4 [^]

Related to ISSUE-50202: Reverting the last functionality

---
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/PGCProductProperties.java
M src/org/openbravo/retail/giftcards/term/CreditNoteSequence.java
M src/org/openbravo/retail/giftcards/term/GiftCardSequence.java
M src/org/openbravo/retail/giftcards/term/TerminalProperties.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
M web-jspack/org.openbravo.retail.giftcards/src/configurations/giftCard-configuration/GiftCardConfiguration.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
M web/org.openbravo.retail.giftcards/js/model/product-properties.js
R src/org/openbravo/retail/giftcards/ad_callouts/ResetGiftCardSequenceNumber.java
---
(0141009)
hgbot   
2022-09-12 11:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/146 [^]
(0141010)
hgbot   
2022-09-12 11:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 0d226351867471a710f329b12868b710a0cb4f46
Author: jonalegria <jon.alegria@openbravo.com>
Date: 12-09-2022 11:29:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/0d226351867471a710f329b12868b710a0cb4f46 [^]

Fixes ISSUE-50202: Adding new columns to manage the gift card sequence creation. Adding columns to include control digit in gift cards and credit notes

---
A src/org/openbravo/retail/giftcards/ad_callouts/ResetGiftCardSaleSequenceNumber.java
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/PGCProductProperties.java
M src/org/openbravo/retail/giftcards/term/CreditNoteSequence.java
M src/org/openbravo/retail/giftcards/term/GiftCardSequence.java
M src/org/openbravo/retail/giftcards/term/TerminalProperties.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
M web-jspack/org.openbravo.retail.giftcards/src/configurations/giftCard-configuration/GiftCardConfiguration.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
M web/org.openbravo.retail.giftcards/js/model/product-properties.js
---
(0141011)
hgbot   
2022-09-12 11:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/146 [^]
(0141040)
hgbot   
2022-09-13 10:45   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: a196a305b02f4cca746f668f742364d03299999d
Author: jonalegria <jon.alegria@openbravo.com>
Date: 13-09-2022 10:45:31
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/a196a305b02f4cca746f668f742364d03299999d [^]

Related to ISSUE-50202: Fixing sampledata

---
M referencedata/sampledata/Retail_Test/OBPOS_APPLICATIONS.xml
---
(0141041)
hgbot   
2022-09-13 10:46   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: f6c5a800f372a3655e8f448e6d8c69dfa09d5cb9
Author: jonalegria <jon.alegria@openbravo.com>
Date: 13-09-2022 10:45:57
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/f6c5a800f372a3655e8f448e6d8c69dfa09d5cb9 [^]

Related to ISSUE-50202: Fixing sampledata

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APPLICATIONS.xml
---