Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050175POS2POSpublic2022-09-06 12:192022-11-14 12:59
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050175: JIRA RM-891: Improve BuyXGiftY to fulfill all cases
DescriptionAs of now, Buy X Gift Y rule requires to buy all x products and will gift all y products.

This rule is quite restrictive, so the idea is to implement at least buy any x products and gift any y products scenario
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0050307 closed javierRodriguez POS2 Create a way to being able to close an Input Data API dialog not using buttons on button bar 
related to defect 0052169 new Retail Retail Modules Documentation missing about new features in Buy X and get Y as gift discount type 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-09-06 12:19jorge-garciaNew Issue
2022-09-06 12:19jorge-garciaAssigned To => jorge-garcia
2022-09-06 12:19jorge-garciaTriggers an Emergency Pack => No
2022-09-06 12:19jorge-garciaStatusnew => scheduled
2022-09-07 14:24hgbotNote Added: 0140809
2022-09-14 12:47hgbotNote Added: 0141099
2022-09-14 12:53hgbotNote Added: 0141101
2022-09-15 07:47hgbotNote Added: 0141132
2022-09-15 08:25hgbotNote Added: 0141135
2022-09-15 08:32hgbotNote Added: 0141136
2022-09-22 09:47jorge-garciaRelationship addedrelated to 0050307
2022-09-22 10:51hgbotNote Added: 0141298
2022-10-24 17:04hgbotNote Added: 0142474
2022-10-24 17:04hgbotResolutionopen => fixed
2022-10-24 17:04hgbotStatusscheduled => closed
2022-10-24 17:04hgbotFixed in Version => RR23Q1
2022-10-24 17:04hgbotNote Added: 0142476
2022-10-24 17:08hgbotNote Added: 0142477
2022-10-24 17:08hgbotNote Added: 0142478
2022-10-24 17:11hgbotNote Added: 0142480
2022-10-24 17:11hgbotNote Added: 0142481
2022-10-24 17:14hgbotNote Added: 0142484
2022-10-24 17:14hgbotFixed in VersionRR23Q1 => 23Q1
2022-10-24 17:14hgbotNote Added: 0142485
2022-10-24 17:15hgbotNote Added: 0142486
2022-10-24 17:15hgbotNote Added: 0142487
2022-10-24 17:16hgbotNote Added: 0142488
2022-10-24 17:16hgbotNote Added: 0142489
2022-10-24 17:18hgbotNote Added: 0142490
2022-10-24 17:18hgbotNote Added: 0142491
2022-10-26 19:47hgbotNote Added: 0142626
2022-11-03 19:46hgbotNote Added: 0142889
2022-11-04 16:42hgbotNote Added: 0143119
2022-11-08 19:47hgbotNote Added: 0143272
2022-11-13 08:43hgbotNote Added: 0143486
2022-11-13 08:43hgbotNote Added: 0143487
2022-11-14 12:59hgbotNote Added: 0143561
2022-11-14 12:59hgbotNote Added: 0143562
2023-04-19 14:31ngarciaRelationship addedrelated to 0052169

Notes
(0140809)
hgbot   
2022-09-07 14:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/62 [^]
(0141099)
hgbot   
2022-09-14 12:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/922 [^]
(0141101)
hgbot   
2022-09-14 12:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1203 [^]
(0141132)
hgbot   
2022-09-15 07:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/30 [^]
(0141135)
hgbot   
2022-09-15 08:25   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/24 [^]
(0141136)
hgbot   
2022-09-15 08:32   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/36 [^]
(0141298)
hgbot   
2022-09-22 10:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/21 [^]
(0142474)
hgbot   
2022-10-24 17:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/62 [^]
(0142476)
hgbot   
2022-10-24 17:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: a7f09020c7b1a83956b30a9cee9b978d031cee20
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:04:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/a7f09020c7b1a83956b30a9cee9b978d031cee20 [^]

Fixes ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
---
(0142477)
hgbot   
2022-10-24 17:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8aeb1d1025bd6d221e79c05ab0acfcb99acd834c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:08:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8aeb1d1025bd6d221e79c05ab0acfcb99acd834c [^]

Related to ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0142478)
hgbot   
2022-10-24 17:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/922 [^]
(0142480)
hgbot   
2022-10-24 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal [^]
Changeset: 8d347e583dc3b0e5ff8b9e41c65020a2435bf9d3
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:10:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/commit/8d347e583dc3b0e5ff8b9e41c65020a2435bf9d3 [^]

Related to ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
M web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js
---
(0142481)
hgbot   
2022-10-24 17:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/21 [^]
(0142485)
hgbot   
2022-10-24 17:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3494166900a825e9e278ae1d5c4aa4571eb27ef9
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:13:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3494166900a825e9e278ae1d5c4aa4571eb27ef9 [^]

Fixes ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
---
(0142484)
hgbot   
2022-10-24 17:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1203 [^]
(0142486)
hgbot   
2022-10-24 17:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 3d59acb6165163c24ea6012006de15d547fe1cbc
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:15:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/3d59acb6165163c24ea6012006de15d547fe1cbc [^]

Related to ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0142487)
hgbot   
2022-10-24 17:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/30 [^]
(0142488)
hgbot   
2022-10-24 17:16   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 82a7e84222baff84a736cabb806f49833e074c0c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:16:29
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/82a7e84222baff84a736cabb806f49833e074c0c [^]

Related to ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0142489)
hgbot   
2022-10-24 17:16   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/24 [^]
(0142490)
hgbot   
2022-10-24 17:18   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: ff9b7037a991ec8779ff09796705c069649432c3
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-10-2022 17:18:30
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/ff9b7037a991ec8779ff09796705c069649432c3 [^]

Related to ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0142491)
hgbot   
2022-10-24 17:18   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/36 [^]
(0142626)
hgbot   
2022-10-26 19:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1317 [^]
(0142889)
hgbot   
2022-11-03 19:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/890 [^]
(0143119)
hgbot   
2022-11-04 16:42   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/890 [^]
(0143272)
hgbot   
2022-11-08 19:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/902 [^]
(0143486)
hgbot   
2022-11-13 08:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 00a14b548106e6eda3c17baeb9ce0018fdfb510d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 13-11-2022 07:43:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/00a14b548106e6eda3c17baeb9ce0018fdfb510d [^]

Related to ISSUE-50175: add missing data-testid to icon of DefaultBaseHeaderColumn

---
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/DefaultBaseHeaderColumn.jsx
---
(0143487)
hgbot   
2022-11-13 08:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/902 [^]
(0143561)
hgbot   
2022-11-14 12:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1317 [^]
(0143562)
hgbot   
2022-11-14 12:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 89d1595fb0934e4700540399c336acf43a9cfd13
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 14-11-2022 12:58:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89d1595fb0934e4700540399c336acf43a9cfd13 [^]

Fixed ISSUE-50175: Merge branch 'fr/50175-improveBuyXGiftY'

---
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogContent/__test__/FeaturedDiscountProductSelectionDialogContent.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogContent/__test__/GiftProductQuantitySelectedUtilities.test.js
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountMultipleProductSelectionDialogProductList/__test__/FeaturedDiscountMultipleProductSelectionDialogProductList.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogInfoButton/__test__/FeaturedDiscountProductSelectionDialogInfoButton.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogProductName/__test__/FeaturedDiscountProductSelectionDialogProductName.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogQuantityInput/__test__/FeaturedDiscountProductSelectionDialogQuantityInput.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogSelectCheckBox/__test__/FeaturedDiscountProductSelectionDialogSelectCheckBox.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountSingleProductSelectionDialogProductList/__test__/FeaturedDiscountSingleProductSelectionDialogProductList.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/__test__/FeaturedDiscountProductSelectionDialogProductList.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogSubtitle/__test__/FeaturedDiscountProductSelectionDialogSubtitle.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/__test__/FeaturedDiscountProductSelection.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelection.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountMultipleProductSelectionDialogProductList/FeaturedDiscountMultipleProductSelectionDialogProductList.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountMultipleProductSelectionDialogProductList/FeaturedDiscountMultipleProductSelectionDialogProductList.scss
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogProductName/FeaturedDiscountProductSelectionDialogProductName.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountProductSelectionDialogQuantityInput/FeaturedDiscountProductSelectionDialogQuantityInput.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountProductSelection/FeaturedDiscountProductSelectionDialogProductList/FeaturedDiscountSingleProductSelectionDialogProductList/FeaturedDiscountSingleProductSelectionDialogProductList.scss
---