Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050072Retail ModulesWeb POSpublic2022-08-25 22:382023-12-26 11:47
Reporteraxelmercado 
Assigned ToRetail 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket48057
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050072: No Invoice generated in Cancel & Replace
DescriptionWhen performing a Cancel & Replace of an order, 2 positive invoices are generated corresponding to the original order and the new one, but no invoice is generated for the cancellation.
Steps To Reproduce1. Generate an order in WebPOS and complete it,
2. Perform a Canel & Replace on this same order.
3. Complete the order.
4. In Backoffice we see the 3 correct sales orders, 2 with a positive amount and one with a negative amount.
5. Check the sales invoices and notice that there is not one that corresponds to the cancellation.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0051236 closed Retail Cancel and replace does not generate a negative invoice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-25 22:38axelmercadoNew Issue
2022-08-25 22:38axelmercadoAssigned To => Triage Omni OMS
2022-08-25 22:38axelmercadoOBNetwork customer => OBPS
2022-08-25 22:38axelmercadoModules => Core
2022-08-25 22:38axelmercadoSupport ticket => 48057
2022-08-25 22:38axelmercadoTriggers an Emergency Pack => No
2022-08-26 07:49PracticsIssue Monitored: Practics
2022-08-26 10:12jorge-garciaAssigned ToTriage Omni OMS => Retail
2022-08-26 14:12marvintmProjectOpenbravo ERP => Retail Modules
2022-08-26 14:12marvintmCategory07. Sales management => Web POS
2022-08-26 14:12marvintmversionPR21Q4.4 =>
2022-08-26 14:12marvintmTarget VersionPR21Q4.1 =>
2022-09-01 07:00ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-09-01 07:15ranjith_qualiantech_comStatusnew => scheduled
2022-09-05 06:45marvintmNote Added: 0140660
2022-09-05 06:45marvintmTypedefect => design defect
2022-09-09 08:03ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => Retail
2022-09-13 14:45axelmercadoPriorityhigh => urgent
2022-09-13 14:45axelmercadoSeveritymajor => critical
2022-12-27 07:20ranjith_qualiantech_comRelationship addedhas duplicate 0051236
2023-11-21 18:11hgbotMerge Request Status => open
2023-11-21 18:11hgbotNote Added: 0157434
2023-11-21 18:20hgbotNote Added: 0157436
2023-11-27 07:46hgbotNote Added: 0157648
2023-12-04 00:18hgbotNote Added: 0157931
2023-12-18 14:30hgbotNote Added: 0158298
2023-12-18 16:00hgbotMerge Request Statusopen => approved
2023-12-26 11:47hgbotNote Added: 0158597
2023-12-26 11:47hgbotNote Added: 0158598
2023-12-26 11:47hgbotNote Added: 0158599
2023-12-26 11:47hgbotNote Added: 0158600
2023-12-26 11:47hgbotNote Added: 0158601
2023-12-26 11:47hgbotNote Added: 0158602
2023-12-26 11:47hgbotNote Added: 0158603
2023-12-26 11:47hgbotNote Added: 0158604
2023-12-26 11:47hgbotResolutionopen => fixed
2023-12-26 11:47hgbotStatusscheduled => closed
2023-12-26 11:47hgbotNote Added: 0158605
2023-12-26 11:47hgbotFixed in Version => PR24Q1
2023-12-26 11:47hgbotNote Added: 0158606
2023-12-26 11:47hgbotNote Added: 0158607
2023-12-26 11:47hgbotNote Added: 0158608
2023-12-26 11:47hgbotNote Added: 0158609
2023-12-26 11:47hgbotNote Added: 0158610

Notes
(0140660)
marvintm   
2022-09-05 06:45   
This topic is complex, because the invoices would not just need to be generated, but also printed. I've raised it as a topic to product management, as it should be considered a project, not just a bug.
(0157434)
hgbot   
2023-11-21 18:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1411 [^]
(0157436)
hgbot   
2023-11-21 18:20   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1054 [^]
(0157648)
hgbot   
2023-11-27 07:46   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/348 [^]
(0157931)
hgbot   
2023-12-04 00:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/80 [^]
(0158298)
hgbot   
2023-12-18 14:30   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1411 [^]
(0158597)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: db36db95665a5b768ab357d6c1d8e920d4b9971e
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/db36db95665a5b768ab357d6c1d8e920d4b9971e [^]

Related to ISSUE-50072: Generate the cancel return invoice corresponding to cancelation

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/CancelOrderExecutor.java
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158601)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 8888bfb7805f3f52fd41fe607e8dc5d47a630652
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8888bfb7805f3f52fd41fe607e8dc5d47a630652 [^]

Related to ISSUE-50072: Eliminated unnecessary methods for cancel return invoice creation.

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/CancelOrderExecutor.java
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158605)
hgbot   
2023-12-26 11:47   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1054 [^]
(0158604)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 32cc780002005b9630e714cfa67ee21dc94a2540
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/32cc780002005b9630e714cfa67ee21dc94a2540 [^]

Related to ISSUE-50072: Fixed Orderline from inverse order not being updated

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158603)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 551522773b37f52937cf02072dbc788affb0df86
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/551522773b37f52937cf02072dbc788affb0df86 [^]

Related to ISSUE-50072: Fixed formats.

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158602)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6a829528a6570114dc1ffe88b43f65e3421baa6f
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6a829528a6570114dc1ffe88b43f65e3421baa6f [^]

Related to ISSUE-50072: Fixed comments from previous commit.

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158600)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: aaf36f0c41522ba2009c86c1f5ad9afeb1b8133b
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/aaf36f0c41522ba2009c86c1f5ad9afeb1b8133b [^]

Related to ISSUE-50072: Adjust the cancel return invoice creation (layaways error)

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0158599)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d9db0c0a5819dceac8cd7fd59a75d91fc1f3254f
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d9db0c0a5819dceac8cd7fd59a75d91fc1f3254f [^]

Related to ISSUE-50072: Adjust the cancel return invoice creation

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0158598)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: be756347c2c9c5067db3a8b3a27253064225f037
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 21-12-2023 21:53:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/be756347c2c9c5067db3a8b3a27253064225f037 [^]

Related to ISSUE-50072: Adjust the cancel return invoice corresponding to cancelation

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/CancelOrderExecutor.java
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158606)
hgbot   
2023-12-26 11:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6755e4b359411799c84cd25aab3d4d4d9c858985
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 26-12-2023 11:46:45
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6755e4b359411799c84cd25aab3d4d4d9c858985 [^]

Fixed ISSUE-50072: Added generation of negative invoice in Cancel and Replace

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0158607)
hgbot   
2023-12-26 11:47   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/348 [^]
(0158608)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: d79de06cea0c3f16f220be9f4bb60454d6d3b5fa
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 18-12-2023 14:30:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/d79de06cea0c3f16f220be9f4bb60454d6d3b5fa [^]

Related to ISSUE-50072: Adjust test to the cancel return invoice corresponding to cancelation

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I36324_CancelAndRplcInvOrdWithReturn_AddProd.java
---
(0158609)
hgbot   
2023-12-26 11:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/80 [^]
(0158610)
hgbot   
2023-12-26 11:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^]
Changeset: 121291bbe86ffa5e5ff5214a4228ef6f2f7833ae
Author: jose.garcia <jose.garcia@doceleguas.com>
Date: 26-12-2023 10:47:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/121291bbe86ffa5e5ff5214a4228ef6f2f7833ae [^]

Related to ISSUE-50072: Created push API event for the generated Invoice in Cancel & Replace flow.

---
M src/org/openbravo/retail/api/events/order/OrderLoaderEventsHook.java
---