Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050043POS2Corepublic2022-08-24 00:092022-09-09 10:37
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050043: Add display logic support for form items of BaseForm
Description-
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-24 00:09AugustoMauchNew Issue
2022-08-24 00:09AugustoMauchAssigned To => AugustoMauch
2022-08-24 00:09AugustoMauchOBNetwork customer => No
2022-08-24 00:09AugustoMauchTriggers an Emergency Pack => No
2022-08-24 00:09AugustoMauchStatusnew => scheduled
2022-08-24 00:18hgbotMerge Request Status => open
2022-08-24 00:18hgbotNote Added: 0140328
2022-08-24 00:23hgbotNote Added: 0140329
2022-09-08 09:04hgbotMerge Request Statusopen => approved
2022-09-09 10:37hgbotResolutionopen => fixed
2022-09-09 10:37hgbotStatusscheduled => closed
2022-09-09 10:37hgbotNote Added: 0140898
2022-09-09 10:37hgbotFixed in Version => 22Q4
2022-09-09 10:37hgbotNote Added: 0140899
2022-09-09 10:37hgbotNote Added: 0140900
2022-09-09 10:37hgbotNote Added: 0140901

Notes
(0140328)
hgbot   
2022-08-24 00:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/821 [^]
(0140329)
hgbot   
2022-08-24 00:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1155 [^]
(0140898)
hgbot   
2022-09-09 10:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/821 [^]
(0140899)
hgbot   
2022-09-09 10:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0ca540d1a77b05ff32b4bd7999f327ab231a5346
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 09-09-2022 10:26:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0ca540d1a77b05ff32b4bd7999f327ab231a5346 [^]

Fixes ISSUE-50043: Supports display logic for form items

Now the showIf property of the formitems, that represents an arrow function that receives the form state and returns a boolean that determines the
form item visibility, will be taken into account when rendering the form items.

---
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/BaseForm.test.jsx
---
(0140900)
hgbot   
2022-09-09 10:37   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c8fcb6f3a3d9e09bd9029e09a1549079280e802b
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 09-09-2022 09:51:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c8fcb6f3a3d9e09bd9029e09a1549079280e802b [^]

Related to ISSUE-50043: Adds support for display logic in form items of CustomerForm Handler

Display logic for formItems can be defined programatically like this
(first parameter is apiKey of field, second argument is arrow function
that receives form state and returns boolean that determines the field
visibility):

customerFormHandler.addDisplayLogic(
    'xName',
    formState => formState.fields.xLastName.value !== 'JWE'
);

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
---
(0140901)
hgbot   
2022-09-09 10:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1155 [^]