Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050030POS2POSpublic2022-08-23 09:552022-10-04 08:11
Reporternoemieroussel 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050030: The refresh data does not work well to update the promotion with CRM Property Condition
DescriptionAfter changing the string value in the CRM Property condition in a promotion and doing an incremental refresh master data, the promotion is still available for anonymous customer

Steps To Reproduce1. Creation of the discount with CRM Property Condition

2.Assign the product with CRM Property Condition to anonymous customer, the promotion is not display : OK

3. Assign the product with CRM Property Condition with customer following the characteristics of the promotion, the promotion is display : OK

4.Unassigned the identified customer, the promotion is not display anymore : OK

5. Change the String value of the CRM Property Condition in the promotion

6. Click on the Refresh master data button, and select the product from the promotion. The promotion is not display for the previous client, who does not comply anymore with the criteria of the promotion: OK

7. Assign the client following the characteristics of the promotion to the ticket, and add the product, the promotion is display : OK

8.Unassigned the customer to the ticket again, the promotion disappear : KO

-->the promotion is still display even with anonymous customer
Proposed Solution
Additional Information
TagsFASH
Relationships
related to defect 0049763 closed sntgreale The refresh data does not work well to update the promotion with CRM Property Condition 
related to defect 0050029 closed ranjith_qualiantech_com Price list ending date is not updated in WebPOS with incremental refresh data 
causes defect 0052618 closed ranjith_qualiantech_com Pos 2: promotions wrongly configured block the access to the WebPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-23 09:55noemierousselNew Issue
2022-08-23 09:55noemierousselAssigned To => Retail
2022-08-23 09:55noemierousselTriggers an Emergency Pack => No
2022-08-23 09:56noemierousselTag Attached: FASH
2022-08-23 17:25rafarodaRelationship addedrelated to 0049763
2022-08-23 17:26rafarodaRelationship addedrelated to 0050029
2022-09-07 12:02ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-09-07 12:09ranjith_qualiantech_comStatusnew => scheduled
2022-09-14 12:53hgbotNote Added: 0141100
2022-09-23 08:15hgbotResolutionopen => fixed
2022-09-23 08:15hgbotStatusscheduled => closed
2022-09-23 08:15hgbotNote Added: 0141315
2022-09-23 08:15hgbotNote Added: 0141316
2022-09-27 15:23ranjith_qualiantech_comNote Added: 0141419
2022-09-27 15:23ranjith_qualiantech_comStatusclosed => new
2022-09-27 15:23ranjith_qualiantech_comResolutionfixed => open
2022-09-27 15:24ranjith_qualiantech_comStatusnew => scheduled
2022-09-27 17:33hgbotNote Added: 0141424
2022-09-29 07:25hgbotNote Added: 0141472
2022-09-29 07:25hgbotResolutionopen => fixed
2022-09-29 07:25hgbotStatusscheduled => closed
2022-09-29 07:25hgbotNote Added: 0141473
2022-10-03 12:18hgbotNote Added: 0141559
2022-10-04 05:31hgbotNote Added: 0141608
2022-10-04 05:36ranjith_qualiantech_comNote Added: 0141610
2022-10-04 05:36ranjith_qualiantech_comStatusclosed => new
2022-10-04 05:36ranjith_qualiantech_comResolutionfixed => open
2022-10-04 05:36ranjith_qualiantech_comStatusnew => scheduled
2022-10-04 08:09hgbotNote Added: 0141616
2022-10-04 08:09hgbotNote Added: 0141617
2022-10-04 08:10hgbotNote Added: 0141618
2022-10-04 08:10hgbotNote Added: 0141619
2022-10-04 08:11marvintmStatusscheduled => resolved
2022-10-04 08:11marvintmFixed in Version => pi
2022-10-04 08:11marvintmResolutionopen => fixed
2022-10-04 08:11marvintmReview Assigned To => marvintm
2022-10-04 08:11marvintmStatusresolved => closed
2023-05-31 15:08ranjith_qualiantech_comRelationship addedcauses 0052618

Notes
(0141100)
hgbot   
2022-09-14 12:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/7 [^]
(0141315)
hgbot   
2022-09-23 08:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: a397cfee7e29420337e4fd80f8c17814a2b02e69
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 14-09-2022 16:22:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/a397cfee7e29420337e4fd80f8c17814a2b02e69 [^]

Fixed ISSUE-50030: CRM Filters should be updated in POS Discounts
* CRM Filters should be added through additionalDiscountFilter instead of hook,
  since hook OBPOS_DiscountsCacheInitialization is not present in POS2
* Removed activeCriteria in DiscountPropertyCRMFilter, since we have incrementalUpdateCriteria

---
A web/org.openbravo.discounts.propertycondition/js/propertyConditionDiscount.js
M src/org/openbravo/discounts/propertycondition/DiscountsPropertyConditionComponentProvider.java
M src/org/openbravo/discounts/propertycondition/master/DiscountPropertyCRMFilter.java
M web/org.openbravo.discounts.propertycondition/js/property-condition-discount-hooks.js
---
(0141316)
hgbot   
2022-09-23 08:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/7 [^]
(0141419)
ranjith_qualiantech_com   
2022-09-27 15:23   
DiscountPropertyCRMFilter are not loaded in POS when it is defined in different organization. It should be loaded based on discount organization
(0141424)
hgbot   
2022-09-27 17:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/8 [^]
(0141472)
hgbot   
2022-09-29 07:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/8 [^]
(0141473)
hgbot   
2022-09-29 07:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: f46d66cb9735af8a16881e55855605db72b02b77
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 27-09-2022 21:02:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/f46d66cb9735af8a16881e55855605db72b02b77 [^]

Fixed ISSUE-50030: Updated CRMFilter query to filter data based on discounts

---
M src/org/openbravo/discounts/propertycondition/master/DiscountPropertyCRMFilter.java
---
(0141559)
hgbot   
2022-10-03 12:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/10 [^]
(0141608)
hgbot   
2022-10-04 05:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/415 [^]
(0141610)
ranjith_qualiantech_com   
2022-10-04 05:36   
DiscountPropertyCRMFilter are not loaded in POS when discount is updated is backoffice.
Steps to Reproduce
Load POS2 (Make sure Discounts with CRM Filter presents)
Add Product & confirm discounts are applied
Backoffice: Update discount description
POS2: Do Refresh Masterdata (POS2 should not be reloaded)
Add Product & confirm discounts are not applied <= KO
(0141616)
hgbot   
2022-10-04 08:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: f661bdaa3a20bc50ac99b515a20b47fe4ade5139
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-10-2022 06:09:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/f661bdaa3a20bc50ac99b515a20b47fe4ade5139 [^]

Related to ISSUE-50030: Added Org Field in CRM Filter Property Condition tab
* When saving record with Org field, crm filter is saved with discount org
  instead of session org

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0141617)
hgbot   
2022-10-04 08:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/10 [^]
(0141618)
hgbot   
2022-10-04 08:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d6a1d4f03f0a48eaa5793b783e45ce3c70c13f5e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-10-2022 09:00:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d6a1d4f03f0a48eaa5793b783e45ce3c70c13f5e [^]

Related to ISSUE-50030: Masterdata PostHook should be called synchronously
* After incremental refresh, PostHook function should be called synchronously
* PreRefreshHooks, PostRefreshHooks & PostBackgroundRefreshHooks
  should be called synchronously

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0141619)
hgbot   
2022-10-04 08:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/415 [^]