Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050012Openbravo ERPA. Platformpublic2022-08-19 09:372022-08-25 16:52
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050012: Support logging slow datasource requests
DescriptionIt would be convenient to be able to log information about datasource requests where the time it takes to get the information from the database takes longer than a given configured number of milliseconds. This configuration should be defined by tab.

The logged line will be structured and must contain at least:
- The name of the tab whose information was being requested
- The query that was executed
- The number of milliseconds it took to execute the query
- The request parameters

The info must be logged in a way that allows that log to be written into a separate file other than openbravo.log
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-19 09:37AugustoMauchNew Issue
2022-08-19 09:37AugustoMauchAssigned To => AugustoMauch
2022-08-19 09:37AugustoMauchModules => Core
2022-08-19 09:37AugustoMauchTriggers an Emergency Pack => No
2022-08-19 09:38AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=24643#r24643
2022-08-19 09:52hgbotNote Added: 0140242
2022-08-25 13:46hgbotResolutionopen => fixed
2022-08-25 13:46hgbotStatusnew => closed
2022-08-25 13:46hgbotNote Added: 0140396
2022-08-25 13:46hgbotFixed in Version => PR22Q4
2022-08-25 13:46hgbotNote Added: 0140397
2022-08-25 16:07hgbotNote Added: 0140400
2022-08-25 16:52hgbotNote Added: 0140404

Notes
(0140242)
hgbot   
2022-08-19 09:52   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/688 [^]
(0140396)
hgbot   
2022-08-25 13:46   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/688 [^]
(0140397)
hgbot   
2022-08-25 13:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 756e86fdf8c4bbc18c8269fa9fe92b0d9e9667b0
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 25-08-2022 11:45:47
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/756e86fdf8c4bbc18c8269fa9fe92b0d9e9667b0 [^]

Fixes ISSUE-50012: Enables logging info about slow datasource queries

---
A modules/org.openbravo.service.datasource/src-db/database/model/tables/OBSERDS_DS_OBS_CONFIG.xml
A modules/org.openbravo.service.json/src/org/openbravo/service/json/observability/logger/DatasourceObservabilityLogger.java
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MENU.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_TAB.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_TABLE.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_TREENODE.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_WINDOW.xml
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0140400)
hgbot   
2022-08-25 16:07   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 59275a0bd81a6183c62bd5b1cb16d13baea560bb
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 25-08-2022 14:07:14
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/59275a0bd81a6183c62bd5b1cb16d13baea560bb [^]

Related to ISSUE-50012: Prevents error when tabId is not provided in datasource request
---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/observability/logger/DatasourceObservabilityLogger.java
---
(0140404)
hgbot   
2022-08-25 16:52   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d8d47830e9e4b10e16aecca6e0d80193c2633f1f
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 25-08-2022 16:50:29
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d8d47830e9e4b10e16aecca6e0d80193c2633f1f [^]

Related to ISSUE-50012: Hotfix last to fix compilation error.

Use commons-lang2 library we have in backoffice. Last commit accidentlly
used commona-lang3 (with different java package) we do not have as a jar
file in core.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/observability/logger/DatasourceObservabilityLogger.java
---