Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049982Retail ModulesGift cards and gift voucherspublic2022-08-10 15:512022-08-26 08:44
Reporterjonae 
Assigned Tojonae 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049982: Add the possibility to use the same sequence number in credit notes and gift cards. Add a digit control algorithm
DescriptionAdd the possibility to use the same sequence number in credit notes and gift cards. Add a digit control algorithm that could be extensible in custom modules.
Steps To Reproduce- Add a new flag to use the same sequence number in credit notes and in gift cards.
- Add the possibility to define an algorithm to calculate the digit control.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050202 closed jonae The possibility to share sequence between gift card and credit note needs to be removed. 
related to feature request 0049981 closed jonae Add the possibility to define a template for the sending by email option in gift cards and credit notes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-10 15:51jonaeNew Issue
2022-08-10 15:51jonaeAssigned To => Retail
2022-08-10 15:51jonaeOBNetwork customer => No
2022-08-10 15:51jonaeTriggers an Emergency Pack => No
2022-08-11 13:04hgbotMerge Request Status => open
2022-08-11 13:04hgbotNote Added: 0140061
2022-08-24 09:18jonaeAssigned ToRetail => jonae
2022-08-25 11:30hgbotMerge Request Statusopen => approved
2022-08-26 08:44hgbotResolutionopen => fixed
2022-08-26 08:44hgbotStatusnew => closed
2022-08-26 08:44hgbotNote Added: 0140416
2022-08-26 08:44hgbotNote Added: 0140417
2022-09-08 13:31jonaeRelationship addedrelated to 0050202
2023-10-05 10:22aferrazRelationship addedrelated to 0049981

Notes
(0140061)
hgbot   
2022-08-11 13:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/138 [^]
(0140416)
hgbot   
2022-08-26 08:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: e87aad2d9904396d452106896ccbf6a959acd71c
Author: jonalegria <jon.alegria@openbravo.com>
Date: 26-08-2022 08:43:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/e87aad2d9904396d452106896ccbf6a959acd71c [^]

Fixes ISSUE-49982: Adding the possibility to use the credit note sequence in the gift cards generation

---
A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
M src-db/database/model/modifiedTables/M_PRODUCT.xml
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/PGCProductProperties.java
M src/org/openbravo/retail/giftcards/term/CreditNoteSequence.java
M src/org/openbravo/retail/giftcards/term/TerminalProperties.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
M web-jspack/org.openbravo.retail.giftcards/src/configurations/giftCard-configuration/GiftCardConfiguration.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/__test__/TicketExtension.test.jsx
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
M web/org.openbravo.retail.giftcards/js/model/product-properties.js
---
(0140417)
hgbot   
2022-08-26 08:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/138 [^]