Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049979Retail ModulesDiscounts and Promotionspublic2022-08-09 17:582022-08-15 13:52
Reporterrfacon 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049979: Inactive discount is downloaded when POS is connected
DescriptionA wrongly configured combo promotion (defined without any family) which has never been active blocks the WebPOS when we try to reach it.

Only active discounts should be taken into account when connecting the WebPOS.
Steps To Reproduce1. Login the Back Office

2. In Discounts and Promotions window, create a new promotion :
- Discount/Promotion Type : Combo
- Active : N
- Put as starting date today or before
- Add no family

3. Connect the WebPOS. An error message ca be seen 'There were an error loading the POS Terminal. Discounts for the type Combo is not associated with family'
Proposed Solution
Additional Information
TagsFASH, NOR
Relationships
related to defect 0049742 closed ranjith_qualiantech_com Combo promotion wrongly configured block the access to the WebPOS 
related to defect 0049699 closed Retail The module "Combo" does not exist in Livebuilds for POS2 
related to defect 0032359 closed ranjith_qualiantech_com [SERQA 750] A combo defined without any family launch a javascript error when it is selecting 
Attached Filespng Combo configuration.PNG (56,082) 2022-08-09 17:58
https://issues.openbravo.com/file_download.php?file_id=17391&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-08-09 17:58rfaconNew Issue
2022-08-09 17:58rfaconAssigned To => Retail
2022-08-09 17:58rfaconFile Added: Combo configuration.PNG
2022-08-09 17:58rfaconTriggers an Emergency Pack => No
2022-08-10 07:12rafarodaOBNetwork customer => Gold
2022-08-10 07:12rafarodaTag Attached: NOR
2022-08-10 07:12rafarodaTag Attached: FASH
2022-08-10 07:12rafarodaRelationship addedrelated to 0049742
2022-08-10 07:13rafarodaRelationship addedrelated to 0049699
2022-08-10 07:13rafarodaRelationship addedrelated to 0032359
2022-08-11 08:22radhakrishnanAssigned ToRetail => radhakrishnan
2022-08-11 08:22radhakrishnanStatusnew => scheduled
2022-08-12 14:16hgbotMerge Request Status => open
2022-08-12 14:16hgbotNote Added: 0140106
2022-08-15 13:52hgbotMerge Request Statusopen => approved
2022-08-15 13:52hgbotResolutionopen => fixed
2022-08-15 13:52hgbotStatusscheduled => closed
2022-08-15 13:52hgbotNote Added: 0140123
2022-08-15 13:52hgbotNote Added: 0140124

Notes
(0140106)
hgbot   
2022-08-12 14:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/23 [^]
(0140123)
hgbot   
2022-08-15 13:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 5d3f809857c73de6534d983c77e70e2095ecf606
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 12-08-2022 15:09:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/5d3f809857c73de6534d983c77e70e2095ecf606 [^]

Fixed ISSUE-49979: Added active condition in combo discount initial validation

---
M src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---
(0140124)
hgbot   
2022-08-15 13:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/23 [^]