Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049975Retail ModulesWeb POSpublic2022-08-09 10:212022-10-06 14:12
ReporterXABIER_AGUADO 
Assigned Toradhakrishnan 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049975: Stop Button doesn't stop the commercial operation right away
DescriptionA stop button should be added to the commercial operation window to be able to put an end to an OPECOM previously validated.

Once we click on the stop button, we should be able to enter an end date, that can be today if we want to stop the commercial operation right away, or a future date if we want to anticipate a change regarding the end date of the commercial operation. The end date will be updated automatically at the stores level.
We should not have the possibility to enter an end date in the past
Steps To ReproduceStep 1 : Creation of a commercial operation

Step 2 : Validation of the OPECOM

Step 3 : Check on webpos - change of price applied

Step 4 : Click on stop button
=> Price back to the initial price on WebPOS : KO
Proposed SolutionChange the Stop process of the commercial operation to set today's date, but also deactivate the registers automatically
Additional Information
TagsFASH
Relationships
has duplicate defect 0050053 closed Retail POS2 [Price List] Cache problems in POS after stopping a commercial operation 
blocks defect 0050419 closed Retail Openbravo ERP API Change: There are two event handlers for product price exceptions and only one is needed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-09 10:21XABIER_AGUADONew Issue
2022-08-09 10:21XABIER_AGUADOAssigned To => Retail
2022-08-09 10:21XABIER_AGUADOTriggers an Emergency Pack => No
2022-08-09 10:21XABIER_AGUADOTag Attached: FASH
2022-08-09 10:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-08-09 13:26radhakrishnanAssigned Toranjith_qualiantech_com => radhakrishnan
2022-08-09 15:42radhakrishnanStatusnew => scheduled
2022-08-10 15:55hgbotNote Added: 0140049
2022-08-17 06:57hgbotNote Added: 0140166
2022-08-17 06:57hgbotResolutionopen => fixed
2022-08-17 06:57hgbotStatusscheduled => closed
2022-08-17 06:57hgbotNote Added: 0140167
2022-08-18 15:36hgbotNote Added: 0140235
2022-08-18 16:27hgbotNote Added: 0140237
2022-08-18 16:27hgbotNote Added: 0140238
2022-08-19 14:35hgbotNote Added: 0140247
2022-08-19 14:36hgbotNote Added: 0140248
2022-08-19 14:36hgbotNote Added: 0140249
2022-08-25 11:28hgbotNote Added: 0140391
2022-09-29 12:08hgbotNote Added: 0141500
2022-09-29 12:08hgbotNote Added: 0141501
2022-09-29 13:08hgbotNote Added: 0141507
2022-10-05 12:19hgbotNote Added: 0141674
2022-10-05 13:16marvintmRelationship addedblocks 0050419
2022-10-05 13:19hgbotNote Added: 0141677
2022-10-05 13:19hgbotNote Added: 0141678
2022-10-06 07:59hgbotNote Added: 0141709
2022-10-06 14:12hgbotNote Added: 0141738
2022-10-10 15:28ranjith_qualiantech_comRelationship addedhas duplicate 0050053

Notes
(0140049)
hgbot   
2022-08-10 15:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/9 [^]
(0140166)
hgbot   
2022-08-17 06:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/9 [^]
(0140167)
hgbot   
2022-08-17 06:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 9aba0f9e40ea42a5913091e7b34d10e25652a733
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 17-08-2022 04:56:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/9aba0f9e40ea42a5913091e7b34d10e25652a733 [^]

Fixed ISSUE-49975: Disable ProductPriceException when stopping commercial operation
* When stop the commercial operation,if end date is equal to current date then disable product price exception

---
M src/org/openbravo/commercialoperations/process/StopCommercialOperationProcess.java
---
(0140235)
hgbot   
2022-08-18 15:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/11 [^]
(0140237)
hgbot   
2022-08-18 16:27   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 74e58feefffcee1e3b91e5bfcb15f862341a6b84
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 18-08-2022 19:00:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/74e58feefffcee1e3b91e5bfcb15f862341a6b84 [^]

Related to ISSUE-49975: Updated StopCommercialOperationProcessTest
* ProductPriceException should be filtered out without active filter

---
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
---
(0140238)
hgbot   
2022-08-18 16:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/11 [^]
(0140247)
hgbot   
2022-08-19 14:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/12 [^]
(0140248)
hgbot   
2022-08-19 14:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/12 [^]
(0140249)
hgbot   
2022-08-19 14:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: fdde3a04b18528f561ad76ca4f05a599fd803b94
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 19-08-2022 17:52:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/fdde3a04b18528f561ad76ca4f05a599fd803b94 [^]

Related to ISSUE-49975: Ignored stopProductPriceExceptionsInsertedUsingProcessDefinitionHandler

---
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
---
(0140391)
hgbot   
2022-08-25 11:28   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/694 [^]
(0141500)
hgbot   
2022-09-29 12:08   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e644c8e04742b448d1d9338788c38c32a53680d6
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 29-09-2022 10:08:26
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e644c8e04742b448d1d9338788c38c32a53680d6 [^]

Related to ISSUE-49975: Update ProductPriceExc audit when ProductPriceExc is updated
* Removed m_pp_exc_update_trg trigger for ProductPriceException
and its logic moved to ProductPriceException event handler
* ProductPrice audit fields should be updated when ProductPriceException audit fields updated
* Merged duplicate event handlers for ProductPriceException

---
M src/org/openbravo/event/ProductPriceExceptionEventHandler.java
R src-db/database/model/triggers/M_PP_EXC_UPDATE_TRG.xml
R src/org/openbravo/event/ProductPriceExceptionsEventHandler.java
---
(0141501)
hgbot   
2022-09-29 12:08   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/694 [^]
(0141507)
hgbot   
2022-09-29 13:08   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: a125db5cae27fda8e5da346ec5d98e792ea25020
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 29-09-2022 13:07:54
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a125db5cae27fda8e5da346ec5d98e792ea25020 [^]

Related to ISSUE-49975: Reverted previous commit as it was causing API change

---
A src-db/database/model/triggers/M_PP_EXC_UPDATE_TRG.xml
A src/org/openbravo/event/ProductPriceExceptionsEventHandler.java
---
(0141674)
hgbot   
2022-10-05 12:19   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/725 [^]
(0141677)
hgbot   
2022-10-05 13:19   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 14e6b91c7cda5d5c5a100965d54da255cdb3fff8
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 05-10-2022 10:55:36
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/14e6b91c7cda5d5c5a100965d54da255cdb3fff8 [^]

Related to ISSUE-49975: Update ProductPriceExc audit when ProductPriceExc is updated
* Removed m_pp_exc_update_trg trigger for ProductPriceException
and its logic moved to ProductPriceException event handler
* ProductPrice audit fields should be updated when ProductPriceException audit fields updated
* Merged duplicate event handlers for ProductPriceException

---
R src-db/database/model/triggers/M_PP_EXC_UPDATE_TRG.xml
R src/org/openbravo/event/ProductPriceExceptionsEventHandler.java
---
(0141678)
hgbot   
2022-10-05 13:19   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/725 [^]
(0141709)
hgbot   
2022-10-06 07:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 7e6bec06827fcf7098864a72d11acf4213026c8b
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 06-10-2022 11:28:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/7e6bec06827fcf7098864a72d11acf4213026c8b [^]

Related to ISSUE-49975: Enabled stopProductPriceExceptionsInsertedUsingProcessDefinitionHandler test

---
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
---
(0141738)
hgbot   
2022-10-06 14:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: a7aa9ac13f4d7dc1a366576a2be2d2150fbcb9b0
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 06-10-2022 17:38:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/a7aa9ac13f4d7dc1a366576a2be2d2150fbcb9b0 [^]

Related to ISSUE-49975: Removed unused imports

---
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
---