Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049943Openbravo ERPA. Platformpublic2022-08-03 23:272022-11-02 13:42
Reporterrafaroda 
Assigned Tomontse_cabanas 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049943: Discounts and Promotions - Add Organizations button and roles odd behavior
DescriptionDiscounts and Promotions - Add Organizations button and roles odd behavior

With a role definition and org access to a parent organization, when adding records in subtab Organization of Discounts and Promotions window (same happens in OTF Generation Rules window) using Add Organizations button, we get an error message like Organization E443A31992CB4635AFCAEABE7183CE85 of object (PricingAdjustmentOrganization(144D209D6B7F4164AABE095D928EEAB7) (priceAdjustment: EE555A825B954E9A986991E7521DEB8A, organization: E443A31992CB4635AFCAEABE7183CE85)) is not present in OrganizationList [0, B843C30461EA4501935CB1D125C9C25A]
Steps To ReproduceSee video https://drive.google.com/file/d/1OFPEuLRT3Dg7N0MaC8NuwHj3w4Eho0ZD/view?usp=sharing [^]
* In Live Builds for F&B International https://livebuilds.openbravo.com/retail_modules_pgsql_pi/security/Login [^]
* We define a role Marketing Manager F&B España, S.A, with Org Access F&B España (in the organization tree it is above F&B España Region Norte and F&B España Region Sur), and access to Discounts and Promotions window
* We create a user mmanageres with role acess Marketing Manager F&B España, S.A
* We now log with user mmanageres and go to Discounts and Promotions window: we create a header
* We go to Organization subtab and try to add a record: we can only add F&B España and *
* We use Add Organization button: we can see tree of organization, including F&B España Region Norte and F&B España Region Sur but when selecting them we get an error message
Proposed SolutionIn order to avoid such errors in the process, in ADD ORGANIZATION popup button you should only display the organizations the user has access to in his Role > Org Access tab

This is to be fixed in ADD ORGANIZATION popup button in the windows:
* Discounts and Promotions
* OTF Generation Rules
Additional Information
TagsFASH
Relationships
related to feature request 0050392 closed montse_cabanas Retail Modules Add new stores created via Copy Retail Store to existing roles 
Attached Filespng Screenshot from 2022-08-03 23-19-18.png (120,865) 2022-08-03 23:27
https://issues.openbravo.com/file_download.php?file_id=17368&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-08-03 23:27rafarodaNew Issue
2022-08-03 23:27rafarodaAssigned To => Triage Platform Base
2022-08-03 23:27rafarodaFile Added: Screenshot from 2022-08-03 23-19-18.png
2022-08-03 23:27rafarodaOBNetwork customer => No
2022-08-03 23:27rafarodaModules => Core
2022-08-03 23:27rafarodaTriggers an Emergency Pack => No
2022-08-03 23:27rafarodaTag Attached: FASH
2022-10-03 15:28rafarodaOBNetwork customerNo => Gold
2022-10-03 15:28rafarodaTypedesign defect => defect
2022-10-03 15:28rafarodaProposed Solution updated
2022-10-20 14:32AugustoMauchAssigned ToTriage Platform Base => Triage Omni OMS
2022-10-20 15:54rafarodaRelationship addedrelated to 0050392
2022-10-25 12:39aferrazAssigned ToTriage Omni OMS => montse_cabanas
2022-10-25 17:26hgbotMerge Request Status => open
2022-10-25 17:26hgbotNote Added: 0142569
2022-10-26 18:30hgbotNote Added: 0142617
2022-11-02 13:39hgbotMerge Request Statusopen => approved
2022-11-02 13:40hgbotResolutionopen => fixed
2022-11-02 13:40hgbotStatusnew => closed
2022-11-02 13:40hgbotNote Added: 0142807
2022-11-02 13:40hgbotFixed in Version => PR23Q1
2022-11-02 13:40hgbotNote Added: 0142808
2022-11-02 13:42hgbotNote Added: 0142809
2022-11-02 13:42hgbotNote Added: 0142810

Notes
(0142569)
hgbot   
2022-10-25 17:26   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/742 [^]
(0142617)
hgbot   
2022-10-26 18:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/18 [^]
(0142807)
hgbot   
2022-11-02 13:40   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/742 [^]
(0142808)
hgbot   
2022-11-02 13:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2010652e23904bc3a74f7d0fc9e69c1bf801e24b
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 02-11-2022 12:40:41
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2010652e23904bc3a74f7d0fc9e69c1bf801e24b [^]

Fixes ISSUE-49943: Add organizations popup button should only display the ones the user has access to in the Role | Org Access tab

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0142809)
hgbot   
2022-11-02 13:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: e914abea27f40dac2ef1b5cde4a223de3262f994
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 02-11-2022 12:42:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/e914abea27f40dac2ef1b5cde4a223de3262f994 [^]

Fixes ISSUE-49943: Add organizations popup button should only display the ones the user has access to in the Role | Org Access tab

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0142810)
hgbot   
2022-11-02 13:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/18 [^]