Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049933POS2POSpublic2022-08-02 10:132022-10-21 13:31
Reporterplujan 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049933: [Services] If a Service Product is defined as "Included Product Categories" can be added as a service of itself
DescriptionIf a Service Product has been created for the same Category that the products it should be applied to, it will allow to be added as a service for itself
Steps To ReproduceScenario A (working as expected):
1. Add to a ticket the product "GPS Handheld"
2. Open the services and select "Installation pack"
3. In the ticket lines, select all the lines. Notice that there are no available services

Scenario B (failing):
1. Add to a ticket the product "All mountain ski board Cham"
2. Open the services and select "Repair boot"
3. In the ticket lines, select all the lines. Notice that "Repair boot" is still available and it can be assigned to the "Repair boot" line which has no sense

"Installation pack" for "GPS Handheld" has been defined as "Included Products", while "Repair boot" has been defined as "Included Product Categories" and its Category is the same as "All mountain ski board Cham" thus allowing this recursive behaviour
Proposed Solution
Additional Information
TagsFASH
Relationships
related to defect 0049931 closed dbaz [UX] "Visited" check in Services icon is only shown for the first line 
related to defect 0049930 new Retail [UX] "Services related for Product" is not cleared after deleting a ticket 
related to defect 0049932 new Retail [UX] Inconsistent icons after visiting the available Services for a product 
related to feature request 0050587 new Retail In multiselect mode, support specifying which lines are selectable or not 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-08-02 10:13plujanNew Issue
2022-08-02 10:13plujanAssigned To => Retail
2022-08-02 10:13plujanTriggers an Emergency Pack => No
2022-08-03 22:39rafarodaSeverityminor => major
2022-08-03 22:39rafarodaTag Attached: FASH
2022-08-03 22:41rafarodaRelationship addedrelated to 0049931
2022-08-03 22:42rafarodaRelationship addedrelated to 0049930
2022-08-03 22:43rafarodaRelationship addedrelated to 0049932
2022-10-19 14:21cbernerRelationship addedrelated to 0050587
2022-10-19 14:23hgbotNote Added: 0142284
2022-10-21 13:30hgbotResolutionopen => fixed
2022-10-21 13:30hgbotStatusnew => closed
2022-10-21 13:30hgbotNote Added: 0142418
2022-10-21 13:30hgbotFixed in Version => 23Q1
2022-10-21 13:30hgbotNote Added: 0142419
2022-10-21 13:31caristuAssigned ToRetail => cberner

Notes
(0142284)
hgbot   
2022-10-19 14:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1296 [^]
(0142418)
hgbot   
2022-10-21 13:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1296 [^]
(0142419)
hgbot   
2022-10-21 13:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 41ecc8beff8f103b214e62596447dd57225df27e
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 21-10-2022 10:52:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/41ecc8beff8f103b214e62596447dd57225df27e [^]

Fixes ISSUE-49933: If a Service Product is defined as "Included Product Categories" can be added as a service of itself

It was possible to add a service to itself in that case. To fix it, we
don't show any result when some service is selected in the
multiselection, that will make sure it is not possible to add a service
to another service.

This should be reviewed when FR-50587 is fixed, as that will make this
fix obsolete and no longer necessary.

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/ApplyServiceProductSearchFilters.js
---