Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049908POS2POSpublic2022-07-29 07:382023-05-10 13:57
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049908: Remove incorrect implicit dependency on bytotal module
DescriptionCurrently the React POS implicitly depends on the by total module, because it includes a button ("Receipt discounts") that indirectly requires the by total manual rules to exist.

This is not correct because there is no explicitly set dependency on the module.
Steps To ReproduceVerify that the React POS actually requires the by total module for the Receipt Discounts feature to work correctly
Proposed SolutionThere are two ways to fix this:
- We can include the org.openbravo.retail.discounts.bytotal in the pack. However, this would just add unnecessary overhead.
- We can include the bytotal rules in the main discounts module and remove them from the bytotal module (the module must still exist as it includes the "Free products" and other rules that are relevant)

Most probably this last option is the preferred course of action.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050721 closed alostale Openbravo ERP Compilation should fail if a merged module is present in the modules source folder 
related to defect 0050713 closed Retail Retail Modules API Change: New constraints added as part of the merge of the bytotal module 
causes defect 0052692 closed ranjith_qualiantech_com Retail Modules ADMessage in missing in discounts module 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-29 07:38marvintmNew Issue
2022-07-29 07:38marvintmAssigned To => Retail
2022-07-29 07:38marvintmTriggers an Emergency Pack => No
2022-07-29 07:38marvintmTypedefect => design defect
2022-07-29 07:41marvintmProposed Solution updated
2022-07-29 10:52shuehnerIssue Monitored: shuehner
2022-07-31 13:44ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-08-09 15:15ranjith_qualiantech_comStatusnew => scheduled
2022-09-26 07:04hgbotNote Added: 0141357
2022-09-26 07:04hgbotNote Added: 0141358
2022-09-26 07:04hgbotNote Added: 0141359
2022-09-26 07:04hgbotNote Added: 0141360
2022-09-26 07:04hgbotNote Added: 0141361
2022-09-26 07:04hgbotNote Added: 0141362
2022-11-03 07:44marvintmRelationship addedrelated to 0050713
2022-11-03 08:13hgbotResolutionopen => fixed
2022-11-03 08:13hgbotStatusscheduled => closed
2022-11-03 08:13hgbotFixed in Version => RR23Q1
2022-11-03 08:13hgbotNote Added: 0142839
2022-11-03 08:13hgbotNote Added: 0142840
2022-11-03 08:13hgbotNote Added: 0142841
2022-11-03 08:13hgbotNote Added: 0142842
2022-11-03 08:13hgbotNote Added: 0142843
2022-11-03 08:14hgbotNote Added: 0142844
2022-11-03 08:14hgbotNote Added: 0142845
2022-11-03 08:14hgbotNote Added: 0142846
2022-11-03 08:14hgbotNote Added: 0142847
2022-11-03 08:14hgbotNote Added: 0142848
2022-11-03 08:14hgbotNote Added: 0142849
2022-11-07 15:48alostaleRelationship addedrelated to 0050721
2022-11-10 09:11hgbotNote Added: 0143340
2022-11-10 09:11hgbotNote Added: 0143341
2022-11-10 09:11hgbotNote Added: 0143342
2022-11-10 09:11hgbotNote Added: 0143343
2022-11-21 08:01hgbotNote Added: 0143880
2022-11-21 08:01hgbotNote Added: 0143881
2022-11-21 08:01hgbotNote Added: 0143882
2022-11-21 08:01hgbotNote Added: 0143883
2022-11-21 08:01hgbotNote Added: 0143884
2022-11-21 08:01hgbotNote Added: 0143885
2022-11-21 08:01hgbotNote Added: 0143886
2022-11-21 08:01hgbotNote Added: 0143887
2023-02-14 15:10hgbotNote Added: 0146536
2023-05-10 13:57hgbotNote Added: 0149563
2023-06-07 12:20ranjith_qualiantech_comRelationship addedcauses 0052692

Notes
(0141357)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/66 [^]
(0141358)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/22 [^]
(0141359)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/3 [^]
(0141360)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/26 [^]
(0141361)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/39 [^]
(0141362)
hgbot   
2022-09-26 07:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/33 [^]
(0142839)
hgbot   
2022-11-03 08:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: a0c1484512f24e22b9cfa0f79f600c28dee476e8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-10-2022 22:31:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/a0c1484512f24e22b9cfa0f79f600c28dee476e8 [^]

Fixed ISSUE-49908: Merged bytotal discount module

---
A src-db/database/model/tables/DISCT_FREEPRODUCT.xml
A src-db/database/model/tables/DISCT_SCALEDBYTOTAL.xml
A src-db/database/sourcedata/AD_DATASET_TABLE.xml
A src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A src-db/database/sourcedata/AD_MODULE_MERGE.xml
A src-db/database/sourcedata/OBMOBC_SERVICES.xml
A src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
A src-db/database/sourcedata/OBUIAPP_PROCESS.xml
A src-test/org/openbravo/retail/discounts/StandaloneTestSuite.java
A src-test/org/openbravo/retail/discounts/actionhandler/ImportFreeProductInDiscountTest.java
A src-test/org/openbravo/retail/discounts/actionhandler/OfferPickFreeProductActionHandlerTest.java
A src-test/org/openbravo/retail/discounts/test/base/model/ByTotalDiscountsFromUser.java
A src-test/org/openbravo/retail/discounts/test/base/model/FreeItem.java
A src-test/org/openbravo/retail/discounts/test/base/model/ScaledBytotalStep.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmountScaled.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalFreeItems.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalManualPromotions.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentage.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentageScaled.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/FixedDiscountPerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/FixedPercentagePerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/VariableDiscountPerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/VariablePercentagePerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalAmountScaledTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalFreeItemsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalPercentageScaledTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalPercentageTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountFixedDiscountPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountFixedPercentagePerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountVariableDiscountPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountVariablePercentagePerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/CheckDiscountByTotalTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I35975_VerifyFreeProductsPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I37027_VerifyManualDiscountsByTotalTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I39536_VerifyTotalDiscountWithSplitLinesTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40007_VerifyWhenAddDiscFixed5EuroTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40460_VerifyTotalDiscountWithPriorityTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40666_VerifyTotalDiscountWithNonGroupedProductTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40812_VerifyMultiManualTotalDiscountsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I41097_VerifyManualAndTotalDiscountsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I41397_VerifyNoNegativeTotalPriceWithManualDiscountsTest.java
A src/org/openbravo/retail/discounts/ByTotalDataHook.java
A src/org/openbravo/retail/discounts/ByTotalUtils.java
A src/org/openbravo/retail/discounts/actionhandler/ImportFreeProductInDiscount.java
A src/org/openbravo/retail/discounts/actionhandler/OfferPickFreeProductActionHandler.java
A src/org/openbravo/retail/discounts/master/FreeProduct.java
A src/org/openbravo/retail/discounts/master/FreeProductProperties.java
A src/org/openbravo/retail/discounts/master/ScaledBytotal.java
A src/org/openbravo/retail/discounts/master/ScaledBytotalProperties.java
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/masterdata/DiscountFilterFreeProductModel.js
A web/org.openbravo.retail.discounts/app/model/masterdata/DiscountFilterScaledBytotalModel.js
A web/org.openbravo.retail.discounts/css/ob-upload-free-products.css
A web/org.openbravo.retail.discounts/js/deleteDiscountExtension.js
A web/org.openbravo.retail.discounts/js/enableApplyButtonHook.js
A web/org.openbravo.retail.discounts/js/preApplyDiscountsHook.js
A web/org.openbravo.retail.discounts/js/promotion-by-total-utils.js
A web/org.openbravo.retail.discounts/js/promotionManualByTotal.js
A web/org.openbravo.retail.discounts/js/ticketdiscountExtension.js
A web/org.openbravo.retail.discounts/js/uploadFreeProductsButton.js
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/M_OFFER_TYPE.xml
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountsUnitTestSuite.java
M src/org/openbravo/retail/discounts/DiscountsComponentProvider.java
M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0142840)
hgbot   
2022-11-03 08:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/66 [^]
(0142841)
hgbot   
2022-11-03 08:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: fd7c476578c4eac794dff011df268d969c8c5e70
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 03-11-2022 08:12:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/fd7c476578c4eac794dff011df268d969c8c5e70 [^]

Fixed ISSUE-49908: Merged org.openbravo.retail.discounts.bytotal module into org.openbravo.retail.discounts module. Functionality will not be affected, this is just a technical merge. Merge branch 'fix/49908'

---
A src-db/database/model/tables/DISCT_FREEPRODUCT.xml
A src-db/database/model/tables/DISCT_SCALEDBYTOTAL.xml
A src-db/database/sourcedata/AD_DATASET_TABLE.xml
A src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A src-db/database/sourcedata/AD_MODULE_MERGE.xml
A src-db/database/sourcedata/OBMOBC_SERVICES.xml
A src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
A src-db/database/sourcedata/OBUIAPP_PROCESS.xml
A src-test/org/openbravo/retail/discounts/StandaloneTestSuite.java
A src-test/org/openbravo/retail/discounts/actionhandler/ImportFreeProductInDiscountTest.java
A src-test/org/openbravo/retail/discounts/actionhandler/OfferPickFreeProductActionHandlerTest.java
A src-test/org/openbravo/retail/discounts/test/base/model/ByTotalDiscountsFromUser.java
A src-test/org/openbravo/retail/discounts/test/base/model/FreeItem.java
A src-test/org/openbravo/retail/discounts/test/base/model/ScaledBytotalStep.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmountScaled.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalFreeItems.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalManualPromotions.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentage.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentageScaled.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/FixedDiscountPerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/FixedPercentagePerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/VariableDiscountPerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/base/model/definition/VariablePercentagePerTotalAmount.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalAmountScaledTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalFreeItemsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalPercentageScaledTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountByTotalPercentageTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountFixedDiscountPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountFixedPercentagePerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountVariableDiscountPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountVariablePercentagePerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/CheckDiscountByTotalTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I35975_VerifyFreeProductsPerTotalAmountTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I37027_VerifyManualDiscountsByTotalTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I39536_VerifyTotalDiscountWithSplitLinesTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40007_VerifyWhenAddDiscFixed5EuroTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40460_VerifyTotalDiscountWithPriorityTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40666_VerifyTotalDiscountWithNonGroupedProductTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I40812_VerifyMultiManualTotalDiscountsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I41097_VerifyManualAndTotalDiscountsTest.java
A src-test/org/openbravo/retail/discounts/test/unittests/combined/I41397_VerifyNoNegativeTotalPriceWithManualDiscountsTest.java
A src/org/openbravo/retail/discounts/ByTotalDataHook.java
A src/org/openbravo/retail/discounts/ByTotalUtils.java
A src/org/openbravo/retail/discounts/actionhandler/ImportFreeProductInDiscount.java
A src/org/openbravo/retail/discounts/actionhandler/OfferPickFreeProductActionHandler.java
A src/org/openbravo/retail/discounts/master/FreeProduct.java
A src/org/openbravo/retail/discounts/master/FreeProductProperties.java
A src/org/openbravo/retail/discounts/master/ScaledBytotal.java
A src/org/openbravo/retail/discounts/master/ScaledBytotalProperties.java
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-amount-discount.js
A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-percentage-discount.js
A web/org.openbravo.retail.discounts/app/model/masterdata/DiscountFilterFreeProductModel.js
A web/org.openbravo.retail.discounts/app/model/masterdata/DiscountFilterScaledBytotalModel.js
A web/org.openbravo.retail.discounts/css/ob-upload-free-products.css
A web/org.openbravo.retail.discounts/js/deleteDiscountExtension.js
A web/org.openbravo.retail.discounts/js/enableApplyButtonHook.js
A web/org.openbravo.retail.discounts/js/preApplyDiscountsHook.js
A web/org.openbravo.retail.discounts/js/promotion-by-total-utils.js
A web/org.openbravo.retail.discounts/js/promotionManualByTotal.js
A web/org.openbravo.retail.discounts/js/ticketdiscountExtension.js
A web/org.openbravo.retail.discounts/js/uploadFreeProductsButton.js
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/M_OFFER_TYPE.xml
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountsUnitTestSuite.java
M src/org/openbravo/retail/discounts/DiscountsComponentProvider.java
M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0142842)
hgbot   
2022-11-03 08:13   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests [^]
Changeset: 231483899b21d373a182261cbd47a6bfb315e1a5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-10-2022 12:20:54
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/commit/231483899b21d373a182261cbd47a6bfb315e1a5 [^]

Related to ISSUE-49908: Removed ByTotal test suite

---
M src-test/org/openbravo/retail/discounts/tests/DiscountsMainTestSuite.java
---
(0142843)
hgbot   
2022-11-03 08:13   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/3 [^]
(0142844)
hgbot   
2022-11-03 08:14   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/26 [^]
(0142845)
hgbot   
2022-11-03 08:14   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: be36600b898ac0dc74ef12c24af845904e337eaa
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-10-2022 12:08:34
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/be36600b898ac0dc74ef12c24af845904e337eaa [^]

Related to ISSUE-49908: Updated sample data for discounts

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0142846)
hgbot   
2022-11-03 08:14   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 8aebc779e1f8618b098d2c6b0ab87c30fcb446b5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-10-2022 12:08:38
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/8aebc779e1f8618b098d2c6b0ab87c30fcb446b5 [^]

Related to ISSUE-49908: Updated sample data for discounts

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0142847)
hgbot   
2022-11-03 08:14   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/39 [^]
(0142848)
hgbot   
2022-11-03 08:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 45900e6d998123d3ec932c4bfc01a8b75da04a54
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-10-2022 12:10:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/45900e6d998123d3ec932c4bfc01a8b75da04a54 [^]

Related to ISSUE-49908: Updated sample data for discounts

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/OBUIAPP_PROCESS_ACCESS.xml
---
(0142849)
hgbot   
2022-11-03 08:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/33 [^]
(0143340)
hgbot   
2022-11-10 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.fr_FR/-/merge_requests/1 [^]
(0143341)
hgbot   
2022-11-10 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR/-/merge_requests/1 [^]
(0143342)
hgbot   
2022-11-10 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.es_ES/-/merge_requests/1 [^]
(0143343)
hgbot   
2022-11-10 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.es_ES/-/merge_requests/1 [^]
(0143880)
hgbot   
2022-11-21 08:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.fr_FR [^]
Changeset: 7453427f73bdf3434516babcec0338cbd902b8cf
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-11-2022 13:34:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.fr_FR/-/commit/7453427f73bdf3434516babcec0338cbd902b8cf [^]

Related to ISSUE-49908: Merged discounts.bytotal translation into discounts translation module

---
A referencedata/translation/fr_FR/OBUIAPP_PROCESS_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_ELEMENT_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_MESSAGE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REFERENCE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REF_LIST_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_TAB_TRL_fr_FR.xml
M referencedata/translation/fr_FR/M_OFFER_TYPE_TRL_fr_FR.xml
---
(0143881)
hgbot   
2022-11-21 08:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.fr_FR/-/merge_requests/1 [^]
(0143882)
hgbot   
2022-11-21 08:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR [^]
Changeset: 3fe9aca07f8b4c1aba08eb2df1c5f0e17e821a66
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-11-2022 13:34:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR/-/commit/3fe9aca07f8b4c1aba08eb2df1c5f0e17e821a66 [^]

Related to ISSUE-49908: Merged discounts.bytotal translation into discounts translation module

---
M referencedata/translation/fr_FR/AD_ELEMENT_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_MESSAGE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REFERENCE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REF_LIST_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_TAB_TRL_fr_FR.xml
M referencedata/translation/fr_FR/M_OFFER_TYPE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/OBUIAPP_PROCESS_TRL_fr_FR.xml
---
(0143883)
hgbot   
2022-11-21 08:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR/-/merge_requests/1 [^]
(0143884)
hgbot   
2022-11-21 08:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.es_ES [^]
Changeset: fa2de5b1e0770ae9401e6b489a4a64f04b073bcd
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-11-2022 13:34:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.es_ES/-/commit/fa2de5b1e0770ae9401e6b489a4a64f04b073bcd [^]

Related to ISSUE-49908: Merged discounts.bytotal translation into discounts translation module

---
M referencedata/translation/es_ES/AD_ELEMENT_TRL_es_ES.xml
M referencedata/translation/es_ES/AD_MESSAGE_TRL_es_ES.xml
M referencedata/translation/es_ES/AD_TAB_TRL_es_ES.xml
M referencedata/translation/es_ES/M_OFFER_TYPE_TRL_es_ES.xml
---
(0143885)
hgbot   
2022-11-21 08:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.es_ES/-/merge_requests/1 [^]
(0143886)
hgbot   
2022-11-21 08:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.es_ES [^]
Changeset: dda8aeb2bdb004f45510c5608e2475b93bc6e4b0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-11-2022 13:34:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.es_ES/-/commit/dda8aeb2bdb004f45510c5608e2475b93bc6e4b0 [^]

Related to ISSUE-49908: Merged discounts.bytotal translation into discounts translation module

---
M referencedata/translation/es_ES/AD_ELEMENT_TRL_es_ES.xml
M referencedata/translation/es_ES/AD_MESSAGE_TRL_es_ES.xml
M referencedata/translation/es_ES/AD_TAB_TRL_es_ES.xml
M referencedata/translation/es_ES/M_OFFER_TYPE_TRL_es_ES.xml
---
(0143887)
hgbot   
2022-11-21 08:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.es_ES/-/merge_requests/1 [^]
(0146536)
hgbot   
2023-02-14 15:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR [^]
Changeset: 7349bcb1deeed1423041e27998e9c6b45f5be9b6
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 14-02-2023 14:25:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal.fr_FR/-/commit/7349bcb1deeed1423041e27998e9c6b45f5be9b6 [^]

Revert "Related to ISSUE-49908: Merged discounts.bytotal translation into discounts translation module"

This reverts commit 3fe9aca07f8b4c1aba08eb2df1c5f0e17e821a66.

---
M referencedata/translation/fr_FR/AD_ELEMENT_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_MESSAGE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REFERENCE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_REF_LIST_TRL_fr_FR.xml
M referencedata/translation/fr_FR/AD_TAB_TRL_fr_FR.xml
M referencedata/translation/fr_FR/M_OFFER_TYPE_TRL_fr_FR.xml
M referencedata/translation/fr_FR/OBUIAPP_PROCESS_TRL_fr_FR.xml
---
(0149563)
hgbot   
2023-05-10 13:57   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/22 [^]