0049897: Add missing support for referencing other columns in onCreateDefault during importsampledata

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049897

Openbravo ERP

Y. DBSourceManager

public

2022-07-28 13:19

2022-11-18 09:23

Reporter

shuehner

Assigned To

alostale

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

PR22Q4

Fixed in Version

PR22Q4

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049897: Add missing support for referencing other columns in onCreateDefault during importsampledata

Description

onCreateDefault support sql-expressions on top of just fixed constant literals.

That is fully implemented during update.database.

However this logic used during import.sampledata currently only supports constant literals.

We should add support for at least one common case which is referencing another column of the same table (to copy the data from).

Example snippet for a module adding such a column to M_LOCATOR table.

      <column name="NEW_COLUMN_CODE" primaryKey="false" required="true" type="NVARCHAR" size="40" autoIncrement="false">
        <default/>
        <onCreateDefault><![CDATA[VALUE]]></onCreateDefault>
      </column>

Steps To Reproduce

Add a new required column to an existing table with definition shown above (i.e. table M_LOCATOR)
Do NOT modify sampledata to contain data for the new column.
Run install.source and observe not-null constraint violation for the new column.

Proposed Solution

Add code to existing logic supporting 'onCreateDefault for not null column during import.sampledata' to detect:
- Referencing another column on the same table
- Replace column reference by 'value' of that other column planned to be inserted.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0046647		closed	alostale	Neither onCreateDefault nor default values are used when inserting sampledata
related to	feature request	0050951		closed	caristu	onCreateDefault not working for non mandatory columns referencing same table