Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049892POS2POSpublic2022-07-28 09:132022-08-08 11:36
Reporterjorgewederago 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049892: When showing an error in CRM Connector Form a double scroll is rendered
DescriptionIn CRM Connector, if we have a create new customer form that is big enough to render an scroll. Whenever an error is raised using throw Error a second scroll is added to the current window even though it is not needed.
Steps To ReproduceBackend:
1.-Go to CRM Connector Window and change the name of Sample CRM Integration - Proxy to Sample CRM Integration
2.-Go to the organization you are going to use and choose as CRM Connector the one changed

POS2:
1.- Click VBS - Customer
2.- Click on New Customer
3.- Check how the form is rendered
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 49892_CustomerSelector.png (109,358) 2022-08-05 08:14
https://issues.openbravo.com/file_download.php?file_id=17384&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-07-28 09:13jorgewederagoNew Issue
2022-07-28 09:13jorgewederagoAssigned To => Triage Platform Base
2022-07-28 09:13jorgewederagoOBNetwork customer => No
2022-07-28 09:13jorgewederagoTriggers an Emergency Pack => No
2022-07-29 09:08dmiguelezOBNetwork customerNo => Gold
2022-07-29 09:08dmiguelezAssigned ToTriage Platform Base => Retail
2022-08-01 10:16ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-08-01 10:16ranjith_qualiantech_comStatusnew => scheduled
2022-08-01 13:22hgbotMerge Request Status => open
2022-08-01 13:22hgbotNote Added: 0139766
2022-08-03 13:29hgbotMerge Request Statusopen => approved
2022-08-03 13:30hgbotResolutionopen => fixed
2022-08-03 13:30hgbotStatusscheduled => closed
2022-08-03 13:30hgbotFixed in Version => 22Q4
2022-08-03 13:30hgbotNote Added: 0139839
2022-08-03 13:30hgbotNote Added: 0139840
2022-08-05 08:14ranjith_qualiantech_comNote Added: 0139914
2022-08-05 08:14ranjith_qualiantech_comStatusclosed => new
2022-08-05 08:14ranjith_qualiantech_comResolutionfixed => open
2022-08-05 08:14ranjith_qualiantech_comFixed in Version22Q4 =>
2022-08-05 08:14ranjith_qualiantech_comFile Added: 49892_CustomerSelector.png
2022-08-05 08:18hgbotNote Added: 0139915
2022-08-05 08:24ranjith_qualiantech_comNote Edited: 0139914bug_revision_view_page.php?bugnote_id=0139914#r24590
2022-08-08 11:35hgbotNote Added: 0139960
2022-08-08 11:35hgbotNote Added: 0139961
2022-08-08 11:36marvintmStatusnew => scheduled
2022-08-08 11:36marvintmStatusscheduled => resolved
2022-08-08 11:36marvintmFixed in Version => 22Q4
2022-08-08 11:36marvintmResolutionopen => fixed
2022-08-08 11:36marvintmReview Assigned To => marvintm
2022-08-08 11:36marvintmStatusresolved => closed

Notes
(0139766)
hgbot   
2022-08-01 13:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1115 [^]
(0139839)
hgbot   
2022-08-03 13:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5fe6612445f88d5055f598212cdea04b73999d1e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-08-2022 11:29:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5fe6612445f88d5055f598212cdea04b73999d1e [^]

Fixed ISSUE-49892: Scroll bar should not be shown in Customer Popup if notification is showing
* In Customer popup, if notification content has more than 3 lines, then ellipsis will be displayed
* In Customer Selector popup, if notification content has more than 2 lines, then ellipsis will be displayed

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss
---
(0139840)
hgbot   
2022-08-03 13:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1115 [^]
(0139914)
ranjith_qualiantech_com   
2022-08-05 08:14   
(edited on: 2022-08-05 08:24)
Scroll happens in Customer Selector when Customer is not found.
Please check attached Image: 49892_CustomerSelector.png
(0139915)
hgbot   
2022-08-05 08:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1126 [^]
(0139960)
hgbot   
2022-08-08 11:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: eb6b7f9aa913d6a77134687e391d8c676421c46d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 08-08-2022 09:35:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/eb6b7f9aa913d6a77134687e391d8c676421c46d [^]

Related to ISSUE-49892: Removed Customer Selector Notification
* Replaced Customer Selector Notification with BaseForm Notification
  when customer is not found

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss
---
(0139961)
hgbot   
2022-08-08 11:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1126 [^]