Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049884POS2POSpublic2022-07-27 11:192023-06-21 15:43
Reportergorka_gil 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049884: Implement semi-automatic discounts in pos2
DescriptionImplement semi-automatic discounts in pos2
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0049893 closed sreehari [22Q3] Specific steps duplicate discounts even with discounts that are supposed not to be added more than once 
related to defect 0050371 closed alostale optional discounts do not take into account CRM property conditions 
causes defect 0050184 closed gorka_gil Payment impossible in the environnement 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-27 11:19gorka_gilNew Issue
2022-07-27 11:19gorka_gilAssigned To => gorka_gil
2022-07-27 11:19gorka_gilTriggers an Emergency Pack => No
2022-07-27 11:27hgbotNote Added: 0139639
2022-08-01 16:40hgbotNote Added: 0139772
2022-08-09 17:44hgbotNote Added: 0140010
2022-08-24 14:29hgbotNote Added: 0140373
2022-09-04 08:03hgbotNote Added: 0140629
2022-09-04 16:41hgbotNote Added: 0140648
2022-09-04 16:41hgbotNote Added: 0140649
2022-09-06 13:00hgbotNote Added: 0140747
2022-09-06 13:00hgbotNote Added: 0140748
2022-09-06 13:11hgbotNote Added: 0140753
2022-09-06 13:11hgbotResolutionopen => fixed
2022-09-06 13:11hgbotStatusnew => closed
2022-09-06 13:11hgbotFixed in Version => RR22Q4
2022-09-06 13:11hgbotNote Added: 0140754
2022-09-06 13:17hgbotNote Added: 0140755
2022-09-06 13:17hgbotNote Added: 0140756
2022-09-06 13:36hgbotNote Added: 0140757
2022-09-06 13:44hgbotNote Added: 0140758
2022-09-07 10:47marvintmFixed in VersionRR22Q4 => 22Q4
2022-09-07 12:24hgbotNote Added: 0140792
2022-09-07 13:15hgbotNote Added: 0140796
2022-09-07 13:28hgbotNote Added: 0140797
2022-09-07 13:29hgbotNote Added: 0140798
2022-09-07 13:30hgbotNote Added: 0140799
2022-09-07 13:33hgbotNote Added: 0140800
2022-09-07 13:34hgbotNote Added: 0140801
2022-09-07 13:35hgbotNote Added: 0140802
2022-09-07 15:06rafarodaRelationship addedcauses 0050184
2022-09-07 16:58hgbotNote Added: 0140821
2022-09-09 14:34hgbotNote Added: 0140955
2022-09-12 12:39hgbotNote Added: 0141017
2022-09-12 12:39hgbotNote Added: 0141018
2022-09-12 12:40hgbotNote Added: 0141019
2022-09-13 12:57hgbotNote Added: 0141049
2022-09-15 17:21hgbotNote Added: 0141161
2022-09-20 19:10hgbotNote Added: 0141271
2022-09-20 19:10hgbotNote Added: 0141272
2022-09-20 19:13hgbotNote Added: 0141273
2022-09-20 19:13hgbotNote Added: 0141274
2022-09-21 07:41hgbotNote Added: 0141279
2022-09-29 08:17alostaleRelationship addedrelated to 0050371
2022-12-23 15:50hgbotNote Added: 0144993
2023-06-21 15:43hgbotNote Added: 0151445
2023-07-18 09:42sreehariRelationship addedhas duplicate 0049893

Notes
(0139639)
hgbot   
2022-07-27 11:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/60 [^]
(0139772)
hgbot   
2022-08-01 16:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1117 [^]
(0140010)
hgbot   
2022-08-09 17:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/816 [^]
(0140373)
hgbot   
2022-08-24 14:29   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/691 [^]
(0140629)
hgbot   
2022-09-04 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/911 [^]
(0140648)
hgbot   
2022-09-04 16:41   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 61e685b36a937cdd9ca60a75edc3401ac62e2dcb
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 04-09-2022 16:40:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/61e685b36a937cdd9ca60a75edc3401ac62e2dcb [^]

Related to ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts'

---
A web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/AbortOnEnterMultiStepProcess.js
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterableGrid.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowRender.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowRender.scss
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/DataGrid.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/__test__/DataGrid.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessAbortButton/MultiStepProcessAbortButton.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessAbortButton/__test__/MultiStepProcessAbortButton.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessBackButton/MultiStepProcessBackButton.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/mock/mockContextData.js
M web-jspack/org.openbravo.core2/src/components/Window/WindowOnEnterMultiStep/WindowOnEnterMultiStepPanel.jsx
M web-jspack/org.openbravo.core2/src/core/I18N.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0140649)
hgbot   
2022-09-04 16:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/816 [^]
(0140747)
hgbot   
2022-09-06 13:00   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e84a47a9f890fd5323a9f48b5524303fe8ccf185
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 06-09-2022 12:53:34
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e84a47a9f890fd5323a9f48b5524303fe8ccf185 [^]

Related to ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts'

---
M src-db/database/model/tables/M_OFFER_TYPE.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140748)
hgbot   
2022-09-06 13:00   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/691 [^]
(0140753)
hgbot   
2022-09-06 13:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/60 [^]
(0140754)
hgbot   
2022-09-06 13:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e7dd23c798ebcfa6796447e650cb87a36f444826
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 06-09-2022 13:10:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e7dd23c798ebcfa6796447e650cb87a36f444826 [^]

Fixed ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts'

---
---
(0140755)
hgbot   
2022-09-06 13:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 31e149c62d6a1d4a629ba8a0ef02a5dd7f2e19d0
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 06-09-2022 13:16:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/31e149c62d6a1d4a629ba8a0ef02a5dd7f2e19d0 [^]

Related to to ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts'

---
---
(0140756)
hgbot   
2022-09-06 13:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1117 [^]
(0140757)
hgbot   
2022-09-06 13:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5d4b6e18aef642f579978ae94e117acd85aa2f9c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 06-09-2022 13:34:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5d4b6e18aef642f579978ae94e117acd85aa2f9c [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] fix variable discounts popup to show with variables instead fixed

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/OrderDiscountInputAmountCell.jsx
---
(0140758)
hgbot   
2022-09-06 13:44   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 1401f0cd5801155828e99ac55f0baa2967251974
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 06-09-2022 13:43:38
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/1401f0cd5801155828e99ac55f0baa2967251974 [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] fix dbconsistency

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140792)
hgbot   
2022-09-07 12:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d41b0878f41f2e00b8da4d2a9e879177f04a89f1
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 12:19:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d41b0878f41f2e00b8da4d2a9e879177f04a89f1 [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] featured discounts: fix payments

- fix error Cannot read properties of undefined (reading 'cloneDeep')
- remove cloneDeep not needed

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
---
(0140796)
hgbot   
2022-09-07 13:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 09d27bc7dd9912099c201472c853c02ebbe303d2
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 07-09-2022 13:15:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/09d27bc7dd9912099c201472c853c02ebbe303d2 [^]

Related to ISSUE-49884:[semiAutomaticDiscounts] Fixed module script in Oracle

---
M build/classes/org/openbravo/retail/discounts/modulescript/FixApplicationMethodData.class
M src-util/modulescript/src/org/openbravo/retail/discounts/modulescript/FixApplicationMethod_data.xsql
---
(0140797)
hgbot   
2022-09-07 13:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo [^]
Changeset: 32d30f0ac9b8f96eb854071e6cc2ad9bb0e8e624
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:26:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/commit/32d30f0ac9b8f96eb854071e6cc2ad9bb0e8e624 [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140798)
hgbot   
2022-09-07 13:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bypaymentmethod [^]
Changeset: 9b6818e7fe0c24e56b400cefe688ba286cae6c49
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:29:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bypaymentmethod/-/commit/9b6818e7fe0c24e56b400cefe688ba286cae6c49 [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140799)
hgbot   
2022-09-07 13:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 38d111dad74bfbf88e492e30dd047095dbc1c549
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:30:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/38d111dad74bfbf88e492e30dd047095dbc1c549 [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140800)
hgbot   
2022-09-07 13:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.cost [^]
Changeset: 096ea6a5010b076f60275896b18e2629da4c332a
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:32:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.cost/-/commit/096ea6a5010b076f60275896b18e2629da4c332a [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140801)
hgbot   
2022-09-07 13:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: c1fe734e868bc63893ea499c9c65c44f11a3b4d3
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:34:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/c1fe734e868bc63893ea499c9c65c44f11a3b4d3 [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140802)
hgbot   
2022-09-07 13:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^]
Changeset: 33be729f840298227495a69303df5a2ba44c9ea3
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 07-09-2022 13:34:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/33be729f840298227495a69303df5a2ba44c9ea3 [^]

Related to ISSUE-49884: Fix dbcons

---
M src-db/database/sourcedata/M_OFFER_TYPE.xml
---
(0140821)
hgbot   
2022-09-07 16:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: fe78e641844a4ee905193b100acc33f9ed634b14
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 07-09-2022 16:58:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/fe78e641844a4ee905193b100acc33f9ed634b14 [^]

Related to ISSUE-49884: Fix moduleScript in Oracle

---
M build/classes/org/openbravo/retail/discounts/modulescript/FixApplicationMethodData.class
M src-util/modulescript/src/org/openbravo/retail/discounts/modulescript/FixApplicationMethod_data.xsql
---
(0140955)
hgbot   
2022-09-09 14:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1189 [^]
(0141017)
hgbot   
2022-09-12 12:39   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 6f72412b9a4b0f5efd6bdc7c1dcb12023fb0378d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 12-09-2022 12:38:35
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/6f72412b9a4b0f5efd6bdc7c1dcb12023fb0378d [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] Fix sampledata consistency

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0141018)
hgbot   
2022-09-12 12:39   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 572ac940bc8af41a92435674b14827a4dea44bbc
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 12-09-2022 12:37:24
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/572ac940bc8af41a92435674b14827a4dea44bbc [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] Fix sampledata consistency

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0141019)
hgbot   
2022-09-12 12:40   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 850c7f74b0a3baaebac2df1595a700ebdd559ae4
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 12-09-2022 12:34:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/850c7f74b0a3baaebac2df1595a700ebdd559ae4 [^]

Related to ISSUE-49884: [semiAutomaticDiscounts] Fix sampledata consistency

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0141049)
hgbot   
2022-09-13 12:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/64 [^]
(0141161)
hgbot   
2022-09-15 17:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1207 [^]
(0141271)
hgbot   
2022-09-20 19:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1189 [^]
(0141272)
hgbot   
2022-09-20 19:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3251cbe85a1dc5404d258b8c79111b7de25dd176
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 20-09-2022 19:09:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3251cbe85a1dc5404d258b8c79111b7de25dd176 [^]

Related to ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts2'

---
---
(0141273)
hgbot   
2022-09-20 19:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e7671b5c0a783651c691355d840156197079594b
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 20-09-2022 19:12:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e7671b5c0a783651c691355d840156197079594b [^]

Related to ISSUE-49884: Merge branch 'fr/49884-semiAutomaticDiscounts2'

---
A web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js
R web-test/model/business-logic/discounts-engine/engine/semiautomatic-discount-engine.test.js
---
(0141274)
hgbot   
2022-09-20 19:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/64 [^]
(0141279)
hgbot   
2022-09-21 07:41   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 8c3fe77d774559d5e7c802cb0346af11d10e225d
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 21-09-2022 07:41:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/8c3fe77d774559d5e7c802cb0346af11d10e225d [^]

Related to ISSUE-49884: removed wrong fieldgroup association that was breaking compilation

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0144993)
hgbot   
2022-12-23 15:50   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/911 [^]
(0151445)
hgbot   
2023-06-21 15:43   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1207 [^]