Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049861POS2Corepublic2022-07-21 12:292022-07-29 09:14
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Statusapproved
Review Assigned Tocaristu
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049861: Improve InputData API
DescriptionSome improvements should be added to the existing InputData API:
  * Possibility to hide OK button from InputDataDialog
  * Allow buttons from StandardInputDataDialog to include optionally a function to be executed when the button is clicked but before it is accepted
  * Allow buttons from StandardInputDataDialog to define if hey should be disabled (from the button definition itself)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0049782 closed jorge-garcia Jira 1854 - Reprint/Resend invoices: Being able to reprint and resend invoices in ReactPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-21 12:29jorge-garciaNew Issue
2022-07-21 12:29jorge-garciaAssigned To => Triage Platform Base
2022-07-21 12:29jorge-garciaOBNetwork customer => No
2022-07-21 12:29jorge-garciaTriggers an Emergency Pack => No
2022-07-21 12:30jorge-garciaAssigned ToTriage Platform Base => jorge-garcia
2022-07-21 12:30jorge-garciaRelationship addedblocks 0049782
2022-07-21 12:35hgbotMerge Request Status => open
2022-07-21 12:35hgbotNote Added: 0139480
2022-07-22 14:03jorge-garciaStatusnew => scheduled
2022-07-22 14:03jorge-garciaReview Assigned To => caristu
2022-07-29 08:15hgbotMerge Request Statusopen => approved
2022-07-29 09:14hgbotResolutionopen => fixed
2022-07-29 09:14hgbotStatusscheduled => closed
2022-07-29 09:14hgbotFixed in Version => 22Q4
2022-07-29 09:14hgbotNote Added: 0139702
2022-07-29 09:14hgbotNote Added: 0139703

Notes
(0139480)
hgbot   
2022-07-21 12:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/802 [^]
(0139702)
hgbot   
2022-07-29 09:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 85251ccee2762ee028c1e15cd0926b5279559614
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 29-07-2022 09:12:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/85251ccee2762ee028c1e15cd0926b5279559614 [^]

Fixes ISSUE-49861: Improve InputData API

Some improvements should be added to the existing InputData API:
  * Possibility to hide OK button from InputDataDialog
  * Allow buttons from StandardInputDataDialog to include optionally
    a function to be executed when the button is clicked but before
    it is accepted
  * Allow buttons from StandardInputDataDialog to define if they
    should be disabled (from the button definition itself).

---
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/__test__/InputDataDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/stories/InputDataDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/__test__/StandardInputDataDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.scss
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialogStoryHolder.jsx
---
(0139703)
hgbot   
2022-07-29 09:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/802 [^]