Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049860POS2POSpublic2022-07-21 12:182022-10-26 18:33
Reporternoemieroussel 
Assigned Toradhakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049860: [SALES] - gift card - assign a customer on the ticket when gift card creation is opened isn't possible
DescriptionWhen assigning a gift card to an Owner without closing the Gift card pop-up, and try to assign a client to the ticket, it automatically asign it to the gift card and not the ticket.
Steps To Reproduce1. In POS2, I add the product gift card.
2. The popup to create a gift card appears.
3. I enter a "gift card owner" => the customer is assigned to the gift card (ok)
4.I enter a customer to assign to the ticket=> the customer is assigned to the gift card and not to the ticket(KO)
Proposed Solution
Additional Information
TagsFASH
Relationships
related to defect 0050009 closed Aaron_Alvarez New customer in creation of Gift Card, configuration of Gift Card not possible 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-21 12:18noemierousselNew Issue
2022-07-21 12:18noemierousselAssigned To => Retail
2022-07-21 12:18noemierousselTriggers an Emergency Pack => No
2022-08-09 10:36XABIER_AGUADOPrioritynormal => high
2022-08-09 10:36XABIER_AGUADOReproducibilityhave not tried => always
2022-08-24 16:40rafarodaTag Attached: FASH
2022-08-24 16:40rafarodaRelationship addedrelated to 0050009
2022-08-24 16:40rafarodaSeverityminor => major
2022-08-26 07:37marvintmStatusnew => scheduled
2022-08-26 07:37marvintmAssigned ToRetail => radhakrishnan
2022-08-30 08:23hgbotNote Added: 0140476
2022-08-30 08:24hgbotNote Added: 0140477
2022-09-12 06:49hgbotResolutionopen => fixed
2022-09-12 06:49hgbotStatusscheduled => closed
2022-09-12 06:49hgbotNote Added: 0140989
2022-09-12 06:49hgbotFixed in Version => 22Q4
2022-09-12 06:49hgbotNote Added: 0140990
2022-09-12 06:49hgbotNote Added: 0140991
2022-09-12 06:49hgbotNote Added: 0140992
2022-10-26 18:25hgbotFixed in Version22Q4 => 23Q1
2022-10-26 18:25hgbotNote Added: 0142614
2022-10-26 18:25hgbotNote Added: 0142616
2022-10-26 18:33hgbotNote Added: 0142620

Notes
(0140476)
hgbot   
2022-08-30 08:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1168 [^]
(0140477)
hgbot   
2022-08-30 08:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/143 [^]
(0140989)
hgbot   
2022-09-12 06:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1168 [^]
(0140990)
hgbot   
2022-09-12 06:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c4dc4b553d64b80f5e9ef65a5e6bff4e794726e6
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 12-09-2022 04:48:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c4dc4b553d64b80f5e9ef65a5e6bff4e794726e6 [^]

Fixed ISSUE-49860: Customer selector should be rendered based on user action
* When selector action is called, respective customer selector only should be rendered
  instead of rendering all customer selectors
* Modified Jest test case inorder to check customer selector should be rendered based
  on user action

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerFormSelector/CustomerFormSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButtonGeneric.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetShowCustomerSelector.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetShowCustomerSelector.js
---
(0140991)
hgbot   
2022-09-12 06:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: d86d3dc20088fd852e7f4cd504ac9715deeea144
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 12-09-2022 04:48:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d86d3dc20088fd852e7f4cd504ac9715deeea144 [^]

Related to ISSUE-49860: Customer selector should be rendered based on user action

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
---
(0140992)
hgbot   
2022-09-12 06:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/143 [^]
(0142614)
hgbot   
2022-10-26 18:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 68fe007bbcad0dab2787ad095d9478fb1d3385a8
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 16:25:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/68fe007bbcad0dab2787ad095d9478fb1d3385a8 [^]

Related to ISSUE-50284: Revert "Fixed ISSUE-49860: Customer selector should be rendered based on user action"

This reverts commit c4dc4b553d64b80f5e9ef65a5e6bff4e794726e6.
With the current fixes, the issue 49860 is no longer reproducible,
because the change bp is now blocked during gift card creation.

Also the fix for the issue 49860 was breaking the automatic open of customer selector when adding the filter.

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerFormSelector/CustomerFormSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButtonGeneric.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetShowCustomerSelector.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetShowCustomerSelector.js
---
(0142616)
hgbot   
2022-10-26 18:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8734c28a562700b66ace630a46c38e6a553fc0ca
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 16:25:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8734c28a562700b66ace630a46c38e6a553fc0ca [^]

Related to ISSUE-50284: Revert workaround after revert the fix for the ISSUE-49860

The fix was breaking the auto bp selector launch

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/viewOrdersOfCustomer.spec.js
---
(0142620)
hgbot   
2022-10-26 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 38fea686d962219f05b7783b9287267c7a263a05
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 26-10-2022 18:30:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/38fea686d962219f05b7783b9287267c7a263a05 [^]

Related to ISSUE-50284: Revert "Related to ISSUE-49860: Customer selector should be rendered based on user action"

This reverts commit d86d3dc20088fd852e7f4cd504ac9715deeea144.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardSale/GiftCardSale.jsx
---