Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049844Retail ModulesLayaway orderpublic2022-07-19 15:022022-08-05 16:22
Reporterjose_duque 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049844: The delivered quantity is incorrect for a cancelled layaway in a cancel and replace
DescriptionWhen we cancel the layaway the delivered quantity is set to "-1".

When we complete a layaway the ordered qty and delivered qty are set to "1"
After cancelling the ordered and delivered are set to "-1" it should be "0" This happens in the cancel and replace.
Steps To Reproduce1. Make a layaway,
check the sales order window in the BO: Ordered Qty = 1, Delivered Qty = 0, Invoiced Qty = 0
check the EDL request, in the JSON we have: Ordered Qty = 1, Delivered Qty = 0, Invoiced Qty = 0

2. Cancel the layaway through a cancel and replace,
sales order in the BO: Ordered = 1, Delivered = 1, Invoiced = 0
EDL request, in the JSON we have: Ordered= 1, Delivered = 0, Invoiced = 0
The data for the returned order after cancelled is good.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049260 closed ranjith_qualiantech_com The delivered quantity is incorrect for a cancelled layaway 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-19 15:02jose_duqueNew Issue
2022-07-19 15:02jose_duqueAssigned To => ranjith_qualiantech_com
2022-07-19 15:02jose_duqueOBNetwork customer => No
2022-07-19 15:02jose_duqueTriggers an Emergency Pack => No
2022-07-19 15:02jose_duqueIssue generated from0049260
2022-07-19 15:11jose_duqueAssigned Toranjith_qualiantech_com =>
2022-07-19 15:34jose_duqueIssue cloned0049846
2022-07-19 15:35jose_duqueAssigned To => Retail
2022-07-29 11:53jose_duqueIssue cloned0049912
2022-07-29 12:14marvintmTypefeature request => defect
2022-08-01 06:45marvintmStatusnew => scheduled
2022-08-01 06:45marvintmAssigned ToRetail => radhakrishnan
2022-08-04 07:38ranjith_qualiantech_comRelationship addedrelated to 0049260
2022-08-05 11:36hgbotMerge Request Status => open
2022-08-05 11:36hgbotNote Added: 0139918
2022-08-05 16:22hgbotMerge Request Statusopen => approved
2022-08-05 16:22hgbotResolutionopen => fixed
2022-08-05 16:22hgbotStatusscheduled => closed
2022-08-05 16:22hgbotFixed in Version => PR22Q4
2022-08-05 16:22hgbotNote Added: 0139930
2022-08-05 16:22hgbotNote Added: 0139931

Notes
(0139918)
hgbot   
2022-08-05 11:36   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/669 [^]
(0139930)
hgbot   
2022-08-05 16:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 81069b321e25ec77b735438c126eabcbd2e3aedf
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 05-08-2022 14:22:02
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/81069b321e25ec77b735438c126eabcbd2e3aedf [^]

Fixed ISSUE-49844: Delivery Quantity should not be updated in Cancel And Replace
* When doing CR, if order doesn't have shipmentlines, then
  Original order and Reverse order's delivery quantity should be updated as 0.
* Added Preference "Leave delivered quantity as 0 when canceling layaways"
  Delivery quantity should be updated as 0 when pref. is enabled

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0139931)
hgbot   
2022-08-05 16:22   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/669 [^]