Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049837POS2POSpublic2022-07-19 10:422022-07-22 12:46
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version22Q3Fixed in Version22Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049837: It is possible to add new products in the ticket when the complete ticket action is in progress
DescriptionIf there are receipt delivery option to choose by the user, a popup is shown to select it. In that moment, it is possible to do some actions (like scan) to add products.
Steps To Reproduce- Create a ticket
- Try to complete it
- When the popup, which ask to choose the receipt delivery option, scan a product
- check that the product is added and the complete ticket action continue
- go to backend and check that the ticket is partially paid.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0049836 closed javierRodriguez It is possible to add new products in the ticket when the complete ticket action is in progress 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-07-19 10:42javierRodriguezTypedefect => backport
2022-07-19 10:42javierRodriguezTarget Version => 22Q3
2022-07-20 11:35hgbotMerge Request Status => open
2022-07-20 11:35hgbotNote Added: 0139448
2022-07-20 12:31hgbotMerge Request Statusopen => approved
2022-07-20 12:33hgbotResolutionopen => fixed
2022-07-20 12:33hgbotStatusscheduled => closed
2022-07-20 12:33hgbotFixed in Version => 22Q3
2022-07-20 12:33hgbotNote Added: 0139450
2022-07-20 12:33hgbotNote Added: 0139451
2022-07-22 12:46hgbotNote Added: 0139548

Notes
(0139448)
hgbot   
2022-07-20 11:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1097 [^]
(0139450)
hgbot   
2022-07-20 12:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c94b16fdbe290a8a051df46a4c7ec30d4e89d3cc
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 20-07-2022 10:33:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c94b16fdbe290a8a051df46a4c7ec30d4e89d3cc [^]

Fixed ISSUE-49837: Avoid to do add product in complete ticket flow

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetCompleteTicketProcess.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/CompleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeliverReceiptPreCompleteTicketHook.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
---
(0139451)
hgbot   
2022-07-20 12:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1097 [^]
(0139548)
hgbot   
2022-07-22 12:46   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d650cbad2a8a486ba0fa24a2cc0da30993f09c3e
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 22-07-2022 12:46:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d650cbad2a8a486ba0fa24a2cc0da30993f09c3e [^]

Related to ISSUE-49837: Fix AskDeliveryOprionsHook tests

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AskDeliveryOptionsHook.test.js
---