Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049832POS2Corepublic2022-07-18 16:182022-08-08 14:35
Reportertimothee_catteeuw 
Assigned TojavierRodriguez 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049832: JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures
DescriptionIn production, there is a case which blocks API sales closure process when closing the till.

It happened when you do a verified return without selecting an amount in payment screen and directly click on finish button.

Be careful because you can have the same behavior for a blind return so to take into account as well

Steps To ReproduceOn Web POS

go to Webpos and login

open sales history

on a paid (and not retuned) order, click verified return option

select 1 or several products and apply button

click refund button

directly click Done button and print button

When “Payment Amount is Wrong” popin appears click “OK”

close your till

On BO :

open the EDL resquest window

you can see an error on API Sales closure process like :

org.openbravo.base.exception.OBException: Error processing order 01940052/0000005 with Exception java.lang.NullPointerExceptionat com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureUtils.setPayments(SalesClosureUtils.java:312)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.buildUniSalesObject(SalesClosureItemProcessor.java:315)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:70)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:50)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.doProcessBatchWithInput(AsynchronousProcessor.java:261)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatchWithInput(AsynchronousProcessor.java:232)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatch(AsynchronousProcessor.java:215)at org.openbravo.externaldata.integration.process.ProcessRequest.processRequestLine(ProcessRequest.java:594)at org.openbravo.externaldata.integration.process.EDLImportEntryProcessor$EDLEntryProcessRunnable.processEntry(EDLImportEntryProcessor.java:157)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338)at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)at java.base/java.lang.Thread.run(Thread.java:829)
Proposed Solution1) oblige the user to select an amount when verified return.
I think it does not make sense to return products from a customer without giving the amount initially paid
2) manage this specific case in the API sales closure (ticket not not fully paid process)
3) deactivate Payment not fully paid process
Additional Information
TagsNo tags attached.
Relationships
depends on backport 004985222Q3 closed javierRodriguez JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures 
Attached Filesgif 49832.gif (1,762,663) 2022-07-20 11:04
https://issues.openbravo.com/file_download.php?file_id=17328&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-07-18 16:18timothee_catteeuwNew Issue
2022-07-18 16:18timothee_catteeuwAssigned To => Triage Platform Base
2022-07-18 16:18timothee_catteeuwTriggers an Emergency Pack => No
2022-07-19 10:27timothee_catteeuwSummaryJIRA 3173 -It is possible to finish a verified return without selecting amount to return (this behavior causes problem on closur => JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures
2022-07-19 10:28timothee_catteeuwProposed Solution updated
2022-07-19 10:30timothee_catteeuwProposed Solution updated
2022-07-20 11:04guilleaerFile Added: 49832.gif
2022-07-20 11:06guilleaerStatusnew => scheduled
2022-07-20 11:06guilleaerAssigned ToTriage Platform Base => javierRodriguez
2022-07-22 11:26hgbotNote Added: 0139544
2022-08-01 12:09hgbotResolutionopen => fixed
2022-08-01 12:09hgbotStatusscheduled => closed
2022-08-01 12:09hgbotFixed in Version => 22Q4
2022-08-01 12:09hgbotNote Added: 0139761
2022-08-01 12:09hgbotNote Added: 0139760
2022-08-03 11:10hgbotNote Added: 0139834
2022-08-08 11:28Aka_felixNote Added: 0139959
2022-08-08 14:35javierRodriguezNote Added: 0139966

Notes
(0139544)
hgbot   
2022-07-22 11:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1101 [^]
(0139760)
hgbot   
2022-08-01 12:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1101 [^]
(0139761)
hgbot   
2022-08-01 12:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 179486b9f4ba1174c0096934ec374261c1b9eec7
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 01-08-2022 10:09:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/179486b9f4ba1174c0096934ec374261c1b9eec7 [^]

Fixed ISSUE-49832: Ensure negative tickets are fully paid before complete them.

Complete ticket executability rule has been refactored to check, first, it the user is working with a negative ticket and, if the ticket is not fully paid, desactive the execution.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/CompleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CompleteTicket.js
---
(0139834)
hgbot   
2022-08-03 11:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d26cc5847da5620a770497a339b6dc024f5769bc
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 03-08-2022 11:10:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d26cc5847da5620a770497a339b6dc024f5769bc [^]

Related to ISSUE-49832: Remove useless mock in TicketUtils tests

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
---
(0139959)
Aka_felix   
2022-08-08 11:28   
I can't make a Return payment with this correctif, i have the message " R is not a function"
(0139966)
javierRodriguez   
2022-08-08 14:35   
This problem is not related with this issue. It is missing a user action entry to get VerifiedReturn from useEnableUserAction hook.