0049818: fill isInvoiced column of c_order - Openbravo Issue Tracking System

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049818

POS2

POS

public

2022-07-15 13:38

2022-07-19 16:13

Reporter

gorka_gil

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

N/A

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049818: fill isInvoiced column of c_order

Description

there are many ways to check that an order was invoiced, in general looks the most standard to check the order lines and see if any has any invoice qty greater than 0.

but for queries that loads the orders to show in the pos do this calculation can be expensive.

Exists already a column isInvoiced in c_order, why not use it? And set it when the ticket is added to any invoice. Including the ones created by the cashup.

When this is implemented these code can be improved:
- in PaidReceiptsFilterProperties.java the set of invoiceCreated can use directly this isInvoiced column.
- in IssueInvoice.js (state action one) it can be removed the check verifyNoInvoiceCreated. (Since no needed to load the ticket to check that this field is correct)

Steps To Reproduce

Proposed Solution

Additional Information