Openbravo Issue Tracking System - POS2
View Issue Details
0049758POS2Restaurantspublic2022-07-07 14:422022-08-08 23:10
timothee_catteeuw 
ruben_jimenez 
normalcriticalalways
closedfixed 
5
 
 
No
0049758: JIRA 3150 - "Do not show" option in modifier group config does not work correctly
The option “do not show” in modifier group window has to allow to set a value in shadow mode when you select a product which is linked to this kind of modifier group.

But by selecting this option the default is not taking into account during transaction containing this kind of product.

It is mandatory to select “show always” option. The problem with taht option is Web pos display the modifier group when you select this kind of product.

actually the request is to be able to send the cooking time and cooking level without any selection on Webpos
because it is always the same value for certain kind of product.
Steps to reproduce :

on BO :

configure a modifier group with just 1 modifier configured as default
and I put the option "visible on add" to “do not show”
then I linked a product to this modifier
and I defined just properties to the product like below :





on Webpos :

Select the product

No modifiers are asked → OK

But after paying the cooking time and cooking level are not taking into account in API kitchen
in order to take into account both properties, it is mandatory to display the modifier during the product selection
No tags attached.
depends on backport 004997222Q3.1 closed ruben_jimenez JIRA 3150 - "Do not show" option in modifier group config does not work correctly 
png image-20220707-123857.png (44,330) 2022-07-07 14:42
https://issues.openbravo.com/file_download.php?file_id=17290&type=bug
png
Issue History
2022-07-07 14:42timothee_catteeuwNew Issue
2022-07-07 14:42timothee_catteeuwAssigned To => Retail
2022-07-07 14:42timothee_catteeuwFile Added: image-20220707-123857.png
2022-07-07 14:42timothee_catteeuwTriggers an Emergency Pack => No
2022-07-07 14:43timothee_catteeuwSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24449#r24449
2022-07-08 11:25ebecerraAssigned ToRetail => ebecerra
2022-07-08 11:25ebecerraStatusnew => scheduled
2022-08-03 16:16hgbotNote Added: 0139853
2022-08-05 00:45mtaalAssigned Toebecerra => ruben_jimenez
2022-08-05 07:53ruben_jimenezNote Added: 0139911
2022-08-05 07:54ruben_jimenezNote Edited: 0139911bug_revision_view_page.php?bugnote_id=0139911#r24588
2022-08-05 16:10hgbotResolutionopen => fixed
2022-08-05 16:10hgbotStatusscheduled => closed
2022-08-05 16:10hgbotFixed in Version => 22Q4
2022-08-05 16:10hgbotNote Added: 0139928
2022-08-05 16:10hgbotNote Added: 0139929
2022-08-08 23:09mtaalStatusclosed => new
2022-08-08 23:09mtaalResolutionfixed => open
2022-08-08 23:09mtaalFixed in Version22Q4 =>
2022-08-08 23:10mtaalStatusnew => scheduled
2022-08-08 23:10mtaalStatusscheduled => resolved
2022-08-08 23:10mtaalResolutionopen => fixed
2022-08-08 23:10mtaalStatusresolved => closed

Notes
(0139853)
hgbot   
2022-08-03 16:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1120 [^]
(0139911)
ruben_jimenez   
2022-08-05 07:53   
(edited on: 2022-08-05 07:54)
Excel with the tests: https://docs.google.com/spreadsheets/d/1U-BYpBPq20zB3A42kgNeTGRc2lhATkdII8x67E_OQDY/edit?usp=sharing [^]

(0139928)
hgbot   
2022-08-05 16:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 811328c4e9a24553635c50c2047a3e3c56b3470e
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 05-08-2022 14:10:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/811328c4e9a24553635c50c2047a3e3c56b3470e [^]

Fixed ISSUE-49758: Include default value of non-visible modifier groups when computing product properties

---
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/getModifiableProductValues.js
M web-jspack/org.openbravo.pos2/src/model/modifierGroup/getAvailableModifierGroups.js
---
(0139929)
hgbot   
2022-08-05 16:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1120 [^]